From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B46FFC43334 for ; Fri, 8 Jul 2022 08:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZrX2baQTwlo8IJEevuUIYQs1UXn58ZC0dLIjc/Xryzw=; b=DjIhtj8yNChVVg 8fFZlwTY19kcQj8ydnhD3ygmB2o9Ss86s3wX5kAyiCUXxo/U0oyxa4QzTRuHYMAFpn7SpjQTaedV8 gad9a9DWxQY86GhK0qNEfbZYM/i1Uowz30dckWbLYTtDvNrhtkqL8/32xxBFiIGS30sWfe2a9uMkB j5x1S1+fs63MiAf3wdaCv23+oXNno9Ok6GzibiAkLBf5lskRjufc+6RBdmdJCrwVp2RiFVbkKkpdK Z6ppRR/nAhwqpLSzEvdXGxdW62a0JQML6qgjcpfyRae5POlFph+ArtdAtfh+faTY7pu2VwVrcZYZ1 WeWOf7zWfpT3d8cs/Gtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9izV-002MU7-Ct; Fri, 08 Jul 2022 08:05:33 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9izS-002MTJ-Jh for linux-arm-kernel@lists.infradead.org; Fri, 08 Jul 2022 08:05:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B82B062619; Fri, 8 Jul 2022 08:05:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23ADFC341C8; Fri, 8 Jul 2022 08:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657267529; bh=QtAuw959KuTNtR8cxJBTQZYkriCeywcshOCm/oZxxx0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Beg0f7gbAlHooxeO1KGbh7oDxPWT+OnCe9cSa/R044hKFWZFckT7cIklOCP1QmW/k IbuOO0z69OvMJ55MQAakcflrglXbQlA0b23rY9uGguSClMJzsbfFXxevInYepP/g16 ZNW8nJQAMhbQtD8YUoomCj5dSTHS1yNTH939EkrgJAueMblB+c5bH2sM/ThhIW2ouG A8m/dlmkKBtGvOEC4yIaP3jCYlc64dUvhmanOuvGk/uhqIKUI1b/eqeXSv1iHyLkAn eOCXS7XjDNEpEdjj6Uvu6m35ccVMI9hmjSvybStlC6YXqH0zxecySxnIhdqxWt8xwW 7HrI+tjpS7QYg== Received: from [213.208.244.172] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1o9izO-0065zO-PW; Fri, 08 Jul 2022 09:05:27 +0100 Date: Fri, 08 Jul 2022 09:05:25 +0100 Message-ID: <87sfnckp16.wl-maz@kernel.org> From: Marc Zyngier To: Reiji Watanabe Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Linux ARM , Schspa Shi , kernel-team@android.com, Oliver Upton Subject: Re: [PATCH 04/19] KVM: arm64: Push checks for 64bit registers into the low-level accessors In-Reply-To: References: <20220706164304.1582687-1-maz@kernel.org> <20220706164304.1582687-5-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 213.208.244.172 X-SA-Exim-Rcpt-To: reijiw@google.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, schspa@gmail.com, kernel-team@android.com, oliver.upton@linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220708_010530_727416_3579AD4E X-CRM114-Status: GOOD ( 25.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 08 Jul 2022 07:13:36 +0100, Reiji Watanabe wrote: > > Hi Marc, > > On Wed, Jul 6, 2022 at 9:43 AM Marc Zyngier wrote: > > > > Make sure the check occurs on every paths where we can pick > > a sysreg from userspace, including the GICv3 paths. > > > > Signed-off-by: Marc Zyngier > > --- > > arch/arm64/kvm/sys_regs.c | 10 ++++------ > > 1 file changed, 4 insertions(+), 6 deletions(-) > > > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > > index 0fbdb21a3600..89e7eddea937 100644 > > --- a/arch/arm64/kvm/sys_regs.c > > +++ b/arch/arm64/kvm/sys_regs.c > > @@ -2656,6 +2656,10 @@ const struct sys_reg_desc *get_reg_by_id(u64 id, > > { > > struct sys_reg_params params; > > > > + /* 64 bit is the only way */ > > + if (KVM_REG_SIZE(id) != sizeof(__u64)) > > + return NULL; > > This doesn't seem to be necessary since the equivalent check > is done by index_to_params(). Ah, well spotted. Amusing how many times we check for the same thing! I'll simplify the patch and amend the commit message. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel