From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4559BC433EF for ; Mon, 27 Jun 2022 18:09:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c7dlo/U+sA1uLwQYutCpULk9I4yrIaOKuCfLiNGdHZ4=; b=O/fiUc2byg1wL9 JquO0hgC5twl5MTY7xAwxJ+PwO7VVPVIq6E1F50/wKbuZ8wGSB25nvkO7DAPxbSyqhuz87uH8KCOL Bi+L2xExaVbH75XHLiPVAchHO7VVmMxlbjGW3JvpPO1aLLzy4CpvXH06jQkNJXg1RGQg6BSWd+0cX Ntb8G9nD5Usernmt5oUs8YcUaOg/gu6iSo7wUATkzCrY7Fh7hleqFhb9s7Y2gN+Sgttf+H08rd+Xe eS37vKOByjouDN9+ZMhZVPHE1VAV066/FgTMVvbvzlM7M543J5me1HLco47MloJohrCSwLY8O2Sae EpOBgrOQyf0G4kM3ovZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5tA8-002LRa-NN; Mon, 27 Jun 2022 18:08:40 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5tA5-002LQ9-KY for linux-arm-kernel@lists.infradead.org; Mon, 27 Jun 2022 18:08:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2D0A1B81A27; Mon, 27 Jun 2022 18:08:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C071BC3411D; Mon, 27 Jun 2022 18:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656353314; bh=ZRmJf7OgZCXbtfyvYVI2o3dIEh+wxX7CqSy/gqEWgFA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DjVNJMztcFKnf/1X0NIJABjC7ayTRi7O/wmvakansiCgmNnxBV5vJ65j+7Ei4HciH Usj0VHa5RWmSCo2qAC/WnZBLB84XrDPtlYBHyo+edQC1s8dJmCb3Q4zGWnUGBpkhVB /pzCw2Dyf6JMzx97hGTzz9WygUOnh2XVfQzbjsLYkAppNzo62NtrnMd39enNped0yu hk2CnzZu26w4FNF1FezC6ikF2BhkVm49naLNprFGhtcYgoFBSvOESLrZnDDGia9kB1 dQ72kgfcoELpZ/U6NviNkZq9aqrrcdqQcxdLh4qbeAmLaAM/1WTqoup8RKYSt4moJU TPj7WduF5UT3A== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1o5tA0-003WmL-Kw; Mon, 27 Jun 2022 19:08:32 +0100 Date: Mon, 27 Jun 2022 19:08:42 +0100 Message-ID: <87sfnqdln9.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , Catalin Marinas , Mark Rutland , Ard Biesheuvel , danielmentz@google.com, saravanak@google.com, kernel-team@android.com Subject: Re: [PATCH 5/6] arm64: Add the arm64.nosme command line option In-Reply-To: References: <20220627151412.1496361-1-maz@kernel.org> <20220627151412.1496361-6-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, linux-arm-kernel@lists.infradead.org, will@kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com, ardb@kernel.org, danielmentz@google.com, saravanak@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_110837_889021_6CA4BCB1 X-CRM114-Status: GOOD ( 19.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 27 Jun 2022 18:04:05 +0100, Mark Brown wrote: > > [1 ] > On Mon, Jun 27, 2022 at 04:14:11PM +0100, Marc Zyngier wrote: > > > +.Linit_sme: /* SME register access and priority mapping */ > > + msr cptr_el2, x0 // Disable SME traps > > + bic x0, x0, #CPTR_EL2_TSM > > + msr cptr_el2, x0 > > Should the first msr there be a mrs? If not it should probably have a > comment explaining what it's doing. Duh. Copy-paste programming, I'm sure it'll go far. :-/ > > > + mov x1, #0 // SMCR controls > > + > > + mrs_s x2, SYS_ID_AA64SMFR0_EL1 > > + ubfx x2, x2, #ID_AA64SMFR0_FA64_SHIFT, #1 // Full FP in SM? > > + cbz x2, .Lskip_sme_fa64 > > I'm sure any firmware authors who enable SME will remember to also > enable FA64 if it's supported in their hardware! I could add check the override here too. It is a bit ugly as SMFR0 isn't encoded as 4 bit features, but hey, why not. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel