From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1722C433EF for ; Fri, 29 Apr 2022 05:51:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6icXYzqhrxhjgkuhJxAwYQG/K+WztZPDO/S79rHoru4=; b=XKnKTtXBTLnmoX dShQVL6j+jX6D3G5No6SsLWFSPYb47PkGCDaJYpb2u7yE3z0LlrQ3RRcUbpBsxObDM6f9ZjvbRJoF 1dlyXdSfFgQ4ylEHnXZUQ+ON0YGTXg7ypp7INhP4AmbBN5XmwtuMBHmgG8XykKISzVx0wHLHN3sSa uJIGO4sFiuGnm4KjaKfZuJtPGIDIokIgIilNp+uQz7G6MD7YIsy3C3vqevDlWGHLDIBRzUa/sk+be rVg5B5MKHOFqqFI+j0JC7zOkE5CGMI4gj8Io8zLSCjlYmEjJi7pmuaFIxryAhU/g4mw8PTZHXJWRl Ao7XmVA11eDPWBtEcYgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkJWJ-009dDX-Ck; Fri, 29 Apr 2022 05:50:23 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkJWF-009dCN-Nl for linux-arm-kernel@lists.infradead.org; Fri, 29 Apr 2022 05:50:21 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0] helo=igor.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkJWE-00063u-9m; Fri, 29 Apr 2022 07:50:18 +0200 References: <20220414100700.1733914-1-s.trumtrar@pengutronix.de> <20220414100700.1733914-3-s.trumtrar@pengutronix.de> <625d4510-e390-49d0-e6b8-2456d22b4c00@foss.st.com> User-agent: mu4e 1.4.13; emacs 29.0.50 From: Steffen Trumtrar To: Alexandre TORGUE Cc: linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Maxime Coquelin Subject: Re: [PATCH 3/3] ARM: dts: stm32: add STM32MP1-based Phytec board Date: Fri, 29 Apr 2022 07:45:02 +0200 In-reply-to: <625d4510-e390-49d0-e6b8-2456d22b4c00@foss.st.com> Message-ID: <87sfpwwi8y.fsf@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: s.trumtrar@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_225019_810654_9808B5D7 X-CRM114-Status: GOOD ( 15.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Alexandre TORGUE writes: > [1. text/plain] > On 4/14/22 12:07, Steffen Trumtrar wrote: >> The Phytec STM32MP1 based SoMs feature up to 1 GB DDR3LP RAM, up to 1 GB eMMC, >> up to 16 MB QSPI and up to 128 GB NAND flash. >> Signed-off-by: Steffen Trumtrar >> --- >> arch/arm/boot/dts/Makefile | 3 +- >> .../dts/stm32mp157-phyboard-stm32mp1.dtsi | 283 +++++++++++++ >> .../dts/stm32mp157c-phycore-stm32mp1-3.dts | 57 +++ >> ...stm32mp157c-phycore-stm32mp15-pinctrl.dtsi | 318 +++++++++++++++ >> .../stm32mp157c-phycore-stm32mp15-som.dtsi | 373 ++++++++++++++++++ >> 5 files changed, 1033 insertions(+), 1 deletion(-) >> create mode 100644 arch/arm/boot/dts/stm32mp157-phyboard-stm32mp1.dtsi >> create mode 100644 arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dts >> create mode 100644 arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi >> create mode 100644 arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-som.dtsi > > Can you split a bit those patches please ? > I can split it into the SOM and the board part. (...) >> diff --git a/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi > > > Why create a new file pinctrl file for your board ? All groups are differents > than existing ones ? > Exactly. Those groups overwrite the existing ones. I could put them directly into arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-som.dtsi, if you think it aids readability. Best regards, Steffen -- Pengutronix e.K. | Dipl.-Inform. Steffen Trumtrar | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel