From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6C31C433F5 for ; Sat, 8 Jan 2022 10:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DDWgcjUipTTkDal4oTHLKdQkKPylHQ0f3/ZD44D2888=; b=yJ8TSR3P/Bj/Ov +YZ6+WiaJ9ywb1uPhAi2jF/9sj/NS586NNbzyQcYnGIAffTMaDu5B/0Tadc6WpGZ+JPUbTooYWISP 2l7NF0UGVtB0jNAc01n6X9IgjRT6cTn6flo6lkSRlyMbQyK7qezFokadypVOME42md6PyPUDgxJv7 a2676J5FJvTWD9cJ0wO77qOkgIJKIbnaE+2sWNHtJpJIaJ345PLBm/UszmPifdbYpRf6n177HCFki TXIJ8BYgk4VS5C7q99cdWTkPrXI+tU9iNdkc1gzS5ABnfIuHSHDoD0t7lCIauPQIx163k6G9EMehg qYQMK5QIG+ttBifRdriw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n69Dh-006IvS-MC; Sat, 08 Jan 2022 10:45:09 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n69Dc-006IuO-Sy; Sat, 08 Jan 2022 10:45:06 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 37D2DB8076A; Sat, 8 Jan 2022 10:45:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6A13C36AE5; Sat, 8 Jan 2022 10:45:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641638701; bh=jzhOp8C6hTySN8VYbW0FS606ZaRRUE4qLQu1l9rI4rU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sgG8ObE6KEsr0n2V5Ld+QHlse5DPN1sFDdn+pwKli1a7E6P/toO+VQjgDc2Gt9rxK k2qFdOO4xTM34DhHtKSVlNp0EwNiOpm+YZq03HVyMP4GJpV54g3UaiXwrlIDYz9fTW F4xbALj2e/8ir9RetHxF5pA4r1gbVevW7HTHQ/18bJafoWjznrfZYOzBQorMveSa5k K+hDJspZWCKW0G4QVmeH1uZ2pQF+IRTPxxQNZRvfG8YuiBjgeUdzIpL4fY4LWeovJ9 uuOQPGsBXuIe4rebsvIfX3M+GJdZJ93A2aa+da+oKTbBeuXyjVEOfGX+2KkXIhNT2C zmwbwvBQKeFHw== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n69DY-00Gk7U-11; Sat, 08 Jan 2022 10:45:00 +0000 Date: Sat, 08 Jan 2022 10:44:59 +0000 Message-ID: <87sftytsk4.wl-maz@kernel.org> From: Marc Zyngier To: Qianggui Song Cc: Thomas Gleixner , Kevin Hilman , Neil Armstrong , Jerome Brunet , Martin Blumenstingl , , , Subject: Re: [PATCH 3/4] irqchip/meson-gpio: add select trigger type callback In-Reply-To: <20220108084218.31877-4-qianggui.song@amlogic.com> References: <20220108084218.31877-1-qianggui.song@amlogic.com> <20220108084218.31877-4-qianggui.song@amlogic.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: qianggui.song@amlogic.com, tglx@linutronix.de, khilman@baylibre.com, narmstrong@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220108_024505_243726_223ECEF0 X-CRM114-Status: GOOD ( 22.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 08 Jan 2022 08:42:17 +0000, Qianggui Song wrote: > > Due to some chips may use different registers and offset, provide > a set trigger type call back. > > Signed-off-by: Qianggui Song > --- > drivers/irqchip/irq-meson-gpio.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/drivers/irqchip/irq-meson-gpio.c b/drivers/irqchip/irq-meson-gpio.c > index 6a7b4fb13452..98419428fcbd 100644 > --- a/drivers/irqchip/irq-meson-gpio.c > +++ b/drivers/irqchip/irq-meson-gpio.c > @@ -55,6 +55,8 @@ struct irq_ctl_ops { > void (*gpio_irq_sel_pin)(struct meson_gpio_irq_controller *ctl, > unsigned int channel, unsigned long hwirq); > void (*gpio_irq_init)(struct meson_gpio_irq_controller *ctl); > + unsigned int (*gpio_irq_sel_type)(struct meson_gpio_irq_controller *ctl, > + unsigned int idx, u32 val); > }; > > struct meson_gpio_irq_params { > @@ -68,16 +70,17 @@ struct meson_gpio_irq_params { > struct irq_ctl_ops ops; > }; > > -#define INIT_MESON_COMMON(irqs, init, sel) \ > +#define INIT_MESON_COMMON(irqs, init, sel, type) \ > .nr_hwirq = irqs, \ > .ops = { \ > .gpio_irq_init = init, \ > .gpio_irq_sel_pin = sel, \ > + .gpio_irq_sel_type = type, \ > }, > > #define INIT_MESON8_COMMON_DATA(irqs) \ > INIT_MESON_COMMON(irqs, meson_gpio_irq_init_dummy, \ > - meson8_gpio_irq_sel_pin) \ > + meson8_gpio_irq_sel_pin, NULL) \ > .edge_single_offset = 0, \ > .pol_low_offset = 16, \ > .pin_sel_mask = 0xff, \ > @@ -85,7 +88,7 @@ struct meson_gpio_irq_params { > > #define INIT_MESON_A1_COMMON_DATA(irqs) \ > INIT_MESON_COMMON(irqs, meson_a1_gpio_irq_init, \ > - meson_a1_gpio_irq_sel_pin) \ > + meson_a1_gpio_irq_sel_pin, NULL) \ > .support_edge_both = true, \ > .edge_both_offset = 16, \ > .edge_single_offset = 8, \ > @@ -279,6 +282,10 @@ static int meson_gpio_irq_type_setup(struct meson_gpio_irq_controller *ctl, > */ > type &= IRQ_TYPE_SENSE_MASK; > > + /* Some controllers may have different calculation method*/ > + if (params->ops.gpio_irq_sel_type) > + return params->ops.gpio_irq_sel_type(ctl, idx, type); > + No. If you are going to indirect these things, indirect them for all implementations and keep the code clean. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel