From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93B69C4338F for ; Thu, 12 Aug 2021 05:43:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47B7360ED5 for ; Thu, 12 Aug 2021 05:43:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 47B7360ED5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3MwtVGI9yh1cx0jPZMg5BPftQr5Iw7/oOWeoWM6X7X4=; b=U6+nrl9G4j+UJd yxXATCtxR6rE5lzFPybxExPY6rBMe//7UdE2caNKM5cmpiI342iXVG86r/fnkROAvLSHMPbe19Kop GbUfGLKSlpSl0G4QNKt6i6VF5LlKUDvexK1Hpe1JV9AxTPBXmBCturg6zb/BkUdIjZoV1AlwtO++M 38lvu+Gs+aXHdz3nW7lKrUaBJZHwOYrK0a0KDFjCGUbZvIes2Dn0KotWuoBmG9LkrNfsjXD1V8lsA hanGIDuDBkqnNWJgyUOxYDVfsFRBRVj2uNWl/2hx+KeYPHx0OLPoH0Lw9fcPQXvtThiSNki/31XV/ RFNU+CMvlTh3sRnIhCbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mE3SC-008i2T-O8; Thu, 12 Aug 2021 05:40:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mE3S8-008i25-Qh for linux-arm-kernel@lists.infradead.org; Thu, 12 Aug 2021 05:40:29 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 88BE060F00; Thu, 12 Aug 2021 05:40:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628746827; bh=iIwawa64i19hlsx+tcPXQ0NVbCFtWVL2NbOR6eRLdJ4=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=Pl89Cu2kNBaJWnO8YSVpeACRwcJh//5YxIwCjujWaoa8SUCp8m2ovXjR/MmNkPxTC Ld9tWxP72KBdOf5mnTgLl55PLi/cUEUmm2YxRBF0SqUd3iGjeIRtBW9lL1+Cpgz+ux wskG882W7clweYrMiJnY06ss/KxXHpGtLVqtFzAw2pqd+S6s0egiZHDFOqMaRcS67T S/VvWYIlEk7TOrY8QXMIti6GKZiyRvrJgA5dbnr8aCP8r+8UGrg7hzvUV4Uutdw2wH IPv1appJ9HFz0NV+AZUEzB8V4jSQ9M+uyEW0TK4h1V8duuEDJlqbW+z+J3v+JS87Vl sln10lZ3bOD2Q== References: <47bacc02-4e34-3208-779c-7072a6261782@omp.ru> User-agent: mu4e 1.6.2; emacs 27.2 From: Felipe Balbi To: Sergey Shtylyov Cc: linux-usb@vger.kernel.org, Greg Kroah-Hartman , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 4/9] usb: gadget: udc: s3c2410: add IRQ check Date: Thu, 12 Aug 2021 08:40:03 +0300 In-reply-to: Message-ID: <87sfzfz0dz.fsf@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210811_224028_922189_350952BF X-CRM114-Status: UNSURE ( 7.06 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sergey Shtylyov writes: > The driver neglects to check the result of platform_get_irq()'s call and > blithely passes the negative error codes to request_irq() (which takes > *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original > error code. Stop calling request_irq() with the invalid IRQ #s. > > Fixes: 188db4435ac6 ("usb: gadget: s3c: use platform resources") > Signed-off-by: Sergey Shtylyov Acked-by: Felipe Balbi -- balbi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel