From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 515A4C433DB for ; Sun, 7 Feb 2021 09:10:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D13864E41 for ; Sun, 7 Feb 2021 09:10:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D13864E41 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tkos.co.il Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-reply-to:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=meY1aKDDw8gi3155DF2Ew4QsFJZ3YlJr4gGmqgw7FS0=; b=wjELpKTCg/2oBK6B/o9y79fqs V/ziuNUJYcUoLguqW81ebg40Qe8HFVMmSTrYo9XJwbKKSjj+xE/8vCsRk8glt+CeOGujeeg9JXa8s EKRtRlmqGcU891Ie7GZqGvf3hS4hbfvqkBOLFBgMvtKFYl/w+ntTIhQIYhwCBrV6KRUMersA8evAE KcTKd/9tzyWxXAEzRcSM8Xhk95j9sCVd0oh6fnuDIpGqZVAGp1/UQew440IcuOfvw+du4eKGto9vI 6Cwn2+LiiEo0nLk4bKVJo9RxgVWV5Z3RRfj7m1Wqnkc6VhRrM3yrlLd91YTPJ4VsRwLxd2aX5aaKv BdLAQymNw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l8g3X-00037j-6w; Sun, 07 Feb 2021 09:08:35 +0000 Received: from guitar.tcltek.co.il ([192.115.133.116] helo=mx.tkos.co.il) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l8g3T-00037E-QR for linux-arm-kernel@lists.infradead.org; Sun, 07 Feb 2021 09:08:33 +0000 Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id BADE64405EB; Sun, 7 Feb 2021 11:08:25 +0200 (IST) References: <59a0d43f34b69406cd320f16edc4e7fabe022bfd.1611756920.git.baruch@tkos.co.il> User-agent: mu4e 1.4.15; emacs 27.1 From: Baruch Siach To: Kathiravan T Subject: Re: [PATCH 3/3] arm64: dts: ipq6018: enable USB2 support In-reply-to: Date: Sun, 07 Feb 2021 11:08:25 +0200 Message-ID: <87sg68xn1y.fsf@tarshish> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210207_040832_089683_015B732C X-CRM114-Status: GOOD ( 18.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vinod Koul , Andy Gross , Kishon Vijay Abraham I , linux-arm-kernel@lists.infradead.org, Balaji Prakash J Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Kathiravan T, Thanks for your review. On Fri, Feb 05 2021, Kathiravan T wrote: > On 2021-01-27 19:50, Baruch Siach wrote: >> From: Kathiravan T >> Signed-off-by: Kathiravan T >> [baruch: adjust regs address/size; drop binding updates; >> drop unsupported quirk properties] >> Signed-off-by: Baruch Siach >> --- >> arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 8 ++++ >> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 48 ++++++++++++++++++++ >> 2 files changed, 56 insertions(+) >> diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts >> b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts >> index 99cefe88f6f2..5aec18308712 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts >> +++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts >> @@ -78,3 +78,11 @@ nand@0 { >> nand-bus-width = <8>; >> }; >> }; >> + >> +&qusb_phy_1 { >> + status = "ok"; >> +}; >> + >> +&usb2 { >> + status = "ok"; >> +}; >> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi >> b/arch/arm64/boot/dts/qcom/ipq6018.dtsi >> index 9fa5b028e4f3..d4a3d4e4a7e9 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi >> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi >> @@ -524,6 +524,54 @@ qrtr_requests { >> }; >> }; >> + qusb_phy_1: qusb@59000 { >> + compatible = "qcom,ipq6018-qusb2-phy"; >> + reg = <0x0 0x059000 0x0 0x180>; >> + #phy-cells = <0>; >> + >> + clocks = <&gcc GCC_USB1_PHY_CFG_AHB_CLK>, >> + <&xo>; >> + clock-names = "cfg_ahb", "ref"; > > As per the bindings, ref clock should be 19.2MHz where the XO in IPQ60xx is > 24MHz. Did the USB enumerated successfully and able to perform read / write > operations? I managed to enumerate an Ethernet USB dongle with only this series applied. But then I tested again with USB storage device. That only worked with downstream clock adjust/period patch: https://source.codeaurora.org/quic/qsdk/oss/kernel/linux-ipq-5.4/commit/?h=fig&id=707d8fa2b481888f4792edc6561e81999301cbcf That patch applies cleanly on top of v5.11-rc4. Is anyone at Codeaurora pushing the dwc3 clock patch upstream? Should I do that? Thanks, baruch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel