From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 022D4C433DF for ; Tue, 28 Jul 2020 08:13:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBE9E20656 for ; Tue, 28 Jul 2020 08:13:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Hx+J1NS4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="qJ2cB5p8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBE9E20656 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-Reply-To:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4GYlOiUDbqe6um9BKNT6yjukH8Az7HYy8AlBB4b7hlQ=; b=Hx+J1NS4+liLojThcP+qUJG3F 1uJGY8yxxZo2FJRNwT8tZLoz0f79SWDM4ds9dbJhnkhtEg0UHC636pMTezJZWSrQQ3mJCXF6g6hNI NO/cnDOa5pcpC6Yyww/yHjjCPCMfXYnfpY1bcx86SZWhXpkqM2Sodoy1qmIopZA1pkHc0gSfffDzr Kgx4QURDDE1WD3hlAcC0Wv5PbfhjXSunJ7vTiTaSMnMFz9D0jRBt2t82oYqCvOKwWu4Z9CDqL/6OY hk0ONBVthPQxatCOkmQUuL7AhZ/qiAHZ6C8dVoaFK48deSLDS7w3Po9516PMjxjpDDmhhIkRMmxFj 1xQsSUKIA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0Khb-0002jy-GS; Tue, 28 Jul 2020 08:11:11 +0000 Received: from esa2.microchip.iphmx.com ([68.232.149.84]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0KhY-0002iR-7o for linux-arm-kernel@lists.infradead.org; Tue, 28 Jul 2020 08:11:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1595923868; x=1627459868; h=references:from:to:cc:subject:in-reply-to:date: message-id:mime-version; bh=4348zSQswPRrH20ua261huy5XthZgYClc7uZbxDiXss=; b=qJ2cB5p8qjLMOHbPmeYUj8EJkuUBNgt42BfmkZKdYLWxRLMc6dgLioQR W/RWhNqsVQPrtT7dyfTJDM20SKiogQw0T1puas4eajRp4thdSrwtsCcGh WIa924yWnKUs5z0CFnLV4uWmxtihVerZx+1Uzuk/4xGWPMJOD2xNAvXuJ OcxDCFwofwZgAppAJ47QEso2lj+jDXix5PlZQU15xlq8XUuFHXguJgy3j LMvZy+bX6off7DF5/IFtX8TssG0pxqVBB3ma7HcIEKu5tFoiUmZuKKPo6 jMC17fS87VmkdmfvI1ZBK+yK1cVQYnDQiUBYUZYuBXS5uIeccyQ2vjd3f g==; IronPort-SDR: u0DQ0eKwBMew6XCiVSZ6TNgz94sf4p5fEp5KHy8R4066+bkamL02aFIDa/PnprqNt7eLr68+0O bdwaZdRFNX3d+PZCspEgWoLORjBExQfhW1PLxMGaME/1kwbkmFz8kyYFa9qIp3tufYwjk+pPtN yA1WkCcvGJwbSgD2GHiaHUjIV/LjQK2/8u8bNmSJdo3H8SmAWPfolmFlnNV80IoZpcshXAYiPe q7Cms7O27/x1xxDD5OZksFJvaZIS2LZWhn70jtDPdXSklcadkY8v3um+VybJnSOzHzkwoVqZR1 3LQ= X-IronPort-AV: E=Sophos;i="5.75,405,1589266800"; d="scan'208";a="83485204" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 28 Jul 2020 01:11:06 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Tue, 28 Jul 2020 01:10:19 -0700 Received: from soft-dev15.microsemi.net.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3 via Frontend Transport; Tue, 28 Jul 2020 01:11:03 -0700 References: <20200724111404.13293-1-lars.povlsen@microchip.com> <20200724111404.13293-5-lars.povlsen@microchip.com> <20200727203847.GA782308@bogus> From: Lars Povlsen To: Rob Herring Subject: Re: [PATCH v4 4/6] dt-bindings: snps, dw-apb-ssi: Add sparx5 support, plus rx-sample-delay-ns property In-Reply-To: <20200727203847.GA782308@bogus> Date: Tue, 28 Jul 2020 10:11:02 +0200 Message-ID: <87sgdcf4a1.fsf@soft-dev15.microsemi.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200728_041108_450539_516604F9 X-CRM114-Status: GOOD ( 15.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Serge Semin , linux-spi@vger.kernel.org, Serge Semin , Mark Brown , linux-arm-kernel@lists.infradead.org, Microchip Linux Driver Support , Peter Rosin , Lars Povlsen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rob Herring writes: > On Fri, Jul 24, 2020 at 01:14:02PM +0200, Lars Povlsen wrote: >> This has the following changes for the snps,dw-apb-ss DT bindings: >> >> - Add "microchip,sparx5-spi" as the compatible for the Sparx5 SoC >> controller >> >> - Add the property "rx-sample-delay-ns" >> >> Signed-off-by: Lars Povlsen >> --- >> .../bindings/spi/snps,dw-apb-ssi.yaml | 21 +++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml >> index c62cbe79f00dd..c0adaad1aa695 100644 >> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml >> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml >> @@ -36,6 +36,8 @@ properties: >> - mscc,ocelot-spi >> - mscc,jaguar2-spi >> - const: snps,dw-apb-ssi >> + - description: Microchip Sparx5 SoC SPI Controller >> + const: microchip,sparx5-spi >> - description: Amazon Alpine SPI Controller >> const: amazon,alpine-dw-apb-ssi >> - description: Renesas RZ/N1 SPI Controller >> @@ -93,6 +95,12 @@ properties: >> - const: tx >> - const: rx >> >> + rx-sample-delay-ns: >> + description: Default value of the rx-sample-delay-ns property. >> + This value will be used if the property is not explicitly defined >> + for a SPI slave device. Default value is 0. See below. >> + $ref: /schemas/types.yaml#/definitions/uint32 > > Don't need a type for properties with unit suffixes. > > Also, add: > > 'default: 0' > Hi Rob! Thank you for your input, all duly noted. ---Lars >> + >> patternProperties: >> "^.*@[0-9a-f]+$": >> type: object >> @@ -107,6 +115,13 @@ patternProperties: >> spi-tx-bus-width: >> const: 1 >> >> + rx-sample-delay-ns: >> + description: SPI Rx sample delay offset, unit is nanoseconds. >> + The delay from the default sample time before the actual >> + sample of the rxd input signal occurs. The "rx_sample_delay" >> + is an optional feature of the designware controller, and the >> + upper limit is also subject to controller configuration. >> + >> unevaluatedProperties: false >> >> required: >> @@ -129,5 +144,11 @@ examples: >> num-cs = <2>; >> cs-gpios = <&gpio0 13 0>, >> <&gpio0 14 0>; >> + rx-sample-delay-ns = <3>; >> + spi-flash@1 { >> + compatible = "spi-nand"; >> + reg = <1>; >> + rx-sample-delay-ns = <7>; >> + }; >> }; >> ... >> -- >> 2.27.0 >> -- Lars Povlsen, Microchip _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel