From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Thu, 30 Mar 2017 18:01:53 +0200 Subject: [PATCH v4 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan In-Reply-To: <20170327194301.1104-5-ralph.sennhauser@gmail.com> (Ralph Sennhauser's message of "Mon, 27 Mar 2017 21:43:00 +0200") References: <20170327194301.1104-1-ralph.sennhauser@gmail.com> <20170327194301.1104-5-ralph.sennhauser@gmail.com> Message-ID: <87shlu92j2.fsf@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Ralph, On lun., mars 27 2017, Ralph Sennhauser wrote: Here again the title should start with ARM: dts: armada-xp. As for the other patch if there is no need for a v5 I will fix it while appliig it. Thanks, Gregory > From: Andrew Lunn > > The mvebu GPIO driver can also perform PWM on some pins. Use the pwm-fan > driver to control the fan of the WRT1900AC, giving us finer grained control > over its speed and hence noise. > > Signed-off-by: Andrew Lunn > URL: https://patchwork.ozlabs.org/patch/427291/ > [Ralph Sennhauser: drop flags paramter from pwms, no longer used] > Signed-off-by: Ralph Sennhauser > --- > arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts > index 9efcf59..6d705f5 100644 > --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts > +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts > @@ -308,13 +308,11 @@ > }; > }; > > - gpio_fan { > + pwm_fan { > /* SUNON HA4010V4-0000-C99 */ > - compatible = "gpio-fan"; > - gpios = <&gpio0 24 0>; > > - gpio-fan,speed-map = <0 0 > - 4500 1>; > + compatible = "pwm-fan"; > + pwms = <&gpio0 24 4000>; > }; > > dsa { > -- > 2.10.2 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com