From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: pxa_dma: remove unused function
Date: Thu, 29 Sep 2016 17:45:22 +0200 [thread overview]
Message-ID: <87shsiaewd.fsf@belgarion.home> (raw)
In-Reply-To: <1475154561-12327-1-git-send-email-baoyou.xie@linaro.org> (Baoyou Xie's message of "Thu, 29 Sep 2016 21:09:21 +0800")
Baoyou Xie <baoyou.xie@linaro.org> writes:
> We get 1 warning when building kernel with W=1:
> drivers/dma/pxa_dma.c:1525:5: warning: no previous prototype for 'pxad_toggle_reserved_channel' [-Wmissing-prototypes]
>
> In fact, this function is called by no one, so this patch removes it.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Okay, yet I'd rather have a revert of commit c91134d91944 ("dmaengine: pxa_dma:
add support for legacy transition") , with the commit message saying:
The conversion of the pxa architecture is now finished for all drivers, so this
functions has fullfilled its purpose and can now be removed.
I have a similar patch in my internal tree, but yours can very well go in, as
long as it is a revert with a statement explaining why it is necessary now and
not before.
Cheers.
--
Robert
prev parent reply other threads:[~2016-09-29 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 13:09 [PATCH] dmaengine: pxa_dma: remove unused function Baoyou Xie
2016-09-29 15:45 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shsiaewd.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox