From mboxrd@z Thu Jan  1 00:00:00 1970
From: arno@natisbad.org (Arnaud Ebalard)
Date: Sat, 22 Nov 2014 08:41:10 +0100
Subject: [PATCHv6 10/10] arm: mvebu: add .dts file for Synology DS414
In-Reply-To: <546FFE9D.2000502@killerwolves.net> (Ben Peddell's message of
 "Sat, 22 Nov 2014 13:10:21 +1000")
References: <cover.1416613429.git.arno@natisbad.org>
 <5b678d6d1f2f42f4bf0d087878b9d8024d463ea7.1416613429.git.arno@natisbad.org>
 <546FFE9D.2000502@killerwolves.net>
Message-ID: <87sihbfzs9.fsf@natisbad.org>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi Ben,

Ben Peddell <klightspeed@killerwolves.net> writes:

> On 22/11/14 09:46, Arnaud Ebalard wrote:
>> +
>> +	syno_id_bit0_pin: syno-id-bit0-pin {
>> +		marvell,pins = "mpp26";
>> +		marvell,function = "gpio";
>> +	};
>> +
>> +	pmx_syno_id_bit1: syno-id-bit1-pin {
>> +		marvell,pins = "mpp28";
>> +		marvell,function = "gpio";
>> +	};
>> +
>> +	pmx_syno_id_bit2: syno-id-bit2-pin {
>> +		marvell,pins = "mpp29";
>> +		marvell,function = "gpio";
>> +	};
>> +
>> +	pmx_fan1_alarm: fan1-alarm-pin {
>> +		marvell,pins = "mpp33";
>> +		marvell,function = "gpio";
>> +	};
>
> It looks like you forgot to replace pmx_* with *_pin here.

Indeed. Weird it went unnoticed during compilation. Thanks for
pointing it, Ben.

Cheers,

a+