From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Russell King <linux@armlinux.org.uk>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] ARM: at91: remove unnecessary of_platform_default_populate calls
Date: Mon, 27 Apr 2026 17:07:01 +0200 [thread overview]
Message-ID: <87tsswfnmy.fsf@bootlin.com> (raw)
In-Reply-To: <20260424-worried-renewal-924d34ed945c@thorsis.com> (Alexander Dahl's message of "Fri, 24 Apr 2026 12:56:27 +0200")
Hi Alexander,
On 24/04/2026 at 12:56:27 +02, Alexander Dahl <ada@thorsis.com> wrote:
> Hei hei,
>
> after few hints in IRC yesterday, I tried to understand why neither
> the ebi driver nor the nand driver are probed, but I failed. See
> below.
Just to be clear, I would not expect the NAND driver to probe "alone",
it is described as a child node of the EBI controller which has its own
compatible. As a result, only the of_platform_populate() at the end of
the probe of the EBI can lead to the NAND controller to probe. The EBI
node being a child node of a "simple-bus", this is the one we should
focus on, because it should be probed.
One reason (trying to be creative) could the that Rob's patch is
dropping an explicit populate that maybe kind of bypasses checks that
the "official" populate does. So maybe there is one resource that is
missing and which is not ignored as it used to be by the core device
driver (likely, dd.c).
Can you enable CONFIG_DEBUG_DRIVER and see in the logs if anything pops
up? Maybe trying to trace (manually) in the core why we do not attempt
to probe the EBI controller by looking for possible conditions to bail
out early. Pinctrl is one of them, so maybe just removing all pinctrl
references in the DT may help troubleshooting this (obviously probe will
fail if pinctrl is incorrect, but if it is attempted we will have a
culprit).
Good luck,
Miquèl
next prev parent reply other threads:[~2026-04-27 15:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 21:06 [PATCH v3 0/3] at91: Remove of_platform_default_populate() calls Rob Herring (Arm)
2026-01-05 21:06 ` [PATCH v3 1/3] mtd: nand: atmel: Defer probe if SRAM is missing Rob Herring (Arm)
2026-01-05 21:06 ` [PATCH v3 2/3] ARM: at91: Move PM init functions to .init_late hook Rob Herring (Arm)
2026-01-05 21:06 ` [PATCH v3 3/3] ARM: at91: remove unnecessary of_platform_default_populate calls Rob Herring (Arm)
2026-04-23 8:24 ` Alexander Dahl
2026-04-24 10:56 ` Alexander Dahl
2026-04-27 15:07 ` Miquel Raynal [this message]
2026-01-10 15:57 ` [PATCH v3 0/3] at91: Remove of_platform_default_populate() calls Claudiu Beznea
2026-01-19 10:21 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tsswfnmy.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=nicolas.ferre@microchip.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox