From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29B34CA101F for ; Fri, 12 Sep 2025 12:53:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KSiuCe8hqpM4azza8GgBa0O2HK79U9r5itgP3WoTyzc=; b=qujxn/jAUenAqdMsQGZWGU67/e aLGPZC4YwzbgYIDZL7pfKzDN+okEMZNGP+RVPju63+LRYJJkJIZC3wmWuTCFluMcvVVj99dfTrtzs U8CCfSeNwd+/1PjO8nnIINdC5LX/Q6sPURW6JryegbjPmq/jvPxvitpEV5S7kQzwZmMmxHDIqCAro 4i3iS9zAo1EHa+v7qqJOzyXhPVa03OVJNkzK/Q5dpsvjp1mZ3HcYqWuU+OqxJV+tlMy3R6AH1jsDo OMrhAf1PRdifbMrGkQbRKyoa91X1F5IpnugKKqWmCi6Y8scG6IYcbL9P63qDVw3x6deo0tRAkkio1 fNJz7eVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ux3HJ-00000009NDI-3NWR; Fri, 12 Sep 2025 12:53:25 +0000 Received: from smtpout-03.galae.net ([185.246.85.4]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ux3HG-00000009NB7-1fu9 for linux-arm-kernel@lists.infradead.org; Fri, 12 Sep 2025 12:53:24 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 953DF4E40A2A for ; Fri, 12 Sep 2025 12:53:19 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 6825A60638; Fri, 12 Sep 2025 12:53:19 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3F26E102F28D5; Fri, 12 Sep 2025 14:53:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1757681598; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=KSiuCe8hqpM4azza8GgBa0O2HK79U9r5itgP3WoTyzc=; b=p29CIcnUXSxrA721IxRLRg8czzKSoTpaBUUhs69MpgvId/e3N19cYYS1Tg0LkRtWuguUWE 71K7MJyLKHdEXUlBsB8AzcvygiMBWLHztSwb61usctXULqksEZQWhZCw9NCxtnZb7/0ICZ +nKDV0cojtyKohHBnyEOONprH4wL1m0KifKq73vOxPJuMiCCx+dF3+eo9C0KNuVdbkTx6m 3lz9YDE2q3li/2Mysyqk+O+kIzv+JvRSQOm6SRvQNyQu5tcUP+y9OpwWuvekOKoQH+wIG6 oY3PBsrvW16Wu4i6THctduVQ7trnN6X/LZJPhdwzyXOYEmJFwD4ulMYcTCdfJQ== From: Gregory CLEMENT To: Josua Mayer , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Wunderlich Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Josua Mayer Subject: Re: [PATCH] arm64: dts: marvell: cn913x-solidrun: fix sata ports status In-Reply-To: <20250911-cn913x-sr-fix-sata-v1-1-9e72238d0988@solid-run.com> References: <20250911-cn913x-sr-fix-sata-v1-1-9e72238d0988@solid-run.com> Date: Fri, 12 Sep 2025 14:53:03 +0200 Message-ID: <87tt17oms0.fsf@BLaptop.bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250912_055322_574198_11F76FBB X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Josua Mayer writes: > Commit "arm64: dts: marvell: only enable complete sata nodes" changed > armada-cp11x.dtsi disabling all sata ports status by default. > > The author missed some dts which relied on the dtsi enabling all ports, > and just disabled unused ones instead. > > Update dts for SolidRun cn913x based boards to enable the available > ports, rather than disabling the unvavailable one. > > Further according to dt bindings the serdes phys are to be specified in > the port node, not the controller node. > Move those phys properties accordingly in clearfog base/pro/solidwan. > > Fixes: 30023876aef4 ("arm64: dts: marvell: only enable complete sata node= s") > Cc: stable@vger.kernel.org > Signed-off-by: Josua Mayer Applied on mvebu/fixes Thanks, Gregory > --- > arch/arm64/boot/dts/marvell/cn9130-cf.dtsi | 7 ++++--- > arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts | 6 ++++-- > arch/arm64/boot/dts/marvell/cn9132-clearfog.dts | 6 ++---- > 3 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/cn9130-cf.dtsi b/arch/arm64/boot= /dts/marvell/cn9130-cf.dtsi > index ad0ab34b66028c53b8a18b3e8ee0c0aec869759f..bd42bfbe408bbe2a4d58dbd40= 204bcfb3c126312 100644 > --- a/arch/arm64/boot/dts/marvell/cn9130-cf.dtsi > +++ b/arch/arm64/boot/dts/marvell/cn9130-cf.dtsi > @@ -152,11 +152,12 @@ expander0_pins: cp0-expander0-pins { >=20=20 > /* SRDS #0 - SATA on M.2 connector */ > &cp0_sata0 { > - phys =3D <&cp0_comphy0 1>; > status =3D "okay"; >=20=20 > - /* only port 1 is available */ > - /delete-node/ sata-port@0; > + sata-port@1 { > + phys =3D <&cp0_comphy0 1>; > + status =3D "okay"; > + }; > }; >=20=20 > /* microSD */ > diff --git a/arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts b/arch/ar= m64/boot/dts/marvell/cn9131-cf-solidwan.dts > index 47234d0858dd2195bb1485f25768ad3c757b7ac2..338853d3b179bb5cb742e975b= b830fdb9d62d4cc 100644 > --- a/arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts > +++ b/arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts > @@ -563,11 +563,13 @@ &cp1_rtc { >=20=20 > /* SRDS #1 - SATA on M.2 (J44) */ > &cp1_sata0 { > - phys =3D <&cp1_comphy1 0>; > status =3D "okay"; >=20=20 > /* only port 0 is available */ > - /delete-node/ sata-port@1; > + sata-port@0 { > + phys =3D <&cp1_comphy1 0>; > + status =3D "okay"; > + }; > }; >=20=20 > &cp1_syscon0 { > diff --git a/arch/arm64/boot/dts/marvell/cn9132-clearfog.dts b/arch/arm64= /boot/dts/marvell/cn9132-clearfog.dts > index 0f53745a6fa0d8cbd3ab9cdc28a972ed748c275f..115c55d73786e2b9265e1caa4= c62ee26f498fb41 100644 > --- a/arch/arm64/boot/dts/marvell/cn9132-clearfog.dts > +++ b/arch/arm64/boot/dts/marvell/cn9132-clearfog.dts > @@ -512,10 +512,9 @@ &cp1_sata0 { > status =3D "okay"; >=20=20 > /* only port 1 is available */ > - /delete-node/ sata-port@0; > - > sata-port@1 { > phys =3D <&cp1_comphy3 1>; > + status =3D "okay"; > }; > }; >=20=20 > @@ -631,9 +630,8 @@ &cp2_sata0 { > status =3D "okay"; >=20=20 > /* only port 1 is available */ > - /delete-node/ sata-port@0; > - > sata-port@1 { > + status =3D "okay"; > phys =3D <&cp2_comphy3 1>; > }; > }; > > --- > base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585 > change-id: 20250911-cn913x-sr-fix-sata-5c737ebdb97f > > Best regards, > --=20 > Josua Mayer > > --=20 Gr=C3=A9gory CLEMENT, Bootlin Embedded Linux and Kernel engineering https://bootlin.com