* [PATCH] ARM: imx: defconfig: Explicitly select CONFIG_PINCTRL
@ 2024-11-26 19:41 Fabio Estevam
2024-11-26 20:59 ` Guenter Roeck
2024-11-28 7:29 ` Esben Haabendal
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2024-11-26 19:41 UTC (permalink / raw)
To: shawnguo; +Cc: esben, linux-arm-kernel, imx, kernel, linux, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
Since commit 17d210018914 ("ARM: imx: Allow user to disable pinctrl"),
the CONFIG_PINCTRL option is no longer implicitly selected, causing
several i.MX SoC pinctrl drivers no longer getting selected by default.
This causes boot regressions on the ARMv4, ARMv5, ARMv6 and ARMv7
i.MX SoCs.
Fix it by selecting CONFIG_PINCTRL inside the affected defconfigs.
Fixes: 17d210018914 ("ARM: imx: Allow user to disable pinctrl")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Closes: https://lore.kernel.org/linux-arm-kernel/49ff070a-ce67-42d7-84ec-8b54fd7e9742@roeck-us.net/
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm/configs/imx_v4_v5_defconfig | 1 +
arch/arm/configs/imx_v6_v7_defconfig | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm/configs/imx_v4_v5_defconfig b/arch/arm/configs/imx_v4_v5_defconfig
index 875c8cdbada7..1af29d12129d 100644
--- a/arch/arm/configs/imx_v4_v5_defconfig
+++ b/arch/arm/configs/imx_v4_v5_defconfig
@@ -83,6 +83,7 @@ CONFIG_I2C_IMX=y
CONFIG_SPI=y
CONFIG_SPI_IMX=y
CONFIG_SPI_SPIDEV=y
+CONFIG_PINCTRL=y
CONFIG_GPIO_SYSFS=y
CONFIG_GPIO_MXC=y
CONFIG_W1=y
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 0beecdde55f5..73f7aa7e75f7 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -204,6 +204,7 @@ CONFIG_SPI_FSL_QUADSPI=y
CONFIG_SPI_GPIO=y
CONFIG_SPI_IMX=y
CONFIG_SPI_FSL_DSPI=y
+CONFIG_PINCTRL=y
CONFIG_PINCTRL_IMX8MM=y
CONFIG_PINCTRL_IMX8MN=y
CONFIG_PINCTRL_IMX8MP=y
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: imx: defconfig: Explicitly select CONFIG_PINCTRL
2024-11-26 19:41 [PATCH] ARM: imx: defconfig: Explicitly select CONFIG_PINCTRL Fabio Estevam
@ 2024-11-26 20:59 ` Guenter Roeck
2024-11-28 7:29 ` Esben Haabendal
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2024-11-26 20:59 UTC (permalink / raw)
To: Fabio Estevam, shawnguo
Cc: esben, linux-arm-kernel, imx, kernel, Fabio Estevam
On 11/26/24 11:41, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Since commit 17d210018914 ("ARM: imx: Allow user to disable pinctrl"),
> the CONFIG_PINCTRL option is no longer implicitly selected, causing
> several i.MX SoC pinctrl drivers no longer getting selected by default.
>
> This causes boot regressions on the ARMv4, ARMv5, ARMv6 and ARMv7
> i.MX SoCs.
>
> Fix it by selecting CONFIG_PINCTRL inside the affected defconfigs.
>
> Fixes: 17d210018914 ("ARM: imx: Allow user to disable pinctrl")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Closes: https://lore.kernel.org/linux-arm-kernel/49ff070a-ce67-42d7-84ec-8b54fd7e9742@roeck-us.net/
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/arm/configs/imx_v4_v5_defconfig | 1 +
> arch/arm/configs/imx_v6_v7_defconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/arm/configs/imx_v4_v5_defconfig b/arch/arm/configs/imx_v4_v5_defconfig
> index 875c8cdbada7..1af29d12129d 100644
> --- a/arch/arm/configs/imx_v4_v5_defconfig
> +++ b/arch/arm/configs/imx_v4_v5_defconfig
> @@ -83,6 +83,7 @@ CONFIG_I2C_IMX=y
> CONFIG_SPI=y
> CONFIG_SPI_IMX=y
> CONFIG_SPI_SPIDEV=y
> +CONFIG_PINCTRL=y
> CONFIG_GPIO_SYSFS=y
> CONFIG_GPIO_MXC=y
> CONFIG_W1=y
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index 0beecdde55f5..73f7aa7e75f7 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -204,6 +204,7 @@ CONFIG_SPI_FSL_QUADSPI=y
> CONFIG_SPI_GPIO=y
> CONFIG_SPI_IMX=y
> CONFIG_SPI_FSL_DSPI=y
> +CONFIG_PINCTRL=y
> CONFIG_PINCTRL_IMX8MM=y
> CONFIG_PINCTRL_IMX8MN=y
> CONFIG_PINCTRL_IMX8MP=y
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: imx: defconfig: Explicitly select CONFIG_PINCTRL
2024-11-26 19:41 [PATCH] ARM: imx: defconfig: Explicitly select CONFIG_PINCTRL Fabio Estevam
2024-11-26 20:59 ` Guenter Roeck
@ 2024-11-28 7:29 ` Esben Haabendal
1 sibling, 0 replies; 3+ messages in thread
From: Esben Haabendal @ 2024-11-28 7:29 UTC (permalink / raw)
To: Fabio Estevam
Cc: shawnguo, linux-arm-kernel, imx, kernel, linux, Fabio Estevam
Fabio Estevam <festevam@gmail.com> writes:
> From: Fabio Estevam <festevam@denx.de>
>
> Since commit 17d210018914 ("ARM: imx: Allow user to disable pinctrl"),
> the CONFIG_PINCTRL option is no longer implicitly selected, causing
> several i.MX SoC pinctrl drivers no longer getting selected by default.
>
> This causes boot regressions on the ARMv4, ARMv5, ARMv6 and ARMv7
> i.MX SoCs.
>
> Fix it by selecting CONFIG_PINCTRL inside the affected defconfigs.
>
> Fixes: 17d210018914 ("ARM: imx: Allow user to disable pinctrl")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Closes: https://lore.kernel.org/linux-arm-kernel/49ff070a-ce67-42d7-84ec-8b54fd7e9742@roeck-us.net/
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Esben Haabendal <esben@geanix.com>
> ---
> arch/arm/configs/imx_v4_v5_defconfig | 1 +
> arch/arm/configs/imx_v6_v7_defconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/arm/configs/imx_v4_v5_defconfig b/arch/arm/configs/imx_v4_v5_defconfig
> index 875c8cdbada7..1af29d12129d 100644
> --- a/arch/arm/configs/imx_v4_v5_defconfig
> +++ b/arch/arm/configs/imx_v4_v5_defconfig
> @@ -83,6 +83,7 @@ CONFIG_I2C_IMX=y
> CONFIG_SPI=y
> CONFIG_SPI_IMX=y
> CONFIG_SPI_SPIDEV=y
> +CONFIG_PINCTRL=y
> CONFIG_GPIO_SYSFS=y
> CONFIG_GPIO_MXC=y
> CONFIG_W1=y
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index 0beecdde55f5..73f7aa7e75f7 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -204,6 +204,7 @@ CONFIG_SPI_FSL_QUADSPI=y
> CONFIG_SPI_GPIO=y
> CONFIG_SPI_IMX=y
> CONFIG_SPI_FSL_DSPI=y
> +CONFIG_PINCTRL=y
> CONFIG_PINCTRL_IMX8MM=y
> CONFIG_PINCTRL_IMX8MN=y
> CONFIG_PINCTRL_IMX8MP=y
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-28 7:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-26 19:41 [PATCH] ARM: imx: defconfig: Explicitly select CONFIG_PINCTRL Fabio Estevam
2024-11-26 20:59 ` Guenter Roeck
2024-11-28 7:29 ` Esben Haabendal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).