From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18FC8C25B7E for ; Fri, 31 May 2024 14:41:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YaQ2bWNB95wRf94HSCUkQ1QPiM7HDgFRWVaAj+L3MK4=; b=q7UTtKVcdzWPE9 V+WJCaZO66W6PGqWxZVVxXgVm6Kjfc4L7o64OR2yyWUHuJQeMdTooMwBX+vxn7nSnk8g48ipiwjlC DUBnIB5nnY2CIslZW9cUB8IdxYBbP887M8SdRkNPHuzPjYfkOrXTbbTDEIsDrTDyXTjVFYiVs0NDI qPw4wV+Z0VH08ge5EAZP+0FiKohOuTGTx4d2zo6D5VzgKknE/UTJY/Qf8eEnEyEYi1p778tgmDY0v iqgMD62mb82uKrlp5+S3mPWH9X+ojyH7iYH9umiWqpHuslbdYPQNn7B+t4aYveO8u6zvkb725c6nP 6YKbtPcr4wwrP2oTAWYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sD3R2-0000000AXlR-3ofO; Fri, 31 May 2024 14:40:48 +0000 Received: from www530.your-server.de ([188.40.30.78]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sD3R0-0000000AXgq-19M0 for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2024 14:40:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=geanix.com; s=default2211; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=ORkr0FUSsLGvEF3bN9w6PBzH9IbyeKtnP6Z+733ED7Y=; b=Un9aMCGoq7Xlcj1SBNXiHqSjhm lI9PFEekR6ylPHyF4JRi5PhFxuD1bobE4LcOc0YeDsfRoANphJqUxriNwwFbxHRbqlSrR+RGV8Nt2 A9ar0J6BiEZssX8lKSwHNwjMcxtZc0lAJj8jA8s0GgbVbQygbFDHEIisraoeC8wRYKKv1ERGgPREN eEzqAVLLYAcAX102DPvmFUTpp59MILbr6i6cXm/WRoCv8nmTTABDkl8+vgKKXvIa+ouJsKKMTjTbY fF78Mmmi2rHWzJ72rGa36D/+jY76JHA0VkNhHV12UvH/GWWylcBeffGQk2o95G0dH1fxWMpDkxQVX 7AjRjxpg==; Received: from sslproxy07.your-server.de ([78.47.199.104]) by www530.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sD3Qk-0007EQ-TF; Fri, 31 May 2024 16:40:30 +0200 Received: from [87.49.42.81] (helo=localhost) by sslproxy07.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sD3Qk-000K1h-29; Fri, 31 May 2024 16:40:30 +0200 From: Esben Haabendal To: Alexander Stein Cc: Shawn Guo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, Rasmus Villemoes , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: ls1021a: add QUICC Engine node In-Reply-To: <5987259.31r3eYUQgx@steina-w> (Alexander Stein's message of "Fri, 31 May 2024 15:09:05 +0200") References: <20240530-arm-ls1021a-qe-dts-v1-1-2eda23bdf8c5@geanix.com> <3380831.44csPzL39Z@steina-w> <87frtynpfx.fsf@geanix.com> <5987259.31r3eYUQgx@steina-w> Date: Fri, 31 May 2024 16:40:29 +0200 Message-ID: <87ttiem4de.fsf@geanix.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Authenticated-Sender: esben@geanix.com X-Virus-Scanned: Clear (ClamAV 0.103.10/27292/Fri May 31 10:31:14 2024) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240531_074046_340348_B4D7C85B X-CRM114-Status: GOOD ( 27.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Alexander Stein writes: > Hi Esben, > > Am Freitag, 31. Mai 2024, 14:20:02 CEST schrieb Esben Haabendal: >> Alexander Stein writes: >> >> + brg-frequency = <150000000>; >> >> + bus-frequency = <300000000>; >> > >> > Mh, aren't these values depending on your actual RCW configuration? >> >> Yes, you are right. The QE bus-frequency comes from platform_clk which >> is controlled by various bits in RCW and sys_ref_clk. >> >> So I guess it should be possible to derive bus-frequency from sysclk >> clock-frequency attribute and RCW. But fsl,qe bus-frequency is a >> required property... >> >> Max bus-frequency for LS1021A is 300 MHz. But it should be possible to >> set it lower, although I suspect that many/most/everyone is running it >> at 300 MHz. > > Thanks for confirmation. I'll let DT maintainer decide how to deal with this. For reference. The existing DTS with fsl,qe have the following bus-frequency property values: arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi: bus-frequency = <200000000> arch/powerpc/boot/dts/fsl/mpc8568si-post.dtsi: bus-frequency = <396000000> arch/powerpc/boot/dts/fsl/mpc8569si-post.dtsi: bus-frequency = <0> arch/powerpc/boot/dts/fsl/p1021si-post.dtsi: missing! arch/powerpc/boot/dts/fsl/t1024si-post.dtsi: bus-frequency = <0> arch/powerpc/boot/dts/fsl/t1040si-post.dtsi: missing! arch/powerpc/boot/dts/kmeter1.dts: bus-frequency = <0> arch/powerpc/boot/dts/mpc836x_rdk.dts: bus-frequency = <0> arch/powerpc/boot/dts/mpc832x_rdb.dts: bus-frequency = <198000000> The 3 non-zero values are most likely also not guaranteed by SoC design to always be the right values. But I haven't checked. >> >> + fsl,qe-num-riscs = <1>; >> >> + fsl,qe-num-snums = <28>; >> > >> > Current bindings defines: >> >> fsl,qe-snums: This property has to be specified as '/bits/ 8' value, >> >> defining the array of serial number (SNUM) values for the virtual >> >> threads. >> > >> > So '/bits/ 8' is missing. >> >> Ok, so you want me to add an array for fs,qe-snums attribute? >> None of the existing fsl,qe devices has a fsl,qe-snums. >> And qe_snums_init() has a fallback, so I don't think it is correct to >> specify fsl,qe-snums to be a required property in the bindings. It >> should be listed as optional. > > fsl,qe-num-snums is a deprecated property, so IMHO the replacement > fsl,qe-snums should be used instead for new device tree entries. > qe_snums_init() supporting 'fsl,qe-num-snums' is just to support > "legacy bindings" as stated in the comment. Figuring out the correct array values for fsl,qe-snums for ls1021a is not so easy. It is not so clear from the reference manual, what it should be. And the default array used for fsl,qe-num-snums = <28> does not look right in any way, but seems to work. It would not feel right to just copy those values and put into DTS, as it would imply that the values are truly a correct description for the LS1021A hardware. >> >> >> + }; >> >> + >> >> + muram@10000 { >> >> + #address-cells = <1>; >> >> + #size-cells = <1>; >> >> + compatible = "fsl,qe-muram", "fsl,cpm-muram"; >> >> + ranges = <0x0 0x10000 0x6000>; >> > >> > Node address but no 'reg' property? I have no idea if this is okay. >> > Also compatible (and possibly reg) first. >> >> It is done in the same way for all existing fsl,qe-muram devices. So if >> it is not okay, a tree-wide fixup would be in place. > > I can't finally say if this is okay, but at least the compatible shall be > listed first. Done. /Esben _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel