Re: [PATCH net] net: stmmac: Fix EST offset for dwmac 5.10

From: Kurt Kanzenbach <kurt@linutronix.de>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rohan G Thomas <rohan.g.thomas@intel.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net] net: stmmac: Fix EST offset for dwmac 5.10
Date: Tue, 20 Feb 2024 10:44:57 +0100	[thread overview]
Message-ID: <87ttm3wjty.fsf@kurt.kurt.home> (raw)
In-Reply-To: <mmjrlyzhegve5u3s3lhw4hmhooxixn3pwxkkdikxgxno4teqyz@rtetljwg6ffg>

[-- Attachment #1.1: Type: text/plain, Size: 1604 bytes --]

On Tue Feb 20 2024, Serge Semin wrote:
> Hi Kurt
>
> On Tue, Feb 20, 2024 at 09:22:46AM +0100, Kurt Kanzenbach wrote:
>> Fix EST offset for dwmac 5.10.
>> 
>> Currently configuring Qbv doesn't work as expected. The schedule is
>> configured, but never confirmed:
>> 
>> |[  128.250219] imx-dwmac 428a0000.ethernet eth1: configured EST
>> 
>> The reason seems to be the refactoring of the EST code which set the wrong
>> EST offset for the dwmac 5.10. After fixing this it works as before:
>> 
>> |[  106.359577] imx-dwmac 428a0000.ethernet eth1: configured EST
>> |[  128.430715] imx-dwmac 428a0000.ethernet eth1: EST: SWOL has been switched
>> 
>> Tested on imx93.
>> 
>> Fixes: c3f3b97238f6 ("net: stmmac: Refactor EST implementation")
>> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
>> ---
>>  drivers/net/ethernet/stmicro/stmmac/hwif.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c b/drivers/net/ethernet/stmicro/stmmac/hwif.c
>> index 1bd34b2a47e8..29367105df54 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/hwif.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c
>> @@ -224,7 +224,7 @@ static const struct stmmac_hwif_entry {
>>  		.regs = {
>>  			.ptp_off = PTP_GMAC4_OFFSET,
>>  			.mmc_off = MMC_GMAC4_OFFSET,
>> -			.est_off = EST_XGMAC_OFFSET,
>> +			.est_off = EST_GMAC4_OFFSET,
>
> Unfortunate c&p typo indeed. Thanks for fixing it!

No problem. I was just wondering why the confirmation message doesn't
show up after updating to v6.8-RT :-).

Thanks,
Kurt

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel