From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6A9CC48BC4 for ; Tue, 20 Feb 2024 09:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mP/EXtNRbg4JSLiURBWPyPdsrKYUAg70DCweBI+Lg3o=; b=yjXpiO8yUgudRbUprku3hoEkCz gnYAmq+K3mS6t+lpPVvaWoTF7/8zP53GxGJn5G3feb8wJPyuJNPXN4L/zTR53x0XGNO340beEeKc7 j8xQqJgH2oiChMeeoTmTECasfEpGZ0HrqKOKe5ZWxwkhemBldPjJPX89Dkg9zEZA+FdI7PvOG2AmL peFmoYf6MF/xN+5FEXjFPav8z75DfMvmwXZa7ntWQFSgjb2+F1ViKIZL5YgWYmI+YmtOIj2i76wEe m4nJOAUYXDCkk9o78TLRV5fQnQ1OIT5rrr83MbnD72l0UPW7ZKfd8L6G2k6Ir/S1rasF5OQ5QlzBI GIyKqyGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcMgY-0000000E4Vy-09dQ; Tue, 20 Feb 2024 09:45:10 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcMgQ-0000000E4Rm-3biw for linux-arm-kernel@lists.infradead.org; Tue, 20 Feb 2024 09:45:08 +0000 From: Kurt Kanzenbach DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1708422299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0IOZw6hyqiMqx4EefUlP36lkvuV/22XmEQa54rFkuug=; b=hnEuLAHnE35zRzIKCohcn8gnB/h12LULynfKsxpr97CogKyO26g5Z+AwjtoBLtne01WvW1 W0wP9Idd+jr74lq8ogajkpHodAmursLOqj8+vkqPAGDrUo98RcZ7Hxy+Gl35hQbeBzJP5m 5cQmhW/HdZhi47TAF7kbjyU1p9Kpl4A502wLvIaTC9rm5ES/g0gIpNLSrb9xiojIJkdrhB 5kTXcLXdPlWAxpd9Dw83qv7/KiNUVr/Ym7WHB1TAfr6sq3MvBFsLLgeG3KsF+5BiYPPFGK EX46b6+LL8Kp9h/Hj+zdsbq9kKcs3V5Xvu9zglOH6qn3SWJEXG3pUBiKOMI7bg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1708422299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0IOZw6hyqiMqx4EefUlP36lkvuV/22XmEQa54rFkuug=; b=uuKrjn6dTnGMOlTvKs6676TlXRz1fM26Uzpz5QUWhv2bNCeL/A/Y+8EZuxjhEXVtefHfAW /NtYsJlYYV2jdLAQ== To: Serge Semin Cc: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Andy Shevchenko , Rohan G Thomas , Sebastian Andrzej Siewior , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net] net: stmmac: Fix EST offset for dwmac 5.10 In-Reply-To: References: <20240220-stmmac_est-v1-1-c41f9ae2e7b7@linutronix.de> Date: Tue, 20 Feb 2024 10:44:57 +0100 Message-ID: <87ttm3wjty.fsf@kurt.kurt.home> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240220_014503_069645_58D70F5C X-CRM114-Status: GOOD ( 15.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8268418451069162416==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8268418451069162416== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue Feb 20 2024, Serge Semin wrote: > Hi Kurt > > On Tue, Feb 20, 2024 at 09:22:46AM +0100, Kurt Kanzenbach wrote: >> Fix EST offset for dwmac 5.10. >>=20 >> Currently configuring Qbv doesn't work as expected. The schedule is >> configured, but never confirmed: >>=20 >> |[ 128.250219] imx-dwmac 428a0000.ethernet eth1: configured EST >>=20 >> The reason seems to be the refactoring of the EST code which set the wro= ng >> EST offset for the dwmac 5.10. After fixing this it works as before: >>=20 >> |[ 106.359577] imx-dwmac 428a0000.ethernet eth1: configured EST >> |[ 128.430715] imx-dwmac 428a0000.ethernet eth1: EST: SWOL has been swi= tched >>=20 >> Tested on imx93. >>=20 >> Fixes: c3f3b97238f6 ("net: stmmac: Refactor EST implementation") >> Signed-off-by: Kurt Kanzenbach >> --- >> drivers/net/ethernet/stmicro/stmmac/hwif.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c b/drivers/net/et= hernet/stmicro/stmmac/hwif.c >> index 1bd34b2a47e8..29367105df54 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/hwif.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c >> @@ -224,7 +224,7 @@ static const struct stmmac_hwif_entry { >> .regs =3D { >> .ptp_off =3D PTP_GMAC4_OFFSET, >> .mmc_off =3D MMC_GMAC4_OFFSET, >> - .est_off =3D EST_XGMAC_OFFSET, >> + .est_off =3D EST_GMAC4_OFFSET, > > Unfortunate c&p typo indeed. Thanks for fixing it! No problem. I was just wondering why the confirmation message doesn't show up after updating to v6.8-RT :-). Thanks, Kurt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCgAxFiEEvLm/ssjDfdPf21mSwZPR8qpGc4IFAmXUdJkTHGt1cnRAbGlu dXRyb25peC5kZQAKCRDBk9HyqkZzgkDMEACpywx0fzS87yvO1q6df6W3FbGVVYuB Ius17j0DnWupFElYtSbJvmOjHI9wI2j1aOBSbqSOdTTxEsYR2XWvfmlgH57WOfBB oz4JPnfjV8P3rb6nlXcqOeWlultJg2ee7P4/P9kbDeEkSRb6KOArkjBxkQT99oLS wNaqPjboXyO50ZDR2lrZqjjQWCSg8uHKt70vMfxCOra/ENiMRM/oNBb1ZQj02XcP 5rN3bKJGiwuyjFvLZUmWnvmI9KYRErEHtuoN+SThdPZzvLATJQxMM0b4YT53wUHf 5ATVgFvF/slTVh8OR5b/9K9Io17hpESubQN293JVK7Ja2kNMjmahvZaS3LvXlJu0 e9QqVHQsMgHdhp0QrBCalGvRY8wow4bJ+41IaJdGYSsoqOJBFEYNCj/EWjTdovz7 uQ0qeNJaaAz82ZGF4816jVrFY3b/nkTm/eI4YzFnl6IKTiRkxvDbm7/ER0XWel+e huh420Nt7km7Xcs8t0pSYur2hE8YH/lh595iW7032llm4SuxpdDDKlgVYmVtoXUW /lQLtrLiaXYEDE3HjmBrCQb14Wbc4WL2cdgqcakKfHRrWvezXICvcFGsHhCUMPDu VGNXo8iO9bWdmuzwDHe/Yt1Ujq/8ZQsP2C0/2PZYejdXBNQJuzhypdur8WTFqul8 GKydbDv/RnY8Bg== =08hW -----END PGP SIGNATURE----- --=-=-=-- --===============8268418451069162416== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8268418451069162416==--