From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10EAAEB64DA for ; Wed, 5 Jul 2023 08:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=klT1kQKqlAZ08xwsWXnt/YC6PxxwFTISSpQk2Uv/4uA=; b=CqDQWtbE1rzTLV fNhSBVJRW/pBakdaMIS90SufOGnr4ESUfFWbw8Uo+NUvnIF7lEU7ql5ZH9LCYkLmZooCIeqYUOpoM NHoLjyF92ntMnWVivxgal9HnwBAYbtzwrrqMf4aw+yHXpVTwJsGU/dNtQ5k2RKwFdirmAd+nARaNl 9ljl3xnJDMfza2NL9okBTUa3ROEE7S9JorC0LbZxTIWzu7XqwioRPNNueDW/puhOJeQZWFNjBSvZw Wl+BcqyZfEqPC5Sp3HbfUX4fC591M7QqjgZJl2ADRjdvti93jGwhn9bGGX4nPMCqhMZTdRPjxTKbG Ik+ztQ8uWRMPBJ8U1qXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGy29-00FEue-1r; Wed, 05 Jul 2023 08:38:45 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGy27-00FEuA-0H for linux-arm-kernel@lists.infradead.org; Wed, 05 Jul 2023 08:38:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688546321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0ev84vUzUh8ZH6f1TjRoMQmaeXWVKy1q8JlkhwPTuuw=; b=exayaQU91EgNRg7GnxVsaQMQXSbO188I4KgVnldf2vu7netbLD9AkaDXAGQ3bRWpubwZVj +ssXMDuikz03jZZaitO1cIBMzRSdqmf1brH5Ff0HuoJ4+537y3mpp47QV0rX1eWJzZJ/J4 56s3lw6vRFksgKIgatqLNqX06mk2o0M= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-103-yHYlV6yDObWQJewbWNV7Ow-1; Wed, 05 Jul 2023 04:38:38 -0400 X-MC-Unique: yHYlV6yDObWQJewbWNV7Ow-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-4fab61bb53bso6444782e87.0 for ; Wed, 05 Jul 2023 01:38:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688546317; x=1691138317; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0ev84vUzUh8ZH6f1TjRoMQmaeXWVKy1q8JlkhwPTuuw=; b=eiwkjq/u7Y8vnT/53tiau6BzSDRgC4w5FXg9RaJ6WGO9jcdMhhQTT8m/ETEHPfpnZp PcV2Mt/pCOsPWbal3pLoXfMBkFB9tT5wgVLqzID6LgZSbFppnLUGI0GAwrhfufefPtTs RNOuBJNuCXM9hEegff3dfEeozCdpIYiUydP2MhL+yXgRIIn9Pem1VKMNgc0Lt0EunOFM DPXbzfEhHoAnub1ayCi8AexK7LCQeyg9OgyLms4fDTkZJpvQ6qRrmQ/pu5uQtGJqN1+y n0pnV7abyUVWtOKvxTKWHc4S/xNqU+2RtqnLmcO5BEl9I5eopAMTY0W8ifkapk5x9LpZ L0Gg== X-Gm-Message-State: ABy/qLamPlVLU+87PAotwop7lyY/olteOSWCiaA0s2EC7JoCdkSI43cB WY6QtH86uA7Ik6ZBje1m/FUeGdK1CWVA/YBtQBzTZkF3FAbHdhEjeyeC5WMjeRQE9+AWpNoO12s jTwV2pKJKoPyhm5LInzB2wfB9znYSobcH+o8= X-Received: by 2002:a05:6512:2211:b0:4fb:8948:2b2b with SMTP id h17-20020a056512221100b004fb89482b2bmr14099214lfu.48.1688546317008; Wed, 05 Jul 2023 01:38:37 -0700 (PDT) X-Google-Smtp-Source: APBJJlHw/8+9xxPRw7DNATPC6lakSSCvVuMDKfqLB9aRt/ZUrBO5oK9Z8Als1e5OzgdL2qBEpY21lQ== X-Received: by 2002:a05:6512:2211:b0:4fb:8948:2b2b with SMTP id h17-20020a056512221100b004fb89482b2bmr14099194lfu.48.1688546316638; Wed, 05 Jul 2023 01:38:36 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id m3-20020a056000180300b003141e9e2f81sm14564718wrh.4.2023.07.05.01.38.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 01:38:36 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , maarten.lankhorst@linux.intel.com, mripard@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-fbdev@vger.kernel.org, Thomas Zimmermann , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar Subject: Re: [PATCH 05/10] drm/exynos: Use fbdev DMA helpers In-Reply-To: <20230704160133.20261-6-tzimmermann@suse.de> References: <20230704160133.20261-1-tzimmermann@suse.de> <20230704160133.20261-6-tzimmermann@suse.de> Date: Wed, 05 Jul 2023 10:38:35 +0200 Message-ID: <87ttuirbw4.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230705_013843_223973_819A1292 X-CRM114-Status: GOOD ( 11.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thomas Zimmermann writes: > Use fbdev's DMA helpers for fbdev emulation. They drivers previously s/They/The > used the I/O-memory helpers, while allocating DMA-able system memory. > This could (in theory) result in bus errors from accessing the memory > range. > > This bug has been present since the exynos driver was first added. > > Signed-off-by: Thomas Zimmermann > Fixes: 1c248b7d2960 ("DRM: add DRM Driver for Samsung SoC EXYNOS4210.") Wonder the value of this "Fixes:" tag since this patch depends on the DMA helpers introduced in 1/10? I would just drop it, since it might confuse the different kernel stable scripts that attempt to backport by looking at this tag. As you said, it has been present from the beginning of this driver. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel