From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 486A6C352A1 for ; Wed, 7 Dec 2022 19:21:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/rScH8rfXEbINjcG48dSbRyVHPOXYCKScHvge5eiXeE=; b=oFX8Q35olxS4vD 6bUC6caT2L9DhX1g0/2nvWCCcSSfZ9i0QL4cvwm3yc6N84qtpIamh6a6zI45vwaNDFO1vQshQA8I4 we28anM2ncxULi88wcyLAlZuN0gtxcXwdrLM3NgLgAi9rTwD4QvErXIZ7bjCjLhWoGNLTgo3t18nK wGWSGBxzj1rbcGLdYl+O9266MQXd0EXeejAzGUStuP/f2XshX4gJZjOI72Dx55vBwnsE0u12gAYYl fw4tpo7CIzMSVjpKqwRy5Tr7ZA308dQND5JiyT1rH0MT5xKMR7XnRv2Mrh6hhMgsp4d1BisQ5nqnO HAdLD4E+0oFiwLaId/oA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2zxy-00AfzX-IN; Wed, 07 Dec 2022 19:20:26 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2zxu-00Afuo-3h for linux-arm-kernel@lists.infradead.org; Wed, 07 Dec 2022 19:20:23 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9D399B82055; Wed, 7 Dec 2022 19:20:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CD7EC4314C; Wed, 7 Dec 2022 19:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670440818; bh=sC3n0vgIAD3Um2bOLbnl9qG5sDLm9eN8+gQ1hvWU04Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TdOUWGVjzfTCGVA7XDXJx6UTVzUmxOVgsINex6CYWK5PAjqmvbuoLjn3XTPIGcdVF sPRyKts7Nm5sDPgSltWZVu5ITOCiMBb7cg4Jm8ETKZ85xbpNysbbEaYgH4XfH1KRSW vu1YFdhnzOxsVvkgq26BajJRI7nlRMr0yTVOslmhVPjAs7A8+SXfESv24yiYkQ3kRw CB1wlZ0CWBs5XTKoe1pzc2RUlmMKhUcheymb3MYYZ9uhNJ0C7JHMpMwI8/Ff+h6dA8 +Tyesrn+LdtS+qSyclT/LFaSMCa9jRs0KYy8hITOM2jZH4VtPJMiFfEaEu7ibgdQ8H tm6FZnyATVefg== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p2zxo-00BBqo-AA; Wed, 07 Dec 2022 19:20:16 +0000 Date: Wed, 07 Dec 2022 19:18:35 +0000 Message-ID: <87tu27rpis.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Mark Rutland , Sami Mujawar , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v2 04/14] arm64/sysreg: Add definitions for immediate versions of MSR ALLINT In-Reply-To: References: <20221112151708.175147-1-broonie@kernel.org> <20221112151708.175147-5-broonie@kernel.org> <86wn75ls9u.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: broonie@kernel.org, catalin.marinas@arm.com, will@kernel.org, lpieralisi@kernel.org, mark.rutland@arm.com, Sami.Mujawar@arm.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221207_112022_455497_4F72374D X-CRM114-Status: GOOD ( 27.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 05 Dec 2022 17:11:38 +0000, Mark Brown wrote: > > [1 ] > On Mon, Dec 05, 2022 at 04:38:53PM +0000, Marc Zyngier wrote: > > Mark Brown wrote: > > > > } > > > + > > > #endif > > > Spurious change? > > Yes. > > > > +++ b/arch/arm64/include/asm/nmi.h > > > @@ -0,0 +1,18 @@ > > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > > > +static __always_inline void _allint_set(void) > > > +{ > > > + asm volatile(__msr_s(SYS_ALLINT_SET, "xzr")); > > > +} > > > If this *really* must be a separate include file, it should at least > > directly include its dependencies. My gut feeling is that it would be > > better placed in daiflags.h. > > Yeah, I was swithering on that. Some versions of the code have had more > in here at which point having the separate header made more sense. I > think part of the problem here is that we should do some combination of > renaming daifflags.h or layering an a more abstracted API on top of it, > putting things that are not DAIF into daifflags.h doesn't feel great. > > > > @@ -126,6 +126,8 @@ > > > * System registers, organised loosely by encoding but grouped together > > > * where the architected name contains an index. e.g. ID_MMFR_EL1. > > > */ > > > +#define SYS_ALLINT_CLR sys_reg(0, 1, 4, 0, 0) > > > +#define SYS_ALLINT_SET sys_reg(0, 1, 4, 1, 0) > > > This only covers the immediate versions of ALLINT, and misses the > > definition for the register version, aka sys_reg(3, 0, 4, 3, 0). > > That is already present upstream, we only need to add the immediate > versions which the generated header stuff doesn't have any model for > yet. Ah, missed that one, thanks. Out of curiosity, what is missing in the generator to deal with this stuff? M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel