From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F96DC433EF for ; Fri, 17 Jun 2022 14:14:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W2f/w9G1SlRjT6thaRdfF36hvZaDNm1S+thnPmgbJPQ=; b=UeNzkdhFCP2pQ7 A47D4C6/IAJaKJLMXWv/tE7UlNtnLePfO/oUMQoPEIWrJ/DyGk0LeaWvYjz3FsfzccxFgki9JQsEo PgmVsm1DaXO2aVJzGu4BsE5EHNQi6eBHzCwjKxCj6PT9jYrIYHbW4h4f/n5C2W8YPP7MGu6wIu4jk GcJgy+HAwjQY1lsqn6LPQfXI6ZCt5IpqvqpdhCqxVrU3mIiUe2FuN6okZm3mOwSAqHHf3/FHaZk+i wtpMw9OS3TvLgKACZVQGbJ/yOOyCjBbnUHepLPXyotF36wnGB/lNjTIkFt+K/D1RjoLbOmvzY7xuY 7z7ZPIyKoTYMQOW1uGGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2CjG-007wMm-Vn; Fri, 17 Jun 2022 14:13:43 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2CjC-007wKc-TF for linux-arm-kernel@lists.infradead.org; Fri, 17 Jun 2022 14:13:41 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 045B0B82A3E; Fri, 17 Jun 2022 14:13:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B32ABC3411B; Fri, 17 Jun 2022 14:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655475215; bh=pgY6pJFRbTzMiMKyNxAvRDljF0tAfDbdjsgf1wsJqSg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XPxlOo7KlwiHE77eE8iKfg2EsBttTrQgQnQdgMoMioo+ASB/iyF8PnhVFZ/dlNZMd eYaBfVdhUe15uT96JV0NKrvJzEbuEiHtMDSLUF63Hxsl6hxq3fsYSGE0dndRQruWp3 tDPUJONpdsRrdPIe51sJ0hAVI199+QjYqOkEaBJ2ROi3SXLr8YppnfDPhbM1p9TSQ9 kfoz+v9rCMs2ICozr6gVJd37oZFVyCkE5HWFYJz8TSKOASew5rHUIyMBIo8jfgQ7MH HA9h59ZpofdReyndBwDD7EiQtMBdaQ6TTKjFoLC1qjcesrEQSX8ibB0/UAUXR/KkVV gd6d1J0c/EkeQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1o2Cj7-001JaH-OS; Fri, 17 Jun 2022 15:13:33 +0100 Date: Fri, 17 Jun 2022 15:13:33 +0100 Message-ID: <87tu8j2x9u.wl-maz@kernel.org> From: Marc Zyngier To: Matt Ranostay Cc: , , , Robin Murphy , Nishanth Menon Subject: Re: [PATCH v2] arm64: dts: ti: k3-j721s2: fix overlapping GICD memory region In-Reply-To: <20220617140207.444298-1-mranostay@ti.com> References: <20220617140207.444298-1-mranostay@ti.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: mranostay@ti.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robin.murphy@arm.com, nm@ti.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220617_071339_135655_419CB3D8 X-CRM114-Status: GOOD ( 17.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 17 Jun 2022 15:02:07 +0100, Matt Ranostay wrote: > > GICD region was overlapping with GICR causing the latter to not map > successfully, and in turn the gic-v3 driver would fail to initialize. > > This issue was hidden till commit 2b2cd74a06c3 ("irqchip/gic-v3: Claim iomem resources") > replaced of_iomap() calls with of_io_request_and_map() that internally > called request_mem_region(). Please correctly wrap long lines in the commit message. > > Respective console output before this patchset: > > [ 0.000000] GICv3: /bus@100000/interrupt-controller@1800000: couldn't map region 0 > > Fixes: 2b2cd74a06c3 ("irqchip/gic-v3: Claim iomem resources") No, that's the wrong target for this. Your patch fixes the *original* submission of the DT, and this should carry a: Fixes: b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC") Please also consider adding a Cc: stable@vger.kernel.org Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel