From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34EB0C433F5 for ; Mon, 8 Nov 2021 11:10:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E57C061352 for ; Mon, 8 Nov 2021 11:10:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E57C061352 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wsirUf9aq1HyYxrOLYnD66OwX2Ja8u4tFkBUxBI2hoA=; b=KZErB67d9oLiGC uoo9T50K9jE+fCW72r9lsCExuw42qxfc+XkpSjOMkmIYj+2HOvsAMddERU05IkOAHa8qZg5HwWUk2 k7gFzTlUp+lQc932Xz4hv6GAahRfrZAwNeuozcllxEKV4dUsPxmQXu69bmH3yOyEAlRep3IcXjpJp jWwugcdvNH6JwYBhieeYOig8hnanWN90QqEnlMd170Bafa+uqqHdlXvbj69xU8s8zEzdM1VYNyiWz j6mF9ldsIqBwLQrQkje4gumYT1o2rKE1/r4tIJdbh/lLRRwnFzjUUome/bna3TACoNxqrV7BvJZUj Nx1f5+KmOBhzeqGCT+iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mk2WX-00GEfK-6b; Mon, 08 Nov 2021 11:09:13 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mk2WS-00GEe3-Vg; Mon, 08 Nov 2021 11:09:10 +0000 Received: (Authenticated sender: gregory.clement@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 8348424000F; Mon, 8 Nov 2021 11:09:05 +0000 (UTC) From: Gregory CLEMENT To: Andy Shevchenko , Andy Shevchenko , Bartosz Golaszewski , Jianqun Xu , Linus Walleij , Sai Krishna Potthuri , Andrew Morton , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Cc: Bamvor Jian Zhang , Andrew Lunn , Sebastian Hesselbarth , Heiko Stuebner , Patrice Chotard , Michal Simek , Andy Shevchenko Subject: Re: [PATCH v1 12/19] pinctrl: armada-37xx: Switch to use devm_kasprintf_strarray() In-Reply-To: <20211105124242.27288-12-andriy.shevchenko@linux.intel.com> References: <20211105124242.27288-1-andriy.shevchenko@linux.intel.com> <20211105124242.27288-12-andriy.shevchenko@linux.intel.com> Date: Mon, 08 Nov 2021 12:09:05 +0100 Message-ID: <87tugmsy3y.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_030909_186345_B9200369 X-CRM114-Status: GOOD ( 17.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Andy, > Since we have a generic helper, switch the module to use it. > > As a side effect, add check for the memory allocation failures and > cleanup it either in error case or when driver is unloading. > > Signed-off-by: Andy Shevchenko Reviewed-by: Gregory CLEMENT Thanks, Gregory > --- > drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > index f48745c43419..08cad14042e2 100644 > --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > @@ -23,6 +23,7 @@ > #include > #include > #include > +#include > > #include "../pinctrl-utils.h" > > @@ -951,6 +952,7 @@ static int armada_37xx_pinctrl_register(struct platform_device *pdev, > struct pinctrl_desc *ctrldesc = &info->pctl; > struct pinctrl_pin_desc *pindesc, *pdesc; > struct device *dev = &pdev->dev; > + char **pin_names; > int pin, ret; > > info->groups = pin_data->groups; > @@ -969,11 +971,14 @@ static int armada_37xx_pinctrl_register(struct platform_device *pdev, > ctrldesc->pins = pindesc; > ctrldesc->npins = pin_data->nr_pins; > > + pin_names = devm_kasprintf_strarray(dev, pin_data->name, pin_data->nr_pins); > + if (IS_ERR(pin_names)) > + return PTR_ERR(pin_names); > + > pdesc = pindesc; > for (pin = 0; pin < pin_data->nr_pins; pin++) { > pdesc->number = pin; > - pdesc->name = kasprintf(GFP_KERNEL, "%s-%d", > - pin_data->name, pin); > + pdesc->name = pin_names[pin]; > pdesc++; > } > > -- > 2.33.0 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel