From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DDAEC433EF for ; Tue, 5 Oct 2021 13:44:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 146B761244 for ; Tue, 5 Oct 2021 13:44:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 146B761244 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rJUfacwkXiZYbtZkvaMM4bYx3tQMEqVjWmwFHPJDOGM=; b=NHUg4YL8z+r9Nl Acvg/lw7TMcm/sHqd4gd4nG8njBBeyoG04RqN/qpdCI60t3tSSpWmP8nX4wAcvLynEcp4QB44ELFb v+XwctRrdyDE2sPVY2Zfu3BOvpbqmsAwG5Eyd0C3MWMEaBM5jEjNiX+6VLCetDKmZ0NaTnx+1lJyn OvP4S9pJIX3/sRqBUAVRePIfqVMLd5ZhGVoQZxW38ebF7dU95kKf7g+sMHaNlq2zB9iVH+xz9C7CH ZnApxmFw9SV7kcuJXWIV4dv3hpZ4XaDb05jmHaYJxQO0BCHrVRFEwxXOn/5b0VH4cp1jDbSzMZ8BK 9d7McY0ZRONjL8CuyYqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXkiH-00AbzH-VU; Tue, 05 Oct 2021 13:42:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXkiE-00Abyc-QI for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 13:42:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DC89E1FB; Tue, 5 Oct 2021 06:42:28 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E6D8F3F70D; Tue, 5 Oct 2021 06:42:24 -0700 (PDT) From: Valentin Schneider To: Peter Zijlstra , Tim Chen Cc: Vincent Guittot , Barry Song <21cnbao@gmail.com>, Dietmar Eggemann , LKML , Ingo Molnar , Aubrey Li , Borislav Petkov , Daniel Bristot de Oliveira , Ben Segall , Catalin Marinas , Greg Kroah-Hartman , Guodong Xu , "H. Peter Anvin" , Jonathan Cameron , Juri Lelli , "Cc\: Len Brown" , ACPI Devel Maling List , LAK , Linuxarm , Mark Rutland , Mel Gorman , msys.mizuma@gmail.com, "Zengtao \(B\)" , "Rafael J. Wysocki" , Steven Rostedt , Barry Song , Sudeep Holla , Thomas Gleixner , "Rafael J. Wysocki" , Will Deacon , x86 , yangyicong Subject: Re: [PATCH RESEND 0/3] Represent cluster topology and enable load balance between clusters In-Reply-To: <20211005075001.GJ4323@worktop.programming.kicks-ass.net> References: <20210924085104.44806-1-21cnbao@gmail.com> <20211005075001.GJ4323@worktop.programming.kicks-ass.net> Date: Tue, 05 Oct 2021 14:42:17 +0100 Message-ID: <87tuhvlhae.mognet@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_064230_924651_BCA8449B X-CRM114-Status: GOOD ( 13.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/10/21 09:50, Peter Zijlstra wrote: > On Fri, Oct 01, 2021 at 04:22:46PM -0700, Tim Chen wrote: >> On Fri, 2021-10-01 at 16:57 +0200, Peter Zijlstra wrote: > >> > The one questino I have is, do we want default y? >> >> I also agree that default y is preferable. > > I'll change at least the x86 one to: > > default y > depends on SMP > Huh, so the arm64 SCHED_{SMT,MC} configs are defaultless (I added SCHED_SMT to arm64's defconfig not so long ago), but x86 has them default y, which I'm thinking is a tad better, and would be nice to harmonize. Unfortunately different architectures have their own dependency requirements - arm has ARM_CPU_TOPOLOGY, parisc has PARISC_CPU_TOPOLOGY... Would you hate making SCHED_* a "generic" config, with a common default and help text, and punt the arch specific stuff to an ARCH_SUPPORTS_* knob? Something like: arch/arm/Kconfig: select ARCH_SUPPORTS_SCHED_MC if ARM_CPU_TOPOLOGY init/Kconfig: config SCHED_MC def_bool y depends on ARCH_SUPPORTS_SCHED_MC && SMP _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel