From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77401C433EF for ; Mon, 27 Sep 2021 18:20:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37BE860F11 for ; Mon, 27 Sep 2021 18:20:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 37BE860F11 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ydnPfJ3pMZ0gDxbP/oIIDTASZzTzU2aW0afuds1CWlo=; b=PF2vABZuJsXTzx 5YnC6njPfA3CKlkILhhXkgza4emVVC2MDdc+YHSvkOT2i/P7+s6SQn69VnEoQZxdVqqse7bSi4IbG HcUkmG1+n/rGBmFiQISxvjeOo7ZhujC7doxI0RCTh9c1a7WLzO08XZhzVOZ81piFJUkM1yoyFCFcQ /GZ0AMcQKrqu/9PRXCRUDKkNmfLbLuDGPkWgLPqSGOlpeeqaxSudp+1ou9BzSBMSN83AvOSAQcgjY Oh7R3SgaYYi8fjPuK9cYGsmBdfWrPLcZ4vUeycwZz5a9DBCkkYMcSHLkMT2SbOal8QIy32JXnUcfl VLTW7dMeZoLwhvw5zl3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUvDB-003l7f-Ih; Mon, 27 Sep 2021 18:18:45 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUvD7-003l6A-NX for linux-arm-kernel@lists.infradead.org; Mon, 27 Sep 2021 18:18:43 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1632766716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CMYV0yIsOtj4fMiy4VosAZYi9HZ7pXiZjifQ1Yu1Prk=; b=ruqru5DUfPQHCSSvmad3d6lsxiYORgcdFhRNGeVySerSuSO4vPUfVqZZ9LNL9KTKc4WzSY Upn7RMdIQru3XEFn1x69F/m5vSI9//LqPDIb0ADmh/mTXU79wCoDLUn8c9kf6URJF2NZvf lG2tbOeoDR/nLOjZkL0BYtVSVcVLvLZPjPqQpiM4dFUrBI6JidzO62YWMo9nDjsGAH2I3t NgMNInQJxge86aMYhPjKeWyOiW/92GLX7NZ1wxt6O74D3QUQhbrE9Inh9c+tez56coSw3G hFFjZctcl9ZbjYNvxpForZ/nyTKrta4OcFK5TXsWRa2Pk2ib3a22dcuJSv15aA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1632766716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CMYV0yIsOtj4fMiy4VosAZYi9HZ7pXiZjifQ1Yu1Prk=; b=ntC20B/zQ9HRCnABj2abMrdgxN94DOPuojjgK2tBuRN2V6DiKd6tkfoF9J8qhxFm4icjlB i+j+Y7afwFDIweDQ== To: Florian Fainelli , Marc Zyngier Cc: linux-kernel@vger.kernel.org, Russell King , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Catalin Marinas , Will Deacon , Yoshinori Sato , Rich Felker , Rob Herring , Frank Rowand , Ard Biesheuvel , Mike Rapoport , Linus Walleij , Andrew Morton , Geert Uytterhoeven , Arnd Bergmann , Guenter Roeck , Kefeng Wang , Mark Rutland , Andrey Konovalov , Anshuman Khandual , Valentin Schneider , Ingo Molnar , Peter Zijlstra , "moderated list:ARM PORT" , "open list:SUPERH" , "open list:BROADCOM BMIPS MIPS ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" Subject: Re: [PATCH 03/11] genirq: Export irq_set_affinity_locked() In-Reply-To: <3e73c85e-20d1-43ae-3c3a-04322ffa970e@gmail.com> References: <20210924170546.805663-1-f.fainelli@gmail.com> <20210924170546.805663-4-f.fainelli@gmail.com> <87tui8ub87.wl-maz@kernel.org> <87tui8cpwd.ffs@tglx> <87r1dccp5z.ffs@tglx> <3e73c85e-20d1-43ae-3c3a-04322ffa970e@gmail.com> Date: Mon, 27 Sep 2021 20:18:36 +0200 Message-ID: <87tui5c26b.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_111841_945040_92A6D765 X-CRM114-Status: GOOD ( 16.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 27 2021 at 10:47, Florian Fainelli wrote: > On 9/25/21 2:37 PM, Thomas Gleixner wrote: >>> I wanted to kill these callbacks years ago. Cavium has two variants of >>> those offline/online callbacks: >>> >>> 1) octeon_irq_cpu_offline_ciu() which is doing the same as that BCM >>> driver. These really can go away. Just remove the callback and >>> everything just works. >> >> For BCM this works today when that chip is used on ARM[64] simply >> because the only architecture which invokes irq_cpu_offline() is MIPS. > > That is correct. How would you recommend addressing that? In premise > when this driver is used on ARM[64] it is used as a second level > interrupt controller hanging off the ARM GIC (or another ARM CPU > interrupt controller), so in that case I suppose I could make the > irq_set_cpu_offline be dependent upon CONFIG_SMP and CONFIG_MIPS, would > that be acceptable? Why? Just get rid of the callback in that driver and ensure that irq_migrate_all_off_this_cpu() is invoked when the CPU dies. arch/mips/kernel/smp-cps.c already does that, but I don't know whether your MIPS platform uses those SMP ops. If not you surely have a template there. Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel