From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C607C433F5 for ; Sat, 25 Sep 2021 21:23:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A4AF61041 for ; Sat, 25 Sep 2021 21:23:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2A4AF61041 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4yrZOrOTs/XVR9TQ37+3gn4mDfEuHgyapcxj90OwUe4=; b=PefPHkMRTWMA1F udpBr8kmax1VdcggB9DyXOYSvQ2ymbvm5MFIn4OffdyV10tpL3v3OvGdq8aqcXKyz7hPLpH0N/k0p cK6xljZxJFCmVojgbDZYsHG03Q1U4BUSnITby6DfQEjSTO2vQsuBG+YuW5hWfPot+1FFjDhBpooE0 mU8cmbVrIm4r1yQ1uPZSQ3BFgdHIQcQIpMyytO1BWollevNU/OXXxWMx/fjR7PVtKRducvbdDay8M 3NsremZdf6vLY1T3ZPsRVQHdgzAJo8obKWhWwmxIfHUZ6RXFsqEXKaQcuNIUyHw2dZERJ1+pcUahN 8Demh0ZgvB9kjPxKK8Hg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUF7A-00HGgZ-TQ; Sat, 25 Sep 2021 21:21:45 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUF76-00HGfz-OV for linux-arm-kernel@lists.infradead.org; Sat, 25 Sep 2021 21:21:42 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1632604899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FC2izg75fJTteYJOOY6ytBStpF+HBmdWWfEDalx5dPI=; b=zi0D8Pec3oIRsFEDPhIwdmHOrVY6LP42R44wotvWquExDYl68XwyZjr8YKRT2C/lMZPmrk dt9/TA8UlxiMasgJo09ceeQc6M8OKaLT69Yl5M1z9CxhuciWbmtrBUnx6NOHkbazUKHCc3 +gkKwZyU7rIhasYeVkYNIBtaUfPbJmoiDqLsNNdltKUYLBPvVBfyJbiVSJzvKcFpN2qE03 os7AFbvHBI9QQmNvtBa9GZe15hLFyNhZXk/a0Xd13USTH4EJJ84GIfnbIdYLcRxqXTyh/z HWHV7t6KKonadUpLzOOGpIdMJeXFcH3va/P7p+EUkuXObHF4ho3/9JsnYhIVdw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1632604899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FC2izg75fJTteYJOOY6ytBStpF+HBmdWWfEDalx5dPI=; b=Pu7/xNkZmyrhNRUMgJdHgur9uaDO525VlERAI3Og3nK8N5yts54/hzguhnV1QeJaTTGDRK 8Z4O+ch55n12DLBg== To: Marc Zyngier , Florian Fainelli Cc: linux-kernel@vger.kernel.org, Russell King , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Catalin Marinas , Will Deacon , Yoshinori Sato , Rich Felker , Rob Herring , Frank Rowand , Ard Biesheuvel , Mike Rapoport , Linus Walleij , Andrew Morton , Geert Uytterhoeven , Arnd Bergmann , Guenter Roeck , Kefeng Wang , Mark Rutland , Andrey Konovalov , Anshuman Khandual , Valentin Schneider , Ingo Molnar , Peter Zijlstra , "moderated list:ARM PORT" , "open list:SUPERH" , "open list:BROADCOM BMIPS MIPS ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" Subject: Re: [PATCH 03/11] genirq: Export irq_set_affinity_locked() In-Reply-To: <87tui8ub87.wl-maz@kernel.org> References: <20210924170546.805663-1-f.fainelli@gmail.com> <20210924170546.805663-4-f.fainelli@gmail.com> <87tui8ub87.wl-maz@kernel.org> Date: Sat, 25 Sep 2021 23:21:38 +0200 Message-ID: <87tui8cpwd.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210925_142140_984402_9005DDA6 X-CRM114-Status: GOOD ( 19.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Sep 25 2021 at 12:48, Marc Zyngier wrote: > On Fri, 24 Sep 2021 18:05:38 +0100, Florian Fainelli wrote: >> } >> +EXPORT_SYMBOL_GPL(irq_set_affinity_locked); > > This doesn't seem right. > > This driver seem to try and move interrupts on its own when the CPU > goes down. Why can't it rely on the normal CPU hotplug infrastructure > to do so like all the other drivers (bar some Cavium driver that does > the same thing)? > > I'd rather you take this opportunity to move these drivers into the > 21st century, so that we can kill irq_cpu_offline() and co altogether. I wanted to kill these callbacks years ago. Cavium has two variants of those offline/online callbacks: 1) octeon_irq_cpu_offline_ciu() which is doing the same as that BCM driver. These really can go away. Just remove the callback and everything just works. 2) Two other variants to fiddle with chip internals, but those chips do not have an irq_affinity() callback which makes it more interesting. I don't see a proper way to solve that except for removing Cavium alltogether, but once the BCM one is gone, we just can make this muck depend on CAVIUM and be done with it. And I mean depend and not select. Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel