From: Marc Zyngier <maz@kernel.org>
To: Samuel Holland <samuel@sholland.org>
Cc: Ondrej Jirman <megous@megous.com>,
devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 03/10] irqchip/sun6i-r: Use a stacked irqchip driver
Date: Thu, 14 Jan 2021 21:06:00 +0000 [thread overview]
Message-ID: <87turjjkjr.wl-maz@kernel.org> (raw)
In-Reply-To: <20210112055950.21209-4-samuel@sholland.org>
Hi Samuel,
On 2021-01-12 05:59, Samuel Holland wrote:
[...]
> +static void sun6i_r_intc_ack_nmi(void)
> +{
> + writel(SUN6I_NMI_BIT, base + SUN6I_IRQ_PENDING(0));
writel_relaxed()
> +}
> +
> +static void sun6i_r_intc_nmi_ack(struct irq_data *data)
> +{
> + if (irqd_get_trigger_type(data) & IRQ_TYPE_EDGE_BOTH)
> + sun6i_r_intc_ack_nmi();
> + else
> + data->chip_data = SUN6I_NMI_NEEDS_ACK;
> +}
> +
> +static void sun6i_r_intc_nmi_eoi(struct irq_data *data)
> +{
> + /* For oneshot IRQs, delay the ack until the IRQ is unmasked. */
> + if (data->chip_data == SUN6I_NMI_NEEDS_ACK && !irqd_irq_masked(data))
> {
> + sun6i_r_intc_ack_nmi();
> + data->chip_data = 0;
nit: NULL rather than 0?
[...]
> +static struct irq_chip sun6i_r_intc_nmi_chip = {
> + .name = "sun6i-r-intc",
> + .irq_ack = sun6i_r_intc_nmi_ack,
> + .irq_mask = irq_chip_mask_parent,
> + .irq_unmask = sun6i_r_intc_nmi_unmask,
> + .irq_eoi = sun6i_r_intc_nmi_eoi,
> + .irq_set_affinity = irq_chip_set_affinity_parent,
> + .irq_set_type = sun6i_r_intc_nmi_set_type,
> + .irq_set_irqchip_state = sun6i_r_intc_nmi_set_irqchip_state,
You probably also want to wire irq_get_irqchip_state(), while
you're at it.
Otherwise, looks pretty good now.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-14 21:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 5:59 [PATCH v4 00/10] sunxi: Support IRQ wakeup from deep sleep Samuel Holland
2021-01-12 5:59 ` [PATCH v4 01/10] dt-bindings: irq: sun6i-r: Split the binding from sun7i-nmi Samuel Holland
2021-01-14 20:11 ` Rob Herring
2021-01-12 5:59 ` [PATCH v4 02/10] dt-bindings: irq: sun6i-r: Add a compatible for the H3 Samuel Holland
2021-01-12 5:59 ` [PATCH v4 03/10] irqchip/sun6i-r: Use a stacked irqchip driver Samuel Holland
2021-01-14 21:06 ` Marc Zyngier [this message]
2021-01-15 4:01 ` Samuel Holland
2021-01-15 9:30 ` Marc Zyngier
2021-01-12 5:59 ` [PATCH v4 04/10] irqchip/sun6i-r: Add wakeup support Samuel Holland
2021-01-14 21:44 ` Marc Zyngier
2021-01-15 4:04 ` Samuel Holland
2021-01-12 5:59 ` [PATCH v4 05/10] ARM: dts: sunxi: Rename nmi_intc to r_intc Samuel Holland
2021-01-12 5:59 ` [PATCH v4 06/10] ARM: dts: sunxi: Use the new r_intc binding Samuel Holland
2021-01-12 5:59 ` [PATCH v4 07/10] ARM: dts: sunxi: h3/h5: Add r_intc node Samuel Holland
2021-01-12 5:59 ` [PATCH v4 08/10] ARM: dts: sunxi: Move wakeup-capable IRQs to r_intc Samuel Holland
2021-01-12 5:59 ` [PATCH v4 09/10] arm64: dts: allwinner: Use the new r_intc binding Samuel Holland
2021-01-12 5:59 ` [PATCH v4 10/10] arm64: dts: allwinner: Move wakeup-capable IRQs to r_intc Samuel Holland
2021-01-14 12:16 ` [PATCH v4 00/10] sunxi: Support IRQ wakeup from deep sleep Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87turjjkjr.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=megous@megous.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=tglx@linutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).