From: Baruch Siach <baruch@tkos.co.il>
To: Fabio Estevam <festevam@gmail.com>
Cc: andrew@lunn.ch, linux@armlinux.org.uk, smoch@web.de,
stwiss.opensource@diasemi.com, linux-imx@nxp.com,
kernel@pengutronix.de, shawnguo@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC] ARM: dts: imx: Fix the AR803X phy-mode
Date: Sat, 30 Mar 2019 22:06:40 +0300 [thread overview]
Message-ID: <87tvfkkwqn.fsf@tarshish> (raw)
In-Reply-To: <20190330155051.9855-1-festevam@gmail.com>
Hi Fabio,
On Sat, Mar 30 2019, Fabio Estevam wrote:
> Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
> exposed an issue on imx DTS files using AR8031/AR8035 PHYs.
>
> The end result is that the boards can no longer obtain an IP address
> via UDHCP, for example.
>
> Quoting Andrew Lunn:
>
> "The problem here is, all the DTs were broken since day 0. However,
> because the PHY driver was also broken, nobody noticed and it
> worked. Now that the PHY driver has been fixed, all the bugs in the
> DTs now become an issue"
>
> To fix this problem, the phy-mode property needs to be "rgmii-id", which
> has the following meaning as per
> Documentation/devicetree/bindings/net/ethernet.txt:
>
> "RGMII with internal RX and TX delays provided by the PHY, the MAC should
> not add the RX or TX delays in this case)"
>
> Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with
> successfully restored networking.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Hi,
>
> Marking it as RFC in the hope of getting some feedback as to how
> to proceed with fixing this regression on 5.1-rc1.
>
> It's not possible to know if there are other imx boards in tree that use
> AR803X, so here is an attempt.
>
> mx6-sabresd, imx6sx-sdb and imx7d-pico have been successfully tested.
The SolidRun SOM is also affected, I believe (imx6qdl-sr-som.dtsi,
AR8035). Would you be able to test it on your side?
Thanks,
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-30 19:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 15:50 [RFC] ARM: dts: imx: Fix the AR803X phy-mode Fabio Estevam
2019-03-30 16:18 ` Andrew Lunn
2019-04-01 12:53 ` Fabio Estevam
2019-03-30 19:06 ` Baruch Siach [this message]
2019-03-30 19:11 ` Fabio Estevam
2019-03-31 3:50 ` Baruch Siach
2019-03-31 10:44 ` Soeren Moch
2019-04-01 8:38 ` Steve Twiss
2019-04-01 12:48 ` Fabio Estevam
2019-04-01 9:01 ` Sébastien Szymanski
2019-04-01 9:05 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvfkkwqn.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=andrew@lunn.ch \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux@armlinux.org.uk \
--cc=shawnguo@kernel.org \
--cc=smoch@web.de \
--cc=stwiss.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).