From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFEDCC43381 for ; Sat, 30 Mar 2019 19:07:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A86652184C for ; Sat, 30 Mar 2019 19:07:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rJxUNtpf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A86652184C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tkos.co.il Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=uoxCpFusQZU03fD1F5fF38UhtRJ7j+JQa5gFGCAPNGo=; b=rJxUNtpfg+lZsiPpGs3Jthk1SJ AdyisxdkzPawVzZfd3jxi3793/YXplnS1+FvUhtndHAWQ98X6iOf1nRzoJ96cEd9syvahbEGY8wkD uqybPmaXYqb3LfPF8dWc2V13sqeF2FE9gpBFCiZFypR4TaQ0BZ7QxaLVFik+97QjMKXPYAXVKSaS8 J5CyxJuS5FB9UyZ8zkqa8o1cA3GwGVMCbwBucamFAZtnMA/48u+p4sg95Qvkb7xVadLKazwGUxJI0 WXfXFyMkGV5pL9hvWKelX7sv8Kw5TQqxepxhhvPmrjbIBTKWlgBQ+fhFBIMvWxtFFLQ4R4t3mLHKZ OK9WujsQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAJJd-0000L7-Cu; Sat, 30 Mar 2019 19:06:53 +0000 Received: from guitar.tcltek.co.il ([192.115.133.116] helo=mx.tkos.co.il) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAJJY-0000Kh-37 for linux-arm-kernel@lists.infradead.org; Sat, 30 Mar 2019 19:06:50 +0000 Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id F000944064E; Sat, 30 Mar 2019 22:06:23 +0300 (IDT) References: <20190330155051.9855-1-festevam@gmail.com> User-agent: mu4e 1.0; emacs 26.1 From: Baruch Siach To: Fabio Estevam Subject: Re: [RFC] ARM: dts: imx: Fix the AR803X phy-mode In-reply-to: <20190330155051.9855-1-festevam@gmail.com> Date: Sat, 30 Mar 2019 22:06:40 +0300 Message-ID: <87tvfkkwqn.fsf@tarshish> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190330_120648_363317_3FB439A3 X-CRM114-Status: GOOD ( 14.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, linux@armlinux.org.uk, smoch@web.de, stwiss.opensource@diasemi.com, linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fabio, On Sat, Mar 30 2019, Fabio Estevam wrote: > Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") > exposed an issue on imx DTS files using AR8031/AR8035 PHYs. > > The end result is that the boards can no longer obtain an IP address > via UDHCP, for example. > > Quoting Andrew Lunn: > > "The problem here is, all the DTs were broken since day 0. However, > because the PHY driver was also broken, nobody noticed and it > worked. Now that the PHY driver has been fixed, all the bugs in the > DTs now become an issue" > > To fix this problem, the phy-mode property needs to be "rgmii-id", which > has the following meaning as per > Documentation/devicetree/bindings/net/ethernet.txt: > > "RGMII with internal RX and TX delays provided by the PHY, the MAC should > not add the RX or TX delays in this case)" > > Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with > successfully restored networking. > > Signed-off-by: Fabio Estevam > --- > Hi, > > Marking it as RFC in the hope of getting some feedback as to how > to proceed with fixing this regression on 5.1-rc1. > > It's not possible to know if there are other imx boards in tree that use > AR803X, so here is an attempt. > > mx6-sabresd, imx6sx-sdb and imx7d-pico have been successfully tested. The SolidRun SOM is also affected, I believe (imx6qdl-sr-som.dtsi, AR8035). Would you be able to test it on your side? Thanks, baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel