Support for Iomega iConnect

Support for Iomega iConnect

[Adam Baker]

Hi,

Is anyone aware of any technical reason why support for the Iomega iConnect is 
not included in the mainline kernel (e.g. there are significant changes 
happening in the area of the Kirkwood CPUs that mean now isn't a good time to 
include it). There are several versions floating around the internet but as far 
as I can see the only mention of the iConnect on this list is Russell saying 
he will remove it from mach types soon as there is no mainline support for it.

Based upon work that Iomega posted to the open source code area on their web 
site and code that was submitted to OpenWRT with a sign off line from Wojciech 
Dubowik, I have patched support into the 3.2.11 kernel. If there is no 
objection in principle to inclusion then I will rebase the patch and submit 
it.

Is Linus' git repository still the preferred baseline for linux-arm patches?

Regards

Adam Baker

Support for Iomega iConnect

[Jason Cooper]

On Fri, Mar 30, 2012 at 11:30:49PM +0100, Adam Baker wrote:
> Hi,

Hi Adam,

> Is anyone aware of any technical reason why support for the Iomega iConnect is 
> not included in the mainline kernel (e.g. there are significant changes 
> happening in the area of the Kirkwood CPUs that mean now isn't a good time to 
> include it).

No one ushered it in.  Patches are always welcome.

> There are several versions floating around the internet but as far 
> as I can see the only mention of the iConnect on this list is Russell saying 
> he will remove it from mach types soon as there is no mainline support for it.

mach-type is no longer needed, once conversion to devicetree is done.
Converting you patches to devicetree should be pretty easy.  See my
recommendation, below.

> Based upon work that Iomega posted to the open source code area on their web 
> site and code that was submitted to OpenWRT with a sign off line from Wojciech 
> Dubowik, I have patched support into the 3.2.11 kernel. If there is no 
> objection in principle to inclusion then I will rebase the patch and submit 
> it.

Please base off of v3.3 and merge in the following branch:

git://git.infradead.org/users/jcooper/linux-kirkwood.git kirkwood_dt_for_3.4_v3

This has been merged into Linus' tree, but it's after v3.3.

You can also look at the history in this branch to see how support for
dreamplug (also kirkwood SoC) was added.  Converting drivers to
devicetree is still a work in progress, so, just match what dreamplug is
doing.

Post the resulting patches to the ml, and I'll queue it up with the others
(after sufficient review, of course).

> Is Linus' git repository still the preferred baseline for linux-arm patches?

Yes, always base off of a tag as I mentioned above.

Just shout if you have any questions.

hth,

Jason.

Support for Iomega iConnect

[Jason Cooper]

On Fri, Mar 30, 2012 at 07:24:19PM -0400, Jason Cooper wrote:
> You can also look at the history in this branch to see how support for
> dreamplug (also kirkwood SoC) was added.  Converting drivers to
> devicetree is still a work in progress, so, just match what dreamplug is
> doing.

Here's another example to follow, the Buffalo DNS-32[05]:

First patch is here:

http://www.spinics.net/lists/arm-kernel/msg166774.html

Converting the nand driver and using it is here:

http://www.spinics.net/lists/arm-kernel/msg167308.html

hth,

Jason.

Support for Iomega iConnect

[Arnaud Patard (Rtp)]

Adam Baker <linux@baker-net.org.uk> writes:

> Hi,

Hi,

>
> Is anyone aware of any technical reason why support for the Iomega iConnect is 
> not included in the mainline kernel (e.g. there are significant changes 
> happening in the area of the Kirkwood CPUs that mean now isn't a good time to 
> include it). There are several versions floating around the internet but as far 
> as I can see the only mention of the iConnect on this list is Russell saying 
> he will remove it from mach types soon as there is no mainline support for it.
>
> Based upon work that Iomega posted to the open source code area on their web 
> site and code that was submitted to OpenWRT with a sign off line from Wojciech 
> Dubowik, I have patched support into the 3.2.11 kernel. If there is no 
> objection in principle to inclusion then I will rebase the patch and submit 
> it.

fwiw, I'm working on getting iconnect supported in mainline. I've written a
patch for it but it's not DT powered so I'm currently looking at
kirkwood DT stuff in order to convert it to DT. Once it'll be done, I'll
submit that to mainline.


Arnaud