linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jacmet@sunsite.dk (Peter Korsgaard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported 15bit modes
Date: Tue, 10 Jan 2012 14:17:01 +0100	[thread overview]
Message-ID: <87ty43d7ea.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20120110130146.GC2057@taskit.de> (Christian Glindkamp's message of "Tue, 10 Jan 2012 14:01:46 +0100")

>>>>> "Christian" == Christian Glindkamp <christian.glindkamp@taskit.de> writes:

Hi,

 >> So it doesn't really support RGB555 mode. The controller reads up to
 >> 32bit of framebuffer data and outputs 24bit on the LCD pins. You CAN
 >> wire up a RGB555 panel by just skipping the LSB green of a RGB565
 >> wiring, but that is independent of the framebufffer format.

 Christian> But the AT91SAM9261/AT91SAM9263 do not have a native RGB565
 Christian> format if it is configured for 16bit (so it does not read
 Christian> 32bit and output 24bit but just 16bit) but uses BGR555 with
 Christian> an additional intensity bit in the MSB like the palette
 Christian> where you also kept the BGR555 format. How can you get
 Christian> correct colors on these processors if this code above is
 Christian> removed?

Ahh, I wasn't aware of that (I'm using 9g45). I guess we need to do
something similar to what I did for the palette handling:

https://github.com/at91linux/linux-at91/commit/7a256fc44c1892ad3166363ba309d9996a49e7b8

E.G. keep the RBG555/BGR555 format for the old devices, and my proposed
change for the new ones. I'll cook something up.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2012-01-10 13:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-13 14:52 [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported 15bit modes Peter Korsgaard
2012-01-05 11:26 ` Peter Korsgaard
2012-01-09  2:49   ` Florian Tobias Schandinat
2012-01-09  6:15     ` Peter Korsgaard
2012-01-09 13:36     ` Nicolas Ferre
2012-01-09 10:34 ` Nicolas Ferre
2012-01-09 11:13   ` Peter Korsgaard
2012-01-09 13:32     ` Nicolas Ferre
2012-01-10 13:01     ` Christian Glindkamp
2012-01-10 13:17       ` Peter Korsgaard [this message]
2012-01-10 16:42       ` Peter Korsgaard
2012-01-10 14:02     ` Jamie Lokier
2012-01-10 14:19       ` Peter Korsgaard
2012-01-10 21:06       ` Russell King - ARM Linux
2012-01-09 12:13   ` Russell King - ARM Linux
2012-01-09 12:20     ` Peter Korsgaard
2012-01-30  5:12 ` Florian Tobias Schandinat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ty43d7ea.fsf@macbook.be.48ers.dk \
    --to=jacmet@sunsite.dk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).