linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pxamci: fix printing gpio numbers in pxamci_probe
@ 2009-10-02 14:24 Antonio Ospite
  2009-10-05 10:45 ` Antonio Ospite
  0 siblings, 1 reply; 5+ messages in thread
From: Antonio Ospite @ 2009-10-02 14:24 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
 drivers/mmc/host/pxamci.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
index 5e0b152..b00d673 100644
--- a/drivers/mmc/host/pxamci.c
+++ b/drivers/mmc/host/pxamci.c
@@ -693,7 +693,7 @@ static int pxamci_probe(struct platform_device *pdev)
 	if (gpio_is_valid(gpio_ro)) {
 		ret = gpio_request(gpio_ro, "mmc card read only");
 		if (ret) {
-			dev_err(&pdev->dev, "Failed requesting gpio_ro %d\n", gpio_power);
+			dev_err(&pdev->dev, "Failed requesting gpio_ro %d\n", gpio_ro);
 			goto err_gpio_ro;
 		}
 		gpio_direction_input(gpio_ro);
@@ -701,7 +701,7 @@ static int pxamci_probe(struct platform_device *pdev)
 	if (gpio_is_valid(gpio_cd)) {
 		ret = gpio_request(gpio_cd, "mmc card detect");
 		if (ret) {
-			dev_err(&pdev->dev, "Failed requesting gpio_cd %d\n", gpio_power);
+			dev_err(&pdev->dev, "Failed requesting gpio_cd %d\n", gpio_cd);
 			goto err_gpio_cd;
 		}
 		gpio_direction_input(gpio_cd);
-- 
1.6.4.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] pxamci: fix printing gpio numbers in pxamci_probe
  2009-10-02 14:24 [PATCH] pxamci: fix printing gpio numbers in pxamci_probe Antonio Ospite
@ 2009-10-05 10:45 ` Antonio Ospite
  2009-10-05 17:56   ` Robert Jarzmik
  0 siblings, 1 reply; 5+ messages in thread
From: Antonio Ospite @ 2009-10-05 10:45 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri,  2 Oct 2009 16:24:02 +0200
Antonio Ospite <ospite@studenti.unina.it> wrote:

> Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
> ---
>  drivers/mmc/host/pxamci.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
> index 5e0b152..b00d673 100644
> --- a/drivers/mmc/host/pxamci.c
> +++ b/drivers/mmc/host/pxamci.c
> @@ -693,7 +693,7 @@ static int pxamci_probe(struct platform_device *pdev)
>  	if (gpio_is_valid(gpio_ro)) {
>  		ret = gpio_request(gpio_ro, "mmc card read only");
>  		if (ret) {
> -			dev_err(&pdev->dev, "Failed requesting gpio_ro %d\n", gpio_power);
> +			dev_err(&pdev->dev, "Failed requesting gpio_ro %d\n", gpio_ro);
>  			goto err_gpio_ro;
>  		}
>  		gpio_direction_input(gpio_ro);
> @@ -701,7 +701,7 @@ static int pxamci_probe(struct platform_device *pdev)
>  	if (gpio_is_valid(gpio_cd)) {
>  		ret = gpio_request(gpio_cd, "mmc card detect");
>  		if (ret) {
> -			dev_err(&pdev->dev, "Failed requesting gpio_cd %d\n", gpio_power);
> +			dev_err(&pdev->dev, "Failed requesting gpio_cd %d\n", gpio_cd);
>  			goto err_gpio_cd;
>  		}
>  		gpio_direction_input(gpio_cd);
> -- 
> 1.6.4.3
> 

Ping.

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20091005/cadc7a03/attachment.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] pxamci: fix printing gpio numbers in pxamci_probe
  2009-10-05 10:45 ` Antonio Ospite
@ 2009-10-05 17:56   ` Robert Jarzmik
  2009-10-08 13:21     ` Eric Miao
  0 siblings, 1 reply; 5+ messages in thread
From: Robert Jarzmik @ 2009-10-05 17:56 UTC (permalink / raw)
  To: linux-arm-kernel

Antonio Ospite <ospite@studenti.unina.it> writes:

> On Fri,  2 Oct 2009 16:24:02 +0200
> Antonio Ospite <ospite@studenti.unina.it> wrote:
>
>> Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>

As this fixes code I wrote poorly, feel free to have my :
Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>

Eric, I think this can be scheduled without any problem into your linux-next
branch.

Cheers

--
Robert

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] pxamci: fix printing gpio numbers in pxamci_probe
  2009-10-05 17:56   ` Robert Jarzmik
@ 2009-10-08 13:21     ` Eric Miao
  2009-10-08 14:52       ` Antonio Ospite
  0 siblings, 1 reply; 5+ messages in thread
From: Eric Miao @ 2009-10-08 13:21 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Oct 6, 2009 at 1:56 AM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> Antonio Ospite <ospite@studenti.unina.it> writes:
>
>> On Fri, ?2 Oct 2009 16:24:02 +0200
>> Antonio Ospite <ospite@studenti.unina.it> wrote:
>>
>>> Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
>
> As this fixes code I wrote poorly, feel free to have my :
> Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>
>
> Eric, I think this can be scheduled without any problem into your linux-next
> branch.
>

Applied to 'fix'.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] pxamci: fix printing gpio numbers in pxamci_probe
  2009-10-08 13:21     ` Eric Miao
@ 2009-10-08 14:52       ` Antonio Ospite
  0 siblings, 0 replies; 5+ messages in thread
From: Antonio Ospite @ 2009-10-08 14:52 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, 8 Oct 2009 21:21:48 +0800
Eric Miao <eric.y.miao@gmail.com> wrote:

> On Tue, Oct 6, 2009 at 1:56 AM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> > Antonio Ospite <ospite@studenti.unina.it> writes:
> >
> >> On Fri, ?2 Oct 2009 16:24:02 +0200
> >> Antonio Ospite <ospite@studenti.unina.it> wrote:
> >>
> >>> Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
> >
> > As this fixes code I wrote poorly, feel free to have my :
> > Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>
> >
> > Eric, I think this can be scheduled without any problem into your linux-next
> > branch.
> >
> 
> Applied to 'fix'.

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20091008/d6ba79f0/attachment-0001.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-10-08 14:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-02 14:24 [PATCH] pxamci: fix printing gpio numbers in pxamci_probe Antonio Ospite
2009-10-05 10:45 ` Antonio Ospite
2009-10-05 17:56   ` Robert Jarzmik
2009-10-08 13:21     ` Eric Miao
2009-10-08 14:52       ` Antonio Ospite

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).