From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: "Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Samuel Holland" <samuel@sholland.org>,
"Richard Genoud" <richard.genoud@bootlin.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Wentao Liang" <vulab@iscas.ac.cn>,
"Johan Hovold" <johan@kernel.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 07/16] mtd: rawnand: sunxi: rework pattern found registers
Date: Tue, 28 Oct 2025 17:20:41 +0100 [thread overview]
Message-ID: <87v7jz576u.fsf@bootlin.com> (raw)
In-Reply-To: <6097267.MhkbZ0Pkbq@jernej-laptop> ("Jernej Škrabec"'s message of "Tue, 28 Oct 2025 16:41:48 +0100")
On 28/10/2025 at 16:41:48 +01, Jernej Škrabec <jernej.skrabec@gmail.com> wrote:
> Dne torek, 28. oktober 2025 ob 08:35:00 Srednjeevropski standardni čas je Richard Genoud napisal(a):
>> On H6/H616, the register ECC_PAT_FOUND is at its own address, and not
>> part of ECC status register.
>> So, introduce the pattern found register offset in sunxi_nfc_caps, along
>> with its mask.
>>
>> Also, introduce a non compile-time field_get() because FIELD_GET() and
>> u32_get_bits() don't work with non compile-time constant.
>> https://lore.kernel.org/all/cover.1761588465.git.geert+renesas@glider.be
>
> Urls should use Link: tag and be placed at the bottom.
I was about to apply, so I'll fix this while applying.
>
> Code itself looks fine.
Thanks for the review!
Miquèl
next prev parent reply other threads:[~2025-10-28 16:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 7:34 [PATCH v4 00/16] Introduce Allwinner H6/H616 NAND controller support Richard Genoud
2025-10-28 7:34 ` [PATCH v4 01/16] dt-bindings: mtd: sunxi: Add H616 compatible Richard Genoud
2025-10-28 7:34 ` [PATCH v4 02/16] mtd: rawnand: sunxi: Remove superfluous register readings Richard Genoud
2025-10-28 7:34 ` [PATCH v4 03/16] mtd: rawnand: sunxi: Replace hard coded value by a define Richard Genoud
2025-10-28 15:34 ` Jernej Škrabec
2025-10-28 7:34 ` [PATCH v4 04/16] mtd: rawnand: sunxi: move ECC strenghts in sunxi_nfc_caps Richard Genoud
2025-10-28 7:34 ` [PATCH v4 05/16] mtd: rawnand: sunxi: introduce reg_ecc_err_cnt " Richard Genoud
2025-10-28 15:36 ` Jernej Škrabec
2025-10-28 7:34 ` [PATCH v4 06/16] mtd: rawnand: sunxi: introduce reg_user_data " Richard Genoud
2025-10-28 15:37 ` Jernej Škrabec
2025-10-28 7:35 ` [PATCH v4 07/16] mtd: rawnand: sunxi: rework pattern found registers Richard Genoud
2025-10-28 15:41 ` Jernej Škrabec
2025-10-28 16:20 ` Miquel Raynal [this message]
2025-10-28 7:35 ` [PATCH v4 08/16] mtd: rawnand: sunxi: add has_ecc_block_512 capability Richard Genoud
2025-10-28 15:43 ` Jernej Škrabec
2025-10-28 7:35 ` [PATCH v4 09/16] mtd: rawnand: sunxi: introduce ecc_mode_mask in sunxi_nfc_caps Richard Genoud
2025-10-28 7:35 ` [PATCH v4 10/16] mtd: rawnand: sunxi: introduce random en/dir " Richard Genoud
2025-10-28 7:35 ` [PATCH v4 11/16] mtd: rawnand: sunxi: introduce reg_pat_id " Richard Genoud
2025-10-28 15:45 ` Jernej Škrabec
2025-10-28 7:35 ` [PATCH v4 12/16] mtd: rawnand: sunxi: introduce reg_spare_area " Richard Genoud
2025-10-28 15:45 ` Jernej Škrabec
2025-10-28 7:35 ` [PATCH v4 13/16] mtd: rawnand: sunxi: introduce ecc_err_mask " Richard Genoud
2025-10-28 7:35 ` [PATCH v4 14/16] mtd: rawnand: sunxi: introduce sram_size " Richard Genoud
2025-10-28 15:46 ` Jernej Škrabec
2025-10-28 7:35 ` [PATCH v4 15/16] mtd: rawnand: sunxi: Add support for H616 nand controller Richard Genoud
2025-10-28 7:35 ` [PATCH v4 16/16] arm64: dts: allwinner: h616: add NAND controller Richard Genoud
2025-10-28 16:23 ` [PATCH v4 00/16] Introduce Allwinner H6/H616 NAND controller support Miquel Raynal
2025-10-28 17:05 ` (subset) " Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7jz576u.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=johan@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=richard.genoud@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=vigneshr@ti.com \
--cc=vulab@iscas.ac.cn \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).