From: Thomas Gleixner <tglx@linutronix.de>
To: Rob Herring <robh@kernel.org>, Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH] of/irq: Convert of_msi_map_id() callers to of_msi_xlate()
Date: Sun, 24 Aug 2025 10:56:24 +0200 [thread overview]
Message-ID: <87v7md2j47.ffs@tglx> (raw)
In-Reply-To: <20250813185244.GA553867-robh@kernel.org>
On Wed, Aug 13 2025 at 13:52, Rob Herring wrote:
> On Tue, Aug 05, 2025 at 03:34:43PM +0200, Lorenzo Pieralisi wrote:
>> With the introduction of the of_msi_xlate() function, the OF layer
>> provides an API to map a device ID and retrieve the MSI controller
>> node the ID is mapped to with a single call.
>>
>> of_msi_map_id() is currently used to map a deviceID to a specific
>> MSI controller node; of_msi_xlate() can be used for that purpose
>> too, there is no need to keep the two functions.
>>
>> Convert of_msi_map_id() to of_msi_xlate() calls and update the
>> of_msi_xlate() documentation to describe how the struct device_node
>> pointer passed in should be set-up to either provide the MSI controller
>> node target or receive its pointer upon mapping completion.
>>
>> Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: Marc Zyngier <maz@kernel.org>
>> ---
>> As suggested by RobH:
>>
>> https://lore.kernel.org/lkml/20250627213241.GA168190-robh@kernel.org/
>>
>> drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c | 2 +-
>> drivers/of/irq.c | 25 +++++----------------
>> drivers/pci/msi/irqdomain.c | 2 +-
>> include/linux/of_irq.h | 6 -----
>> 4 files changed, 7 insertions(+), 28 deletions(-)
>
> Looks good to me. I'm happy to take it with some acks.
>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2025-08-24 9:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 13:34 [PATCH] of/irq: Convert of_msi_map_id() callers to of_msi_xlate() Lorenzo Pieralisi
2025-08-06 16:02 ` Frank Li
2025-08-13 18:52 ` Rob Herring
2025-08-24 8:56 ` Thomas Gleixner [this message]
2025-08-25 22:21 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7md2j47.ffs@tglx \
--to=tglx@linutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).