From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9440CF6497 for ; Sun, 29 Sep 2024 09:53:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Sba0W9BXrHtrxKKj6Par5V2ctYjDoz0w+nZH0Ox3AQc=; b=05csjp9oXMvvMSf6YHw0jzbtJC wyvve/7N+6VPaaoGmvqeZzfHX3yHxMCJnZKo2FGKUjGUi84GFZOcjVFF6d3V+wa5s0U202ezQuZrY lJuWNh+MrC+TthGg1ATrF87LqeO7FJdqBoZ9uYtBJc51OhAukmoT5cVVRHbQHzckBYFK0ZKCCoq2i kaq7LIJjYjfnSMlFRLMy7wIDuTD2RiFanJgxRJkFSyY3ei4Vxq3dASlIkYhqaqkmP9PYEeaPI2ubM 8eN7wzBz5bbrcd8cjUASy2W0+MbVuuOO12vtnt+/Jv4igyPqujBkfD6Lp3Ml388yLeCsTp+YgPNmW Jq7gxmmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1suqc5-0000000EZ8I-1QnL; Sun, 29 Sep 2024 09:53:13 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1suqO0-0000000EX9O-1oVE for linux-arm-kernel@lists.infradead.org; Sun, 29 Sep 2024 09:38:41 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8C9DCA40D5B; Sun, 29 Sep 2024 09:38:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75B29C4CEC5; Sun, 29 Sep 2024 09:38:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727602718; bh=kl8V5IsDsE3p1fGajjYA/Y3X9DNawVe6buZRKJlZ7iw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bz9WR7m9Kw5OQPzaPSrqyRf75yLGjyHVrsNohzqKtyUJB3menm2ztv0U2ujiGl37V QQsc7Lr9O8pN4YnDhCsYLwbe5yGJV3BQ+cDzufBDwYtOeu6PR/v1PV41aFbxqMw21m lM/siBpUU0joceQ/nzzCrzIvbW+X6Nc0UCidhhVPggT67/DDKx6JB9pTCZ22q1jzQB bw3zHhSst0FYG3UmOqHwCRgm+9q9NhgHmf7YqFhZsDlNsiStHBBB5i4MQyHeuB0eS7 E47ypMRXYjrLdMrSehLWHndlCD2+tZfpJUdyaaM5Jv/Iz1BFk6JYCmIppceYMFMVrr li8268Cy/PXLA== Received: from [185.143.37.16] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1suqNw-00GC4u-0U; Sun, 29 Sep 2024 10:38:36 +0100 Date: Sun, 29 Sep 2024 10:38:35 +0100 Message-ID: <87v7yevlyc.wl-maz@kernel.org> From: Marc Zyngier To: jiaqingtong97@gmail.com Cc: Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Joey Gouly , Jia Qingtong , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: vgic: fix GICR_STATUSR in vgic_v3_rd_registers In-Reply-To: <20240929043937.242769-2-jiaqingtong97@gmail.com> References: <20240929043937.242769-2-jiaqingtong97@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.143.37.16 X-SA-Exim-Rcpt-To: jiaqingtong97@gmail.com, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, joey.gouly@arm.com, jiaqingtong@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240929_023840_554980_97FB690F X-CRM114-Status: GOOD ( 19.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 29 Sep 2024 05:39:35 +0100, jiaqingtong97@gmail.com wrote: > > From: Jia Qingtong > > vgic_uaccess use bsearch search regs in vgic_io_device.regions, but the > GICR_STATUSR have wrong order in vgic_v3_rd_registers. > When check all vgic_register_region, it turned out that only > vgic_v3_rd_registers has this problem. > > It's harmless since vgic_uaccess behaves as RAZ&WI when it can't find the > specified reg. This is exactly the same as the behavior of the GICR_STATUSR > register. > > So just move GICR_STATUSR to the right place. That looks correct, but I think we should have some code that ensures that these tables are correct at boot time, just like we're doing for the system registers. Or completely remove our reliance on bsearch(). Another thing is that GICD_STATUSR looks pretty wrong. It is handled as RAO, but we never clear any "error" (it is WI). This has been buggy since GICv3 save/restore was added, 7 years ago. Do you mind spinning a series fixing this up? Thanks, M. -- Without deviation from the norm, progress is not possible.