From: Marc Zyngier <maz@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Oliver Upton <oliver.upton@linux.dev>,
James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Fuad Tabba <tabba@google.com>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] KVM: arm64: Clarify meaning of _MASK and _nMASK for FGT registers
Date: Wed, 31 Jul 2024 21:12:00 +0100 [thread overview]
Message-ID: <87v80l48z3.wl-maz@kernel.org> (raw)
In-Reply-To: <20240731-kvm-arm64-fgt-doc-v1-2-abb364f8fe57@kernel.org>
On Wed, 31 Jul 2024 19:58:38 +0100,
Mark Brown <broonie@kernel.org> wrote:
>
> Since the use of _MASK to mean bits where setting the bit causes traps to
> be generated is a little unusual add a clarifying comment.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> arch/arm64/include/asm/kvm_arm.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/include/asm/kvm_arm.h b/arch/arm64/include/asm/kvm_arm.h
> index d347483395b4..1d8745740fb1 100644
> --- a/arch/arm64/include/asm/kvm_arm.h
> +++ b/arch/arm64/include/asm/kvm_arm.h
> @@ -343,6 +343,10 @@
> * FGT register definitions
> *
> * RES0 and polarity masks for the FGT registers.
> + *
> + * _RES0: Bits which are RES0
> + * _MASK: Bits which enable traps when set
> + * _nMASK: Bits which disable traps when set
The rest of the code call this "negative polarity". Also, in some
cases (such as with HCRX_EL2), such bits are *enable* bits. So you
probably want to capture this as well.
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2024-07-31 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 18:58 [PATCH 0/2] KVM: arm64: Fine grained traps documentation clarification Mark Brown
2024-07-31 18:58 ` [PATCH 1/2] KVM: arm64: Fix outdated comment about incomplete FGT bitmask definitions Mark Brown
2024-07-31 19:55 ` Marc Zyngier
2024-07-31 18:58 ` [PATCH 2/2] KVM: arm64: Clarify meaning of _MASK and _nMASK for FGT registers Mark Brown
2024-07-31 20:12 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v80l48z3.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).