From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6B1DC3DA64 for ; Sun, 28 Jul 2024 21:45:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GV3NHkBhO6MtIhli2bwEhsrTRuWIh24tjHWgFDZ2hRs=; b=umORbf0deSOMcq4dighIOC9pGP PykJccXDyeyZCgJNmAzBlYN9uAledfEy8PeCi5Hft/X47ttR6FL2iraAyzbA6KT/KBjBJH6mcDdnC 5jOkOccMQ1qyIaoxtplICCYaB7RIoC8X7FktB/Y3f1XArh+Uk/0ncLU27i5lSuZm4ByVx4YB1mjp+ vrA5nSBG2mPiCGe2FqJmUROw7Fo7Xp16+YNE9ZAnWdm4391b34AcTJ8ASFzUUplv3vDnJHjfywios Tjq8wAzUpNQvh6Hj/otaZikTPMeEgMXPiAz3GbvEl1mKWLuW/NmWZBs5z+PjPfUv20aBIsuFOQlUO MgVJrQsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYBhb-00000009HqW-1QYP; Sun, 28 Jul 2024 21:45:15 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYBh7-00000009Ho0-1p9Q for linux-arm-kernel@lists.infradead.org; Sun, 28 Jul 2024 21:44:51 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1722203084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GV3NHkBhO6MtIhli2bwEhsrTRuWIh24tjHWgFDZ2hRs=; b=xdmRX4jG8xb8nw401EUfCjlaCweGQOTVdGCn633C9eQ4IFvKMyqBbpbGQuw6ox1qO4y0o7 ilmVsr2Ld1g1hD24DbGiQLuNFx3CLpRBsktcWxe8Md/gPbcrv4etgMkICFsAr0OPU3V/3g aJr5ekm+bABcqTVTHx1FS31WPYlg8B5mlxKQAS3ErjAR4nw6SxzJyBNwjiluWTztrq7goZ I1S4UrsWBmzlS79BhvuAXI3NrGQeJIToXHPlEnta9ebe3W8WtjAyCmG2b2IQkRH5/YCaCN jPij8Hh3wSCV92H9kR07FrKoblBFkScCUwXte3xAV9XAF797DDA35U9dAv7IFw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1722203084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GV3NHkBhO6MtIhli2bwEhsrTRuWIh24tjHWgFDZ2hRs=; b=oPLvtVsK96pLJoseubrQu/iUYoDAT3LiwfDw8UORBzHcFNqJDeA8jkVVvTGcFvvEwYyNMe ETyTaXAF432bi3Cg== To: Marek =?utf-8?Q?Beh=C3=BAn?= , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, arm@kernel.org, Andy Shevchenko , Hans de Goede , Ilpo =?utf-8?Q?J=C3=A4rvinen?= Cc: Marek =?utf-8?Q?Beh=C3=BAn?= Subject: Re: [PATCH 06/13] irqchip/armada-370-xp: Put static variables into driver private structure In-Reply-To: <20240715105156.18388-7-kabel@kernel.org> References: <20240715105156.18388-1-kabel@kernel.org> <20240715105156.18388-7-kabel@kernel.org> Date: Sun, 28 Jul 2024 23:44:43 +0200 Message-ID: <87v80pry2c.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240728_144448_662115_73CFD8A7 X-CRM114-Status: UNSURE ( 7.06 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 15 2024 at 12:51, Marek Beh=C3=BAn wrote: > +struct mpic { > + /* Register regions */ > + void __iomem *base; > + void __iomem *per_cpu; > + > + /* If MPIC is not top-level interrupt controller */ > + int parent_irq; > + > + /* Main IRQ domain */ > + struct irq_domain *domain; > + > +#ifdef CONFIG_SMP > + /* IPI interrupts */ > + struct irq_domain *ipi_domain; > +#endif > + > #ifdef CONFIG_PCI_MSI > -static struct irq_domain *mpic_msi_domain; > -static struct irq_domain *mpic_msi_inner_domain; > -static DECLARE_BITMAP(msi_used, PCI_MSI_FULL_DOORBELL_NR); > -static DEFINE_MUTEX(msi_used_lock); > -static phys_addr_t msi_doorbell_addr; > + /* MSI interrupts */ > + struct irq_domain *msi_domain; > + struct irq_domain *msi_inner_domain; > + DECLARE_BITMAP(msi_used, PCI_MSI_FULL_DOORBELL_NR); > + struct mutex msi_lock; > + phys_addr_t msi_doorbell_addr; > #endif >=20=20 > + /* suspend & resume */ > + u32 doorbell_mask; > +}; Please see: https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#struct-d= eclarations-and-initializers Thanks, tglx