From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFAA9C4345F for ; Mon, 22 Apr 2024 22:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u42pQR6hrWVRO5yLXyvQWhl0vx3r2nCG+YN8fiUBOhA=; b=andKIJVMV4PtFJ QFepPHdzshvXdbXYcKE25qlC8tVg5m/+P+vkwMi/R96W7UhCL4MQNn0fLXqe3UcuV1/NVPGtDxrwC c3b+aOHXgPSKzM8fJIAFut0zEoiGwfGlXmlSsehabu2vcEAp40tW3L88I6kB+fFWHj/RYD57n4gYf FvTO0TSqwbPagL6gbSKzqRlN4ZQ2HgGn9YBHc5dAsq3wpCh0rSMXwQkGueTrSCzVyx83XnBFaIMHY RDYYWdPO2HDLZlJrB7a6249QQw7leN1HwfJjMmvPMVe8Fd3Olp2G3iX6vy8JhvJ/9pNRp8WXvrJ5y 9/0luz5CK2cYpcg7SbGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rz2cf-0000000FJ96-173D; Mon, 22 Apr 2024 22:58:53 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rz2cb-0000000FJ6z-30D0 for linux-arm-kernel@lists.infradead.org; Mon, 22 Apr 2024 22:58:51 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 30E0BCE0CF5; Mon, 22 Apr 2024 22:58:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 522B7C3277B; Mon, 22 Apr 2024 22:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713826716; bh=esn2V8XOCiYcLyvtAXzH1iAi1DKCTXra+1968f985U0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Xhnpmzsbf9Mri1AICNzleKpdSdPcQM5uzRQQr6iR5Ef1rAs0QixfSV42TtZ8JSz93 2d9+wvFcvU+BcSqYnIvPJT8mpS8NaxX5w+AwVQn45OolfkGaJ8xEiVTaptQY9uSpSJ aM2YqKzG8KsdDS/FHCrD7Nenfbnyobf7qjaRWU02SgL3g0AW9JVgLMixb0mO+Wk/Ac Wh0/OHnim4+ajVdvalr1HuwwLmkPYb8KoY1rLQFaHkrBcnFIHa8sEy1jTgKJaabvzm 9UvJfmAjVcOKNQziosCGWJgX2WHCybSDAHdSC8EYpzTcc6h1v/PEdplArJDMwI7FBt 0+ckEQ6kn0mGg== Received: from [12.161.88.66] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rz2cL-006yKr-Kz; Mon, 22 Apr 2024 23:58:34 +0100 Date: Mon, 22 Apr 2024 23:58:24 +0100 Message-ID: <87v849t373.wl-maz@kernel.org> From: Marc Zyngier To: Mark Rutland Cc: Naresh Kamboju , open list , Linux ARM , lkft-triage@lists.linaro.org, Linux Regressions , Arnd Bergmann , Anders Roxell , joey.gouly@arm.com, Oliver Upton Subject: Re: gcc-8: arm64/kvm/pauth.: Error: unknown architectural extension `pauth' In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 12.161.88.66 X-SA-Exim-Rcpt-To: mark.rutland@arm.com, naresh.kamboju@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lkft-triage@lists.linaro.org, regressions@lists.linux.dev, arnd@arndb.de, anders.roxell@linaro.org, joey.gouly@arm.com, oliver.upton@linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240422_155850_367439_EAAAEB0D X-CRM114-Status: GOOD ( 20.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 22 Apr 2024 10:13:59 +0100, Mark Rutland wrote: > > On Mon, Apr 22, 2024 at 02:04:43PM +0530, Naresh Kamboju wrote: > > The arm64 defconfig build failed with gcc-8 and passed with gcc-13. > > > > Reported-by: Linux Kernel Functional Testing > > > > Build log: > > --- > > /tmp/ccSUNNZy.s: Assembler messages: > > /tmp/ccSUNNZy.s:3159: Error: unknown architectural extension `pauth' > > make[5]: *** [scripts/Makefile.build:244: arch/arm64/kvm/pauth.o] Error 1 > > > > Steps to reproduce: > > --- > > # tuxmake --runtime podman --target-arch arm64 --toolchain gcc-8 > > --kconfig defconfig > > I think the key thing here is GCC 8; the associated assembler won't necessarily > have ARMv8.3-A support, since all the relevant bits got added around GCC 9. > > Looking at the commits, I think this is broken since its introduction in commit: > > 6ccc971ee2c61a1f ("KVM: arm64: nv: Add emulation for ERETAx instructions") > > ... where the pauth.c file only depends on ARM64_PTR_AUTH (which doesn't imply > AS_HAS_ARMV8_3), but in the file we do: > > asm volatile(ARM64_ASM_PREAMBLE ".arch_extension pauth\n" > "pacga %0, %1, %2" : "=r" (pac) : "r" (ptr), "r" (mod)); > > Given the minimum supported toolchain comes with an assembler that doesn't > necessarily support ARMv8.3, I reckon we'll either have to make NV pauth > support depend upon AS_HAS_ARMV8_3, or manually assemble the PACGA instruction. > > I suspect the latter is the better option. This is what I've done [1]. It certainly isn't pretty, but this counts as an incentive to drop some of the old stuff in the near-ish future. I've pushed this out to -next, and hopefully the breakage will be solved tomorrow. M. [1] https://lore.kernel.org/r/20240422224849.2238222-1-maz@kernel.org -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel