From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E817EC04A6A for ; Sat, 12 Aug 2023 15:01:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X3OI4hatrl13es7rf6SAKkmLfVqiQCkhgbmfUUswrCc=; b=zZx/2W8z5qX0b/ ID+CwgqAiuhuPCaxwnE7NlIb9T682w4y55aYDvteIlRpbRZHgNVMPBCf3sl4aqdK85L8XRJuz3fFh OtSIHN5sP8oGRIfR5oBhzU3T0gxzcIN5CaIAJjaQEk31oAF2gIsI2vX1TIIl3KZMaUQIgoMtDQYxu seNPf6vLpKDWmVOjFpkOcrBfAMg4uqh8lsgKJuD2tSvt5wc3HsRIsOtgIQG2ldPt+vmFYg4KjeTnn fhYYCExnt2PAExrevt1d+M9hgryjQrzQaFwkfiVA6I3Yv5426M4haS8uYMPVlManzd+SuxZD3jpe2 uTVwu5bpThgduiLVsPiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qUq7E-00DbLr-0v; Sat, 12 Aug 2023 15:01:20 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qUq7A-00DbLI-2t for linux-arm-kernel@lists.infradead.org; Sat, 12 Aug 2023 15:01:19 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id C7D7F1C0002; Sat, 12 Aug 2023 15:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1691852471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Alzx0G/XPXpFyVa7O/4kvWcI5FZUIwHqNqauLfR57Lk=; b=d5UegVnwQCxkeqnhM19cX1CA2NdPjbFqAp9XfSh6kdknk/PpLZ7+GTGeorsXHP+Pp9YBd7 Tt+Y/VNZ7fQcMi9bxO5/sJqX0YMlTYJ/B/BJTowF7kopZHdC+HrZuG9oN2YD7eJ5zXR4rd 3Mqr/Hi9DCe2E8GKHI4rGA9AQUuc5h/wvxTEnZBcbvq8k+zMnoNUQvCexfRkrnBJvgDiN3 +W2sXsFQWxg/uFdhExGK3DS6l/rLvLg30iok1dMRlzQN0pktoLw9FxzBOfIYoX6zwAzu8y QCbL9Z6uzXXl8pp4nXTBDh71HzUx+QKvC7N3Tq055TorH9Pa2vUY/DVmlFaJKA== From: Gregory CLEMENT To: Rob Herring , Andrew Lunn , Sebastian Hesselbarth , Russell King Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: mvebu: Explicitly include correct DT includes In-Reply-To: <20230717225456.3212019-1-robh@kernel.org> References: <20230717225456.3212019-1-robh@kernel.org> Date: Sat, 12 Aug 2023 17:01:09 +0200 Message-ID: <87v8dktidm.fsf@BL-laptop> MIME-Version: 1.0 X-GND-Sasl: gregory.clement@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230812_080117_251486_A40F3BFE X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rob Herring writes: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring Applied on mvebu/arm Thanks, Gregory > --- > arch/arm/mach-mvebu/kirkwood.c | 1 + > arch/arm/mach-mvebu/pmsu.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c > index 8ff34753e760..73b2a86d6489 100644 > --- a/arch/arm/mach-mvebu/kirkwood.c > +++ b/arch/arm/mach-mvebu/kirkwood.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/arch/arm/mach-mvebu/pmsu.c b/arch/arm/mach-mvebu/pmsu.c > index 6f366d8c4231..79c5171f06ec 100644 > --- a/arch/arm/mach-mvebu/pmsu.c > +++ b/arch/arm/mach-mvebu/pmsu.c > @@ -23,8 +23,8 @@ > #include > #include > #include > +#include > #include > -#include > #include > #include > #include > -- > 2.40.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel