From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79863C001E0 for ; Thu, 10 Aug 2023 14:43:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nBP4BzeTeGTiB0IFODSeOmG12qd+S8Hxuy6Skxy6aN4=; b=q/mUHWBYJRI3ph e/xdxSAMZvmfjsmhTPNXgpNRBZsRkAIT6WSOvJfIUrpfpatgXfaGkvIbduVOSvg01o9NUDWUoqVAf Z+YfKTm+jQII06iNohRJ/XKAD2Xz2cqvNAlkAJs6EJcrtM/reVyefIemKVcfnsXx74LopzWp6F3q7 BgkK4t5QLkuBPmIh8MPZ9I9bxSyW1bOT23BJwHL3MAITJV5xGz+aMWtl/s4Ap9aCv2kAPWaJBBmHa 84bQk4C1oy2zKGJe8yJQW2Wz1Xs06BKI6q/y5+ykx9EsVD0E5SGjxVKByJc3A01fwVEjHpxNEQd8t KF+Y/C5IqC1XG8IvkC7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qU6ss-007tiV-2m; Thu, 10 Aug 2023 14:43:30 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qU6sp-007thl-37 for linux-arm-kernel@lists.infradead.org; Thu, 10 Aug 2023 14:43:29 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5157E65E8C; Thu, 10 Aug 2023 14:43:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B119AC433C7; Thu, 10 Aug 2023 14:43:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691678606; bh=MjMPBofj9eixKpMqEVyk0yamw7dMCKm//JFQsitXUOQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=G10d5hVjRTjzj9efCgSrdYmFKSG/1wbZm/+5H0OG2PoQ+KV3x/v+Uq/FWWFvNKbcm PWfvj/6Hp1EaBfMFmDwuU0LbZI/4ecgLupDb9n+islaE1Z+hu9+kxuy1w67AHj0a2c 6ch5/EhlSLJegSDHq4oXi5CUjPfFWynhjtL13N4zY55Dl0fkBRPBTh0slixdUQ13Cn gu7YSxXqiH847+GLgDu3xfaZFYOmj0O4QaIiTqUQc4j/j5Pf1gezTfU8XN/0YMTRZB nueFK9mNhiaQhGAWz7QF1/efofdDVCRLZCSkk+VgK+zFvV2qoo/93tXd8Vm9QgzmBL 7jovM2cCiLBNA== Received: from c-xd4ed8728.customers.hiper-net.dk ([212.237.135.40] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qU6sm-003qzZ-8w; Thu, 10 Aug 2023 15:43:24 +0100 Date: Thu, 10 Aug 2023 15:43:32 +0100 Message-ID: <87v8dnot4b.wl-maz@kernel.org> From: Marc Zyngier To: Miguel Luis Cc: "kvmarm@lists.linux.dev" , "kvm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Catalin Marinas , Eric Auger , Mark Brown , Mark Rutland , Will Deacon , Alexandru Elisei , Andre Przywara , Chase Conklin , Ganapatrao Kulkarni , Darren Hart , James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu Subject: Re: [PATCH v3 14/27] KVM: arm64: nv: Add trap forwarding infrastructure In-Reply-To: <65770FF0-A864-4678-8280-AE9BD666CC12@oracle.com> References: <20230808114711.2013842-1-maz@kernel.org> <20230808114711.2013842-15-maz@kernel.org> <65770FF0-A864-4678-8280-AE9BD666CC12@oracle.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 212.237.135.40 X-SA-Exim-Rcpt-To: miguel.luis@oracle.com, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, eric.auger@redhat.com, broonie@kernel.org, mark.rutland@arm.com, will@kernel.org, alexandru.elisei@arm.com, andre.przywara@arm.com, chase.conklin@arm.com, gankulkarni@os.amperecomputing.com, darren@os.amperecomputing.com, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230810_074328_073746_87FC296B X-CRM114-Status: GOOD ( 14.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Miguel, On Wed, 09 Aug 2023 19:28:08 +0100, Miguel Luis wrote: > > Hi Marc, > > > On 8 Aug 2023, at 11:46, Marc Zyngier wrote: [...] > > + for (int id = __MULTIPLE_CONTROL_BITS__; > > + id < (__COMPLEX_CONDITIONS__ - 1); > > This condition seems to be discarding the last MCB from being checked, > which IIUC it must also be checked. Indeed, well caught. Now fixed. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel