From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC9CCC636D6 for ; Thu, 23 Feb 2023 11:38:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uWQPKzWjCoC4fOWvzYq0lE3x2iEA8FpARfvBEBmr4MA=; b=gsfBprtmKQl0BM 0DRcDAB1lyKKoefLki3AADCBbFlyO/Rky/9byf4c1A8cm23ug5w7E6hbTtMltj/EqUD7uFeO3SCqZ dn0QMkcXXmnELxkdJY38Fp7Y9IVxp0yDT1iaPiUSsHldgfaw+4FTOussM+A4YEFzRItdxw8hDgByH cacwfagM9IWuF+NLTPTtay83GJHpfW5NfnW0+psZyDCYDltEMC+IP4uzq3D8rRbNuUgZxILsZiwPK cseUuHrSy2gyTBnZR/2BJpORBupoVVOFHBbWt0Fjwuk1erEJe1PAAyK7PhsqehU2mcCJTQKfTyWoz SHpg28mg7LfNRiQhX2kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pV9uv-00GBMs-GZ; Thu, 23 Feb 2023 11:37:41 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pV9us-00GBIK-4H for linux-arm-kernel@lists.infradead.org; Thu, 23 Feb 2023 11:37:39 +0000 Received: from maxwell ([213.61.141.186]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis) id 1Mr8SG-1ohIIB3HAU-00oBky; Thu, 23 Feb 2023 12:37:05 +0100 References: <87y1oq5es0.fsf@henneberg-systemdesign.com> <87lekp66ko.fsf@henneberg-systemdesign.com> User-agent: mu4e 1.8.14; emacs 28.2 From: Jochen Henneberg To: Andrew Lunn Cc: Simon Horman , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Ong Boon Leong , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net V3] net: stmmac: Premature loop termination check was ignored Date: Thu, 23 Feb 2023 12:34:18 +0100 In-reply-to: Message-ID: <87v8js4nqa.fsf@henneberg-systemdesign.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:Tp18kdHUx4peZI5q9H44bLg0H5sfi0/5HbgR2C4BrUBu9c6GFih KLg1c7spaS/bksijW33N/vG/iMR9WCkKBCbbOoIEO7N4GZOUJUNQNhqGSe98dmnTwY3UJ8l VXaM+iUCPtxGrcciIOIUIrrmlmnmEvvtbLms227JsVsHimqHfOeue4yq4erQzYRaM7PJ3KC VBW7GDdmnDuWaZ+yWTcrg== UI-OutboundReport: notjunk:1;M01:P0:6/GP2YKieoI=;s72evEBC3vLskuzAwIujN9nVreW bj+zhsX7z84myEV/hIJdLRxvEB3QHwx0LEwK3Wsc5oL4WOhbAHq2/Rh/wiAlAPLONtofcIKlU ub5U2e5i/ptYOZN3lETfF7fV360W7+G/ThzQmWeb67wXpN4/HihFWGsW8oBSh00JORJkEAigk lovHkbt0PbkeHG3Hkn4LimIjhcG+Ggz4A/pROiDTmQbNkZmyRgVRi3cHPYbWDhPvN4dp+R5fd prKk4ZPVQv98+qW9FIIviV2TBz4Z6fp/N1Gq7Pl9y7LBat1A7qYZ/rywWN1Xz4B2FSZ2WRJLG r+cDm1xdvDo3qb/22PMAquz1Bq/GCW3iPsqV4xbsS3sgn7xCMUDqlvg35kBH562jcDbFCb15g rVQHXG7vd++U8wNJBuMHva55Hi/YsBShC0+8eBSo695bbrHhdBVtXgg+76pOe9ienVU6HZS9V TJh+aTocr+nROMozuLwuPB7ZHGERePLaLp0diKiB8uSjzER7M69jASmEiCaMawuxAiLv/aL3p DrKKCsJBZ+fJIPidKPoctWjSsa1ZpBiCO2iLRdnRniTTT648KYC8XmDzgCDXAgR9mlWR6WKzT kW2kW9b6rUz3IJk63vqvuTKVEujiWSL/7EAHF4B4F0chKTaw9OactTyaUgbvnpBGb1hE4z/FC HPvLoCnLOymTAI7voPetQkSkVeaic8qbrHzWKu2ZDg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230223_033738_479236_23EBC849 X-CRM114-Status: GOOD ( 20.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Andrew Lunn writes: > On Wed, Feb 22, 2023 at 04:49:55PM +0100, Henneberg - Systemdesign wrote: >> >> Simon Horman writes: >> >> > On Wed, Feb 22, 2023 at 08:38:28AM +0100, Jochen Henneberg wrote: >> >> >> >> The premature loop termination check makes sense only in case of the >> >> jump to read_again where the count may have been updated. But >> >> read_again did not include the check. >> >> >> >> Fixes: bba2556efad6 ("net: stmmac: Enable RX via AF_XDP zero-copy") >> > >> > This commit was included in v5.13 >> > >> >> Fixes: ec222003bd94 ("net: stmmac: Prepare to add Split Header support") >> > >> > While this one was included in v5.4 >> > >> > It seems to me that each of the above commits correspond to one >> > of the two hunks below. I don't know if that means this >> > patch should be split in two to assist backporting. >> > >> >> I was thinking about this already but the change was so trivial that I >> hesitated to split it into two commits. I wanted I will surely change >> this. > > The advantage of splitting is that it makes back porting easy. Both > parts are needed for 6.1 and 5.15. 5.10 only needs the fix for > ec222003bd94. It if does not easily apply to 5.10 it could get > dropped. By splitting it, the backporting probably happens fully > automated, no human involved. Understood. Will do the split and send two new patches. I will not continue with version upcounting and not send a patch series but two completly independent patches. Jochen > > Andrew -- Henneberg - Systemdesign Jochen Henneberg Loehnfeld 26 21423 Winsen (Luhe) -- Fon: +49 172 160 14 69 Url: https://www.henneberg-systemdesign.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel