From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2ED3C27C76 for ; Wed, 25 Jan 2023 10:06:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ihq7YItoMBULIlo44LzWruxyvXI20hmgBTUBM0CJ0rU=; b=cMiohh5TpLHRJC e1AHXCrGz3X/lYxYag23uo/YHM4A6rcaRgVVB+Gu42avBX+0EZBGW0mxW3NEvf3naow13FIoY3pYg wasQ3Dp+GOUc4Z1a04oOv0hEBSOImE7ITNj/Az0hcic1fINDWRg0ALfHdAzUPn3UJaersuDmF816a em/fJPnPIL+HjjKdjxts67WtQbrb88VomE2kJJqQUSg1S9zUXZ9TfHXTFN6qFjiAYt8msu340YHWs CpH4monIQ6NxB/evx/WHSn+tY9gmjS1WvGJjjwDkOcF0Lpp8Fpdzi4TsMq6+IJsMrxu9RtSg+jArn 5acF91NXmJPnD1OAbn3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKceJ-006oZ0-4u; Wed, 25 Jan 2023 10:05:00 +0000 Received: from sender4-op-o14.zoho.com ([136.143.188.14]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKcbl-006nOu-Jw for linux-arm-kernel@lists.infradead.org; Wed, 25 Jan 2023 10:02:22 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1674640935; cv=none; d=zohomail.com; s=zohoarc; b=bO0Jgi+NMLPOKv1n67AGYFqKmCmzSrXf+YbOLqb3lcnnMWBHWDOtPFf10qsY5r8Oyq6MU0l5ytB505qxUgElHtFhDNVPlqG1NmidiClxPMAV5qqPOGI5s3RXAM9pzB7cK7p0j6wxEbj6JrUrJen33B51iCkPGR9UEK+GPFyvdcQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674640935; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=8T0jm15KjYlDRi1z8VGf6mV8Jc1j+El4vs+3OWm4xCQ=; b=K4rpu+Lm1I4RyX/haKCf4eFEA3j1w8Hnb/vYLU924EwdpvgcSpntciqqgsPVWpWUGlgkYdYLwts8cJGKGvXPtC8sw7W3wU4hsZRF2i7zlDTiBBQlfv+/NrxGHg1bsGqcpGkPoPD94Qcf/TeAh6K/SIg2ZzmrWo//NqU8zQetpzU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=linux.beauty; spf=pass smtp.mailfrom=me@linux.beauty; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1674640935; s=zmail; d=linux.beauty; i=me@linux.beauty; h=Date:Date:Message-ID:From:From:To:To:Cc:Cc:Subject:Subject:In-Reply-To:References:MIME-Version:Content-Type:Message-Id:Reply-To; bh=8T0jm15KjYlDRi1z8VGf6mV8Jc1j+El4vs+3OWm4xCQ=; b=TZmf638uRJ8i5kzEqJGwyC9lylJZDkugjFhadj2uJgHqErwhmlyxoI6IERd3bbhu NEaH+mS+5DcVlZavIYXvUUHJd4q1LaocsJxMrst0I0jYW33iTQ+rMUweGjxkW5aY/VS Sgosb8uQJRZQUrEJv18D1luK5zPaWxLeeYkcjXco= Received: from lchen-xiaoxin.linux.beauty (221.225.241.248 [221.225.241.248]) by mx.zohomail.com with SMTPS id 1674640933874576.2974511908947; Wed, 25 Jan 2023 02:02:13 -0800 (PST) Date: Wed, 25 Jan 2023 18:01:25 +0800 Message-ID: <87v8kvgcga.wl-me@linux.beauty> From: Li Chen To: Greg Kroah-Hartman Cc: Li Chen , Jiri Slaby , Sumit Semwal , Christian =?ISO-8859-1?Q?K=F6nig?= , open list , "open list:SERIAL DRIVERS" , "moderated list:ARM/Ambarella SoC support" , "open list:DMA BUFFER SHARING FRAMEWORK" , "open list:DMA BUFFER SHARING FRAMEWORK" , "moderated list:DMA BUFFER SHARING FRAMEWORK" Subject: Re: [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port In-Reply-To: References: <20230123073305.149940-1-lchen@ambarella.com> <20230123073305.149940-11-lchen@ambarella.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230125_020221_757581_281D8287 X-CRM114-Status: GOOD ( 17.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 23 Jan 2023 17:51:25 +0800, Hi Greg, Sorry for my late reply. Greg Kroah-Hartman wrote: > > On Mon, Jan 23, 2023 at 03:32:25PM +0800, Li Chen wrote: > > This driver add support for Ambarella's uart, which > > can be used for console and etc. > > > > Signed-off-by: Li Chen > > Change-Id: Ie68af7ad2187e21853e58d52cd97fd7145303730 > > --- > > MAINTAINERS | 1 + > > drivers/tty/serial/Kconfig | 16 + > > drivers/tty/serial/Makefile | 1 + > > drivers/tty/serial/ambarella_uart.c | 1581 +++++++++++++++++++++++++++ > > drivers/tty/serial/ambarella_uart.h | 120 ++ > > Why do you need a .h file for a single .c file? They should all be in > one file please. Ok, I will combine them into single source file. > Also, no change-id, you know this... > > thanks, > > greg k-h Regards, Li _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel