From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BF8CC54E76 for ; Tue, 17 Jan 2023 21:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QeSv8QqeZJTVWB9c1VQGDV9+hFccYJmZ5Od8LUwF/Sw=; b=C6NIr84qIsXXq/ PtlkciPDX3VQk2MFzxXnbfUpuQ/I9oohmUPxwgZkTKQ/eSOEUqCCmbIf5a78VgVcM8kE3lMALVlrs 1+WPjAVPjRTsQBk0IeUlhrmc1EcocfVYmQ3R4c6wv9e98BD9IVN/BWq24f1KPzSxCIVW+zvdYrbrY JqeypnROnocpx3JwI6+speENe3GVgJQ0mgZKgAj4g1LXMKd7ahU2yH/o0qpNJlfrF8FXjcfeIzJWv Px/ke5RfibmZjJJGFQdywOuPdqeGhl0d2uXOmjWWYVULL01v0WOvr+TDksfmg27vl4a2mVCw1en5v pJeEk61SWWUAiWbI+8ZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHtbT-00FyWz-6w; Tue, 17 Jan 2023 21:34:47 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHtbO-00FyVY-85 for linux-arm-kernel@lists.infradead.org; Tue, 17 Jan 2023 21:34:45 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1673991280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4AeA8HWTNyA+542Yy1mnW9CN08TqGtQG3B/ZL09l8uA=; b=rPZbbB9sKHo88rdQ3OGBFgtrGJ9u+bOjIl1UgP8rccLaNOWw1AURrjE1FyttmcBp8WPkzM w3Wd/bVVK5MGFa50151Bqa0BJzVN5nTIj0QfQ+6zfdj8Fs4oaSpZli4SAhzQK9MOHjsAX0 trASDeaGpvYDg8Q5wBbswi9BpRxvz1jNwMHv2np2Agtnz1bTwa+qNk5J/NgrS2XAEy2AqN lqEjpxX2Q2QYSQXe4i64FZ4T+MpH6nRBUBKZ61rZa3zN6+rLz4J9UDOnHfg803nrqvyVgS f6SEOJgcOY1UFUx9Fpb9biZe721ptRHSJdFS27fvIbED3PzZFT95lFDk7w/5rQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1673991280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4AeA8HWTNyA+542Yy1mnW9CN08TqGtQG3B/ZL09l8uA=; b=8PeqowJt1eEpwm8buo/EdAdgx5K4vk8M25cJyKrjNd9GznhMFa+Id3HxZVjnX5ja/gmNyr hW5dqFIElLwshyDw== To: Johan Hovold , Marc Zyngier Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Hsin-Yi Wang , Mark-PK Tsai Subject: Re: [PATCH v4 08/19] irqdomain: Refactor __irq_domain_alloc_irqs() In-Reply-To: <20230116135044.14998-9-johan+linaro@kernel.org> References: <20230116135044.14998-1-johan+linaro@kernel.org> <20230116135044.14998-9-johan+linaro@kernel.org> Date: Tue, 17 Jan 2023 22:34:40 +0100 Message-ID: <87v8l4kfpr.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230117_133442_447133_C924194A X-CRM114-Status: UNSURE ( 8.62 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 16 2023 at 14:50, Johan Hovold wrote: > Refactor __irq_domain_alloc_irqs() so that it can be called internally > while holding the irq_domain_mutex. > > This will be used to fix a shared-interrupt mapping race. No functional change. The split out internal function will be used to fix a shared interrupt mapping race. This change is therefore tagged with the same fixes tag. Fixes: .... > -int __irq_domain_alloc_irqs(struct irq_domain *domain, int irq_base, > - unsigned int nr_irqs, int node, void *arg, > - bool realloc, const struct irq_affinity_desc *affinity) > +static int ___irq_domain_alloc_irqs(struct irq_domain *domain, int irq_base, > + unsigned int nr_irqs, int node, void *arg, > + bool realloc, const struct irq_affinity_desc *affinity) __ vs. ___ is almost undistinguishable. irq_domain_alloc_irqs_locked() nicely explains what this is about, no? Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel