From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B049FC433DF for ; Fri, 7 Aug 2020 14:01:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D89D21744 for ; Fri, 7 Aug 2020 14:01:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nA2oE8gX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s20HpXZ5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D89D21744 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=11D906yqMtPlwKMZta4vLpbsYGCZEoLtHaPuwJxD7KE=; b=nA2oE8gXKY8Ios6oBivEXnDEV Ll2iwmc44oJkZq1lnXePNNi+SGXhAvXyIaZA9mLPR2g+hbLLNgk8NTuj5y6uN1ecLHgSr8nFiStMt N52R/DZpA11i0MNtKTAPmbvhYbV5QitbBwjYdsokK/zvc7mZelUMLmJrYZJ5IHy8Ah79691TtActK xHjTkyuCZqPnH6V28pyceGK+3+mcorsYH/jEJVWh0s+GVXpYb5/V9A1daz5y+ZOuluqqH91dvWEEH 427zID+2a0BnP1pTC5F3Qq2G/vZokxjxMPww7TUc+mHIPKjG+8dzyFvvvzb5Oof6YuK/8j8ABMiz3 u//48glNg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k42tx-0004e2-CJ; Fri, 07 Aug 2020 13:59:18 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k42tv-0004d1-07 for linux-arm-kernel@lists.infradead.org; Fri, 07 Aug 2020 13:59:16 +0000 Received: by mail-lj1-x243.google.com with SMTP id v12so2292227ljc.10 for ; Fri, 07 Aug 2020 06:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=LlDfM7lfRWt2Qfq665Z9z/N/zereVKNRYo5Ume41bXA=; b=s20HpXZ5m2YvWnbApSNg8NgVv0sZPEJWvfd0maoB2NND3WBfda2ycvvSraEX0qd1yJ n5+oDa+fv7Smj6bZyRF0PNKXNMG9xQEGBmkWCMUIVAv7iKDcJuwF9yey9V+TgjhHuxyJ RE7FqLLk6MA2AoAy5Rz6dSJtG1CB6lHaYPlQPqLLdj80L6ocSwRzC774GhAWzk5RUsov L1oeIp9mg4XAwfRn77Y3c78IrKmpt8OO60YL85YsLubaw+d2jINv3GjTz8S6EoXE9wTA Jcti3skyHnnDxfm43Edf5yIp1ph+KPqSwAehep6RzX3Z76KJxLGfJOyaJTjgBtEHFboG VTHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :date:message-id:mime-version; bh=LlDfM7lfRWt2Qfq665Z9z/N/zereVKNRYo5Ume41bXA=; b=X9Xco2tydDe9lPgggHZ6CM/9Eqo122v1u2Cs0+BdMIU8qmecjhS414JDvKKCq/XzFx 3gkAiG8LfuO0Y6ei8SvFE9DIet+k7gpKXPWGwtIcWRseyhEX85p2JqfPj9MQCTvTSBy2 fA5P71tYAsvpZOGyVmgHUot7wRx2tIdrutpJ0R+nDBauoE1gp6nIQqU6UmyteaGHztrT WqVxCBk262g8BVrmfQSyPXIiU7rmtCRRtU4kgyjG2ZI0eIM2vPYXAx2HlqXHSj/ufYiO mn6kpYpXj4dCx5qGPFIRdWP05uCXrJaoZn+68rWAsFFStKyz2yQ7DNURjZjOnBdIzt+q veuQ== X-Gm-Message-State: AOAM533FEuxuK/pPzTkIvEfbxcyj9lrDfeqMJHOlQKSsSPiiK4a+TwL/ RocsSkD2Pmi/UMr/lv3DNUU= X-Google-Smtp-Source: ABdhPJwdWQcHx6yEpnG5CUGETnHGJOgZ8C5g6CzctlmkDAQV71EGHREL5KMTeOqbXnBqb8mpESfiLg== X-Received: by 2002:a2e:988a:: with SMTP id b10mr5901350ljj.26.1596808753789; Fri, 07 Aug 2020 06:59:13 -0700 (PDT) Received: from saruman ([165.231.178.18]) by smtp.gmail.com with ESMTPSA id h23sm4264411lfk.37.2020.08.07.06.59.12 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Aug 2020 06:59:13 -0700 (PDT) From: Felipe Balbi To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 09/41] usb: gadget: s3c-hsudc: remove platform header dependency In-Reply-To: <20200806182059.2431-9-krzk@kernel.org> References: <20200806181932.2253-1-krzk@kernel.org> <20200806182059.2431-9-krzk@kernel.org> Date: Fri, 07 Aug 2020 16:59:08 +0300 Message-ID: <87v9hupnf7.fsf@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200807_095915_457587_96F58349 X-CRM114-Status: GOOD ( 20.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Russell King , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============2209776523036930261==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2209776523036930261== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Krzysztof Kozlowski writes: > From: Arnd Bergmann > > There is no real phy driver, so s3c-hsudc just pokes the registers > itself. Improve this a little by making it a platform data callback > like we do for gpios. > > There is only one board using this driver, and it's unlikely > that another would be added, so this is a minimal workaround. > > Signed-off-by: Arnd Bergmann > [krzk: Include regs-s3c2443-clock.h in ifdef to fixup build on s3c6400] > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Include regs-s3c2443-clock.h in ifdef to fixup build on s3c640 > --- > .../include/mach/regs-s3c2443-clock.h | 49 +++++++++++++++++ > arch/arm/plat-samsung/devs.c | 6 ++ > drivers/usb/gadget/udc/s3c-hsudc.c | 55 ++----------------- > include/linux/platform_data/s3c-hsudc.h | 2 + > 4 files changed, 61 insertions(+), 51 deletions(-) > > diff --git a/arch/arm/mach-s3c24xx/include/mach/regs-s3c2443-clock.h b/ar= ch/arm/mach-s3c24xx/include/mach/regs-s3c2443-clock.h > index 6bf924612b06..682759549e63 100644 > --- a/arch/arm/mach-s3c24xx/include/mach/regs-s3c2443-clock.h > +++ b/arch/arm/mach-s3c24xx/include/mach/regs-s3c2443-clock.h > @@ -10,6 +10,8 @@ > #ifndef __ASM_ARM_REGS_S3C2443_CLOCK > #define __ASM_ARM_REGS_S3C2443_CLOCK >=20=20 > +#include > + > #define S3C2443_CLKREG(x) ((x) + S3C24XX_VA_CLKPWR) >=20=20 > #define S3C2443_PLLCON_MDIVSHIFT 16 > @@ -184,5 +186,52 @@ s3c2443_get_epll(unsigned int pllval, unsigned int b= aseclk) > return (unsigned int)fvco; > } >=20=20 > +static inline void s3c_hsudc_init_phy(void) This should, really, be a PHY driver under drivers/phy, since the goal is to make this platform-independent, might as well take the opportunity to introduce a proper driver, no? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl8tXiwACgkQzL64meEa mQb4cRAAtKVS+QHFTU0k03XTqRPNweYAKDUlwxtRGzKb/zcmEFFF/mPd9Eq99Nd7 Wp82AoSPiNQKeHWUNn8WCRGpcGZoK8QI5+Y569PhmK562s8NHKrMkBZKgCSUPRB6 qPNpfUEiEcD5yKG79mnyq5IbOJUtS4zxby3NIxaWHZNsrxrscottVmUd9ip+XYqP GJbpK7mut4VZcoEZYmcNZWG8+vnrbf+eWp1vCvCyuOeWMxVhoJuUiKCMV1HhISYs JhJNBUtFinGRHgN8Ga4DUmQf36qLeDtccriwn35PrXgFOZbWPh4YbEQifZHwnE8h wkkE0KVVrKwURgKfDshst2J+8IAHghfEuHdG7S4IsSvqL3EmE85dzB5PCug0Uq93 s72AlL9ued+ZK716gMzlVPeMJyyfXnSYRQNeyJ5QZvMD50FW+wqhIYI+Z3D1lEBc asL4Y76t7lqK98H8nltZ9JrHZjXqj1o1msmsIzyvNuxDtSPQTWFQEwq26ljuGtFu k1zhPg+3qziBgdEx+b20e+J41xnCIs7qg3VU918Z7rHtAgSA+rCEEiSH3zsJJ30D NKg3Zxr05tu4KGSF0fTUp9Eq+yTyE8k7tjh8r2XpUK1eUM2b/JwmL/E9I1sh6XGX 5+mwU9Il/2+MWkhyKPZyJLFHW90HG1RzQDhGxNS8NyYywxKZ/9g= =Vwlr -----END PGP SIGNATURE----- --=-=-=-- --===============2209776523036930261== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2209776523036930261==--