From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 545ECC34026 for ; Tue, 18 Feb 2020 14:28:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 254C4208C4 for ; Tue, 18 Feb 2020 14:28:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jmO5QR+x"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b="NyLbT3+Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 254C4208C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=geanix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JNedNiMPLuoW/ZXGtQ+KjI0BsIIvtMIjukPbSjfhr5Y=; b=jmO5QR+xNfGsvS ZxCM0fQBa/VS3GEOkHW3a4a4AHMeE7T+gKcHGpjx2jg2sAM6k5YINtrnuFIAMOTuoDpfxxGRXYots Q8qMvt86nXMbKizw5lH9XvIH52ZFAo1XL2D42aUFGI2HduQr9QrMUwgnROMrbVv9HMt4OiW+5TKpW WVTtTwFKhXgULaG/5eV0KDNCwVznj53b5mwv/wNOkxYWcSLtAd2UAlH+2QqmEgmk2OoQ0aAnkhRbb /KE1AfSQGZX2iQI7AV8rAmcr+UwAL6zGHCsl527bLMneC/t5HzHq5weKnSWtG8cqOdmni+7XdGB45 MnWFp4LsBDg6BwEWnF4Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j43rI-0004fe-NF; Tue, 18 Feb 2020 14:28:20 +0000 Received: from first.geanix.com ([116.203.34.67]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j43rG-0004fB-1R for linux-arm-kernel@lists.infradead.org; Tue, 18 Feb 2020 14:28:19 +0000 Received: from localhost (unknown [193.163.1.7]) by first.geanix.com (Postfix) with ESMTPSA id D029AC0029; Tue, 18 Feb 2020 14:27:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=geanix.com; s=first; t=1582036045; bh=mHzt9vtnKLHNpF1/+TJ0Mqr2u8xuO4Fqk8u6fW/EDks=; h=From:To:Cc:Subject:References:Date:In-Reply-To; b=NyLbT3+ZSzHRzg/t+SZBSVHIzj+RTsJ8tdYGFRfqqiEUS/jqPTEink6P8B1VeKQhi 03YfkqFq9I2sRDrqM0dSjOclLHHJv3YSXe9r0dW85VE4IFynlrAuMO4csbTBBuHRnf mVm7wqFLiL/jbvxZDh1AZ0iJTuPQgiOV89lvoD2fmQrNuShJ7VB4SWVpAUPNcPjNQn UAk4u1b5PwE9sqkSOVAwe/PgUxu/6Tfe9avRct3mnZ+rsG7n4Jzszl2sNz81cZIIrU UEQzUDO1jdtad3twes8tIoMr/IP5PMAGMuHXN3eRb2MmX8kv23mFFOaLn88y4gVA/1 9eN3uSeayg7ZA== From: Esben Haabendal To: Andrew Lunn Subject: Re: [PATCH 8/8] net: ll_temac: Add ethtool support for coalesce parameters References: <20200218082741.7710-1-esben@geanix.com> <20200218133943.GA10541@lunn.ch> Date: Tue, 18 Feb 2020 15:28:13 +0100 In-Reply-To: <20200218133943.GA10541@lunn.ch> (Andrew Lunn's message of "Tue, 18 Feb 2020 14:39:43 +0100") Message-ID: <87v9o4gebm.fsf@geanix.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200218_062818_232574_4C762B3E X-CRM114-Status: UNSURE ( 8.61 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Michal Simek , linux-kernel@vger.kernel.org, Petr =?utf-8?Q?=C5=A0tetiar?= , "David S . Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Andrew Lunn writes: > Hi Esben > >> + if (ec->tx_coalesce_usecs) >> + lp->coalesce_delay_tx = >> + min(255U, (ec->tx_coalesce_usecs * 100) / 512); >> + >> + pr_info("%d -> %d %d -> %d\n", >> + ec->rx_coalesce_usecs, lp->coalesce_delay_rx, >> + ec->tx_coalesce_usecs, lp->coalesce_delay_tx); > > I guess this is left over from debug? You don't actually want it here? Yes, I will remove that in v2. Thanks. /Esben _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel