From: arno@natisbad.org (Arnaud Ebalard)
To: linux-arm-kernel@lists.infradead.org
Subject: [REGRESSION, BISECTED] mvneta broken in 3.14 on RN2120, RN102 and RN104 after e3a8786c10e7
Date: Sat, 12 Apr 2014 18:37:54 +0200 [thread overview]
Message-ID: <87vbueo659.fsf@natisbad.org> (raw)
In-Reply-To: <20140412183112.7ca31cb6@skate> (Thomas Petazzoni's message of "Sat, 12 Apr 2014 18:31:12 +0200")
Hi Thomas,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
>> I built a first kernel with the 'else' branch above removed (rationale:
>> SERDES config was not set for RGMII prior to the patch). The issue
>> remained.
>>
>> - mvneta_gmac_rgmii_set(pp, 1);
>> + val = mvreg_read(pp, MVNETA_GMAC_CTRL_2);
>> +
>> + val |= MVNETA_GMAC2_PCS_ENABLE | MVNETA_GMAC2_PORT_RGMII;
>>
>> I removed MVNETA_GMAC2_PCS_ENABLE flag setting (rationale: it was only
>> done for SGMII prior to the patch and all my platforms have RGMII
>> connected PHY). *The issue disappeared on all 3 NAS with that simple
>> change*.
>
> Yes, issue known. See https://bugzilla.kernel.org/show_bug.cgi?id=73401.
>
> Unfortunately, at this point I don't have enough informations to fix
> both issues: the issue you're having, and the issue of using mvneta as
> a module. Since the issue you're having is much more problematic, I'll
> send a patch to revert my patch, until I have enough informations to
> fix the problem in a proper way.
>
> Thanks for your report!
Thanks for your work and the fast feedback. Do not hesitate to bug me if
you want me to do some tests at some point.
Cheers,
a+
prev parent reply other threads:[~2014-04-12 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-12 16:28 [REGRESSION, BISECTED] mvneta broken in 3.14 on RN2120, RN102 and RN104 after e3a8786c10e7 Arnaud Ebalard
2014-04-12 16:31 ` [REGRESSION,BISECTED] " Thomas Petazzoni
2014-04-12 16:37 ` Arnaud Ebalard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbueo659.fsf@natisbad.org \
--to=arno@natisbad.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).