From mboxrd@z Thu Jan  1 00:00:00 1970
From: arno@natisbad.org (Arnaud Ebalard)
Date: Sat, 27 Apr 2013 20:55:50 +0200
Subject: [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 PWM fan
 controller
In-Reply-To: <20130427165650.GA26415@roeck-us.net> (Guenter Roeck's message of
 "Sat, 27 Apr 2013 09:56:51 -0700")
References: <cover.1366753420.git.arno@natisbad.org>
 <63961d39aee9db94767f28fd441312bec2029473.1366753420.git.arno@natisbad.org>
 <20130427140331.GL17771@kw.sim.vm.gnt>
 <20130427165650.GA26415@roeck-us.net>
Message-ID: <87vc77247d.fsf@natisbad.org>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi Guenter, Jean, Simon,

Guenter Roeck <linux@roeck-us.net> writes:

> On Sat, Apr 27, 2013 at 04:03:31PM +0200, Simon Guinot wrote:
>> On Wed, Apr 24, 2013 at 12:05:56AM +0200, Arnaud Ebalard wrote:
>> > +	/*
>> > +	 * Set default configuration values before passing the structure
>> > +	 * to OF helpers to overload them using those provided by .dts
>> > +	 * file (if any). Final config is then commited.
>> > +	 */
>> > +	g762_config_init(&conf);
>> > +	g762_config_of_overload(client, &conf);
>> > +	err = g762_config_commit(client, &conf);
>> > +	if (err)
>> > +		goto out;
>> 
>> One more comment... Sorry for the multiple replies :)
>> 
>> I am not sure that applying a configuration anyway is a good idea.
>> I think it could be best to stick with the bootloader configuration if
>> no platform data nor device tree data are given.
>> 
> Yes, good point. You are absolutely right.

Thanks you all for your feedback. I will take all your comments into
account and work on a new version. I am somewhat unavailable next week
so may not be able to push something before next week end.

Cheers,

a+