public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnaud.patard@rtp-net.org (Arnaud Patard (Rtp))
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] crypto: sahara: Add driver for SAHARA2 accelerator.
Date: Thu, 28 Feb 2013 12:07:48 +0100	[thread overview]
Message-ID: <87vc9chf23.fsf@lebrac.rtp-net.org> (raw)
In-Reply-To: <1361961711-4603-3-git-send-email-javier.martin@vista-silicon.com> (Javier Martin's message of "Wed, 27 Feb 2013 11:41:50 +0100")

Javier Martin <javier.martin@vista-silicon.com> writes:

Hi,

> SAHARA2 HW module is included in the i.MX27 SoC from
> Freescale. It is capable of performing cipher algorithms
> such as AES, 3DES..., hashing and RNG too.

The rmmod oops is gone with this version, thanks.

>
> This driver provides support for AES-CBC and AES-ECB
> by now.
>
> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
> ---
>  drivers/crypto/Kconfig  |   10 +
>  drivers/crypto/Makefile |    1 +
>  drivers/crypto/sahara.c | 1070 +++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 1081 insertions(+)
>  create mode 100644 drivers/crypto/sahara.c
>
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index 87ec4d0..7d73f5a 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -276,6 +276,16 @@ config CRYPTO_DEV_PICOXCELL
>  
>  	  Saying m here will build a module named pipcoxcell_crypto.
>  
> +config CRYPTO_DEV_SAHARA
> +	tristate "Support for SAHARA crypto accelerator"
> +	depends on MACH_MX27 && EXPERIMENTAL && OF

maybe switch to ARCH_MXC instead of MAC_MX27 ?

[...]

> +static struct platform_driver sahara_driver = {
> +	.probe		= sahara_probe,
> +	.remove		= __devexit_p(sahara_remove),

Please remove the __devexit_p too.


For information, you'll find below what I've changed to test the driver on my
imx51. It's not perfect but it's enough for testing things.


Arnaud
-------------- next part --------------
A non-text attachment was scrubbed...
Name: imx51-sahara.patch
Type: text/x-diff
Size: 5482 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130228/ba3ba53a/attachment-0001.bin>

  parent reply	other threads:[~2013-02-28 11:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-27 10:41 [PATCH v2 0/3] crypto: sahara: Add support for SAHARA in i.MX27 Javier Martin
2013-02-27 10:41 ` [PATCH v2 1/3] i.MX27: Add clock support for SAHARA2 Javier Martin
2013-02-27 10:41 ` [PATCH v2 2/3] crypto: sahara: Add driver for SAHARA2 accelerator Javier Martin
2013-02-27 10:47   ` Arnd Bergmann
2013-02-28 11:07   ` Arnaud Patard (Rtp) [this message]
2013-02-28 14:08     ` javier Martin
2013-03-01  7:28       ` Arnaud Patard (Rtp)
2013-02-27 10:41 ` [PATCH v2 3/3] crypto: sahara: Add device tree binding for SAHARA2 Javier Martin
2013-02-27 20:05   ` Sascha Hauer
2013-02-28  7:51     ` javier Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vc9chf23.fsf@lebrac.rtp-net.org \
    --to=arnaud.patard@rtp-net.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox