linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: OMAP2+: hwmod: Add a new state to handle hwmods left enabled at init
Date: Mon, 21 Nov 2011 10:38:09 -0800	[thread overview]
Message-ID: <87vcqdqq26.fsf@ti.com> (raw)
In-Reply-To: <1321877570-4333-1-git-send-email-rnayak@ti.com> (Rajendra Nayak's message of "Mon, 21 Nov 2011 17:42:50 +0530")

Rajendra Nayak <rnayak@ti.com> writes:

> An hwmod with a 'HWMOD_INIT_NO_IDLE' flag set, is left in
> enabled state by the hwmod framework post the initial setup.
> Once a real user of the device (a driver) tries to enable it
> at a later point, the hwmod framework throws a WARN() about
> the device being already in enabled state.
>
> Fix this by introducing a new state '_HWMOD_STATE_ENABLED_AT_INIT'
> to identify such devices/hwmods. When the device/hwmod
> is requested to be enabled (the first time) by its driver/user,
> nothing except the mux-enable and a state change to '_HWMOD_STATE_ENABLED'
> is needed. The mux data is board specific and is unavailable during
> initial enable() of the device, done by the framework as part of
> setup().
>
> A good example of a such a device is an UART used as debug console.
> The UART module needs to be kept enabled through the boot, until the
> UART driver takes control of it, for debug prints to appear on
> the console.
>
> Acked-by: Kevin Hilman <khilman@ti.com>
> Acked-by: Benoit Cousson <b-cousson@ti.com>

Looks like we need a

Tested-by: Govindraj Raja <govindraj.raja@ti.com>

here as well.   Thanks Govindraj for testing.

> Signed-off-by: Rajendra Nayak <rnayak@ti.com>


Kevin

  reply	other threads:[~2011-11-21 18:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21 12:12 [PATCH v3] ARM: OMAP2+: hwmod: Add a new state to handle hwmods left enabled at init Rajendra Nayak
2011-11-21 18:38 ` Kevin Hilman [this message]
2011-12-16 10:37 ` Paul Walmsley
2011-12-16 11:03   ` Rajendra Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vcqdqq26.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).