From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7A1EC98324 for ; Sun, 27 Sep 2026 09:20:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OsH0bMd9YqMqOaabYQzUoiaMXLlzQlFvj2cX0wC1/+Y=; b=c5YoX+8vfJel6FIZHYJF9TCR2f TG9vwUfO+slWgJeEOUGaOBp+5SanUkog2y2gu79qNjV29Zk4rCCcqOnSKXHw1cuxhxaxsbJUSZqQI DrsFnZH4GbXLtLR5JcUvLD5L5p0eKFHMJ/KY4gE8XLfHLiNf5Lq1a0eNl21p2qqmTTI9+3s/gcfyh 0lq6We7sIWSVuygS2gGNa+oVHXfaaVSBodYp39yAAD/3F8FZeWSDh7slVIi+Uf3RYc2JJWed1atte R8tAp63qzrInW4enMkFAR6c2YjQDmVx3oGCuuw1jRXl8jkBDwlncAkJwiiBLvNpbIvyyaxFejQFQE A0ACChWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xAl3y-0000000GAq0-3fP1; Sun, 27 Sep 2026 09:20:50 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xAl3w-0000000GApu-3pUv for linux-arm-kernel@lists.infradead.org; Sun, 27 Sep 2026 09:20:48 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 3556A40408; Sun, 27 Sep 2026 09:20:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 166131F000FF; Sun, 27 Sep 2026 09:20:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790500848; bh=OsH0bMd9YqMqOaabYQzUoiaMXLlzQlFvj2cX0wC1/+Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Hr5lpLoPzc59zoryjKROdhXjYHWA4R0M67tQHgwK4+X0Jx9hx8jrXGzlRcRW8KhZ5 dIeNgku4gtK7xMYcB2PLGUScclpIW+/pmZY6DieO3ev3s4BrdXvMN7knY0S+w7vieB gNbXA0Svof0Jm3ZabLmd6xj/ePJo6XyhuKXHYgz9jIPUFSJ6KfR6XqtjfjukSXOOCd Jmoe1MXOwsOKkFo5ZIEnN80aUjOPcKRC2ufGVjLZLzKYtER6nFyTu2afyV5WXRrVe3 E4IEAz20A2nR1ZXtWBIvVT7nGoiIJaTc4ZnftGIBnZxK8dfP9c24Fn0bjIjEGRNwKg rzmIW2Qvw/v7g== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xAl3u-0000000DxF3-0hn6; Sun, 27 Sep 2026 09:20:46 +0000 Date: Sun, 27 Sep 2026 10:23:53 +0100 Message-ID: <87wls72gk6.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: Thomas Gleixner , Radu Rendec , James Morse , Will Deacon , Fuad Tabba , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] irqchip/gic-v3: Memory-safety fixes on the probe paths In-Reply-To: <20260925085000.753400-1-fuad.tabba@linux.dev> References: <20260925085000.753400-1-fuad.tabba@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: fuad.tabba@linux.dev, tglx@kernel.org, radu@rendec.net, james.morse@arm.com, will@kernel.org, tabba@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 25 Sep 2026 09:49:57 +0100, Fuad Tabba wrote: > > Hi folks, > > Changes since v1 [1]: > - Patch 3 marks the skipped CPU in broken_rdists, so it's kept > offline. (Marc, sashiko) > > Three probe-time bugs in the GICv3 drivers. The kernel keeps running > after each of them, so the memory involved is live rather than on the > way to a reset. > > The first two free memory an enabled ITS still points at. Boot carries > on because its_init() discards a failed probe and gic_init_bases() > discards what its_init() returns. The third is a write past the end of > redist_regs[] for an enabled GICC with a zero GICR base, on a MADT with > no GICR entries. fa2dabe57220e's commit message says such tables exist, > and I haven't seen one. > > Based on Linux 7.3-rc4 (93f51579e7df2). > > Cheers, > /fuad > > [1] https://lore.kernel.org/all/20260924161514.1112730-1-fuad.tabba@linux.dev/ > > Fuad Tabba (3): > irqchip/gic-v3-its: Don't free a vPE table shared with another ITS > irqchip/gic-v3-its: Don't free the tables of an enabled ITS > irqchip/gic-v3: Don't register a redistributor that was never counted > > drivers/irqchip/irq-gic-v3-its.c | 16 +++++++++++----- > drivers/irqchip/irq-gic-v3.c | 11 +++++++++++ > 2 files changed, 22 insertions(+), 5 deletions(-) > > > base-commit: 93f51579e7df248780214094418f205253383cc5 Reviewed-by: Marc Zyngier M. -- Jazz isn't dead. It just smells funny.