* [PATCH RESEND] wifi: mt76: mt7921: Check devm_kasprintf() returned value
@ 2024-09-03 1:44 Ma Ke
2024-09-03 7:50 ` Kalle Valo
2024-09-04 9:00 ` Matthias Brugger
0 siblings, 2 replies; 3+ messages in thread
From: Ma Ke @ 2024-09-03 1:44 UTC (permalink / raw)
To: nbd, lorenzo, ryder.lee, shayne.chen, sean.wang, kvalo,
matthias.bgg, angelogioacchino.delregno, mingyen.hsieh, deren.wu,
make24, ruanjinjie, greearb, akpm
Cc: linux-wireless, linux-kernel, linux-arm-kernel, linux-mediatek,
stable
devm_kasprintf() can return a NULL pointer on failure but this returned
value is not checked. Fix this lack and check the returned value.
Found by code review.
Cc: stable@vger.kernel.org
Fixes: 6ae39b7c7ed4 ("wifi: mt76: mt7921: Support temp sensor")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
---
drivers/net/wireless/mediatek/mt76/mt7921/init.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/init.c b/drivers/net/wireless/mediatek/mt76/mt7921/init.c
index ef0c721d26e3..5ab395d9d93e 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/init.c
@@ -52,6 +52,8 @@ static int mt7921_thermal_init(struct mt792x_phy *phy)
name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7921_%s",
wiphy_name(wiphy));
+ if (!name)
+ return -ENOMEM;
hwmon = devm_hwmon_device_register_with_groups(&wiphy->dev, name, phy,
mt7921_hwmon_groups);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] wifi: mt76: mt7921: Check devm_kasprintf() returned value
2024-09-03 1:44 [PATCH RESEND] wifi: mt76: mt7921: Check devm_kasprintf() returned value Ma Ke
@ 2024-09-03 7:50 ` Kalle Valo
2024-09-04 9:00 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2024-09-03 7:50 UTC (permalink / raw)
To: Ma Ke
Cc: nbd, lorenzo, ryder.lee, shayne.chen, sean.wang, matthias.bgg,
angelogioacchino.delregno, mingyen.hsieh, deren.wu, ruanjinjie,
greearb, akpm, linux-wireless, linux-kernel, linux-arm-kernel,
linux-mediatek, stable
Ma Ke <make24@iscas.ac.cn> writes:
> devm_kasprintf() can return a NULL pointer on failure but this returned
> value is not checked. Fix this lack and check the returned value.
>
> Found by code review.
>
> Cc: stable@vger.kernel.org
> Fixes: 6ae39b7c7ed4 ("wifi: mt76: mt7921: Support temp sensor")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
> ---
> drivers/net/wireless/mediatek/mt76/mt7921/init.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/init.c b/drivers/net/wireless/mediatek/mt76/mt7921/init.c
> index ef0c721d26e3..5ab395d9d93e 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/init.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/init.c
> @@ -52,6 +52,8 @@ static int mt7921_thermal_init(struct mt792x_phy *phy)
>
> name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7921_%s",
> wiphy_name(wiphy));
> + if (!name)
> + return -ENOMEM;
>
> hwmon = devm_hwmon_device_register_with_groups(&wiphy->dev, name, phy,
> mt7921_hwmon_groups);
You sent the previous version of this on August 26th:
https://patchwork.kernel.org/project/linux-wireless/patch/20240826095535.2603538-1-make24@iscas.ac.cn/
Please stop spamming like this and understand that maintainers are busy.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
https://docs.kernel.org/process/submitting-patches.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] wifi: mt76: mt7921: Check devm_kasprintf() returned value
2024-09-03 1:44 [PATCH RESEND] wifi: mt76: mt7921: Check devm_kasprintf() returned value Ma Ke
2024-09-03 7:50 ` Kalle Valo
@ 2024-09-04 9:00 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2024-09-04 9:00 UTC (permalink / raw)
To: Ma Ke, nbd, lorenzo, ryder.lee, shayne.chen, sean.wang, kvalo,
angelogioacchino.delregno, mingyen.hsieh, deren.wu, ruanjinjie,
greearb, akpm
Cc: linux-wireless, linux-kernel, linux-arm-kernel, linux-mediatek,
stable
On 03/09/2024 03:44, Ma Ke wrote:
> devm_kasprintf() can return a NULL pointer on failure but this returned
> value is not checked. Fix this lack and check the returned value.
>
> Found by code review.
>
> Cc: stable@vger.kernel.org
> Fixes: 6ae39b7c7ed4 ("wifi: mt76: mt7921: Support temp sensor")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Reviwed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt7921/init.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/init.c b/drivers/net/wireless/mediatek/mt76/mt7921/init.c
> index ef0c721d26e3..5ab395d9d93e 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/init.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/init.c
> @@ -52,6 +52,8 @@ static int mt7921_thermal_init(struct mt792x_phy *phy)
>
> name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7921_%s",
> wiphy_name(wiphy));
> + if (!name)
> + return -ENOMEM;
>
> hwmon = devm_hwmon_device_register_with_groups(&wiphy->dev, name, phy,
> mt7921_hwmon_groups);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-04 9:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-03 1:44 [PATCH RESEND] wifi: mt76: mt7921: Check devm_kasprintf() returned value Ma Ke
2024-09-03 7:50 ` Kalle Valo
2024-09-04 9:00 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).