From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BE71C83F16 for ; Thu, 29 Aug 2024 13:14:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xi8Qk6/yo+z2xue1pu6ArfZkIB9NZHNwbWBMMQVAWw0=; b=fajxjsrNjiVtzA9hzivMYnJMGa ASQYNcXMzNjBg29TS7e2L6LIri5gk1KJUw4XsvtR0vxTjnvGXkX7VzPcfFLMEewptB9nwexHgZmf9 rgt6Vb8B/U6ZUbjxX5M4ii6+iyQh2nDqPFYntiP72eXGYPdL+Jp28kpurmh6JVMyNOeND/YeKjB1U b6X/LoCKqN6Lowll51eXrXsL+1dwBCeOXgvufzOFWMUE8oYM8vV+xRlf7OXIpBdlFEk1XMIpOFAMH 2Qx/R1vkdIi82CX+WjmmU15ib/egjbYMf/4X28hyoH4tr0YPmEqABGrtx7Ilw1dGQioRmGNvoIqDB yLo5oDlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjeyy-000000026h9-1X1M; Thu, 29 Aug 2024 13:14:36 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjex4-000000025z5-1HdR for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2024 13:12:42 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1724937156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xi8Qk6/yo+z2xue1pu6ArfZkIB9NZHNwbWBMMQVAWw0=; b=Ab2CXfyZFci3E7J2IFQD1bogFsly6JhZ33cyfDGBgwNAmovS7p97ZqgUPcCXMh7B5lAdQT oB56bXurDz8SwOYX/1DOaR8BjSwK07D0F12Ej4x16nrOxD+H5t9GaP/JEu3tEZDetlATwA eviElp7DW5utYgXtVofuBQp8F8abHKr0Eiz7nRXTTq24rX7hV5Brpa/RUx0yUinMmP/CLT 5p8PSZ7PLkGgJc5y6v3FXV9aebdycZyISifmY4Ar/WBLzJUj9l6ImsE+Wcqnaks8ByvJq5 EBYErRk80VHmOIj7BiWEPuNYzR8ek6QDKitmkGvWkAgjgFBt1VjKvVkmiw8hdg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1724937156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xi8Qk6/yo+z2xue1pu6ArfZkIB9NZHNwbWBMMQVAWw0=; b=RzqzsieuQComb0N5FzZoQ+NVPc7369MkHiKj2wKiJ27y0LP3lvAYVZMlGclV67Xt0t2Mub OD5p2Ey/6DF5xVDg== To: Nick Chan , Hector Martin , Sven Peter , Alyssa Rosenzweig , Rob Herring , Krzysztof Kozlowski , Conor Dooley , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, Nick Chan Subject: Re: [PATCH RESEND 3/3] irqchip/apple-aic: Add a new "Global fast IPIs only" feature level In-Reply-To: <20240829110436.46052-4-towinchenmi@gmail.com> References: <20240829110436.46052-1-towinchenmi@gmail.com> <20240829110436.46052-4-towinchenmi@gmail.com> Date: Thu, 29 Aug 2024 15:12:36 +0200 Message-ID: <87wmjza2wr.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_061238_512994_CF010AFC X-CRM114-Status: UNSURE ( 6.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 29 2024 at 19:02, Nick Chan wrote: > > + if (irqc->info.local_fast_ipi) > + static_branch_enable(&use_local_fast_ipi); > + else > + static_branch_disable(&use_local_fast_ipi); As you define the key to be true by default there is no point to enable the branch some more. Copy & pasta ... Thanks, tglx