From: Marc Zyngier <maz@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Oliver Upton <oliver.upton@linux.dev>,
James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Fuad Tabba <tabba@google.com>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] KVM: arm64: Fix outdated comment about incomplete FGT bitmask definitions
Date: Wed, 31 Jul 2024 20:55:59 +0100 [thread overview]
Message-ID: <87wml149ps.wl-maz@kernel.org> (raw)
In-Reply-To: <20240731-kvm-arm64-fgt-doc-v1-1-abb364f8fe57@kernel.org>
On Wed, 31 Jul 2024 19:58:37 +0100,
Mark Brown <broonie@kernel.org> wrote:
>
> Comments in the code say that our definitions for the FGT registers are not
> the generated ones and are updated only as far as DDI0487 J.a however in
> commit 9ff67dd26a9e ("KVM: arm64: Use generated FGT RES0 bits instead of
> specifying them") we updated to use the generated definitions, and as of
> the release of DDI0487 K.a the XML in DD0601 is in sync with the ARM.
s/ARM/ARM ARM/. Which revision of the XML? K.a and the latest version
of the XML are definitely not in sync.
Also, please make use of punctuation. I can't parse this *single*
sentence as it stands.
> Remove the outdated comment about divergence.
>
> Fixes: 9ff67dd26a9e ("KVM: arm64: Use generated FGT RES0 bits instead of specifying them")
Definitely *not* a fix.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2024-07-31 19:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 18:58 [PATCH 0/2] KVM: arm64: Fine grained traps documentation clarification Mark Brown
2024-07-31 18:58 ` [PATCH 1/2] KVM: arm64: Fix outdated comment about incomplete FGT bitmask definitions Mark Brown
2024-07-31 19:55 ` Marc Zyngier [this message]
2024-07-31 18:58 ` [PATCH 2/2] KVM: arm64: Clarify meaning of _MASK and _nMASK for FGT registers Mark Brown
2024-07-31 20:12 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wml149ps.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).